From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 143A11B1E7 for ; Wed, 10 Jan 2018 14:06:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8CA232065E; Wed, 10 Jan 2018 08:06:58 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 Jan 2018 08:06:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=NzRRSnoavTC9ZhyT1FfYg/0aMsGMVmbDSADO7/6SU8U=; b=DSL70Mvr wmeN8RR8ubQH5AxhuAXLrx7Jb2T6HL+EaOqDGfBaYgc02LsiGb+BLIa5n55OPzid MPBi+vM6hDb84+SR17CoixG5MBw30N7sA6yhycr22TAzMurY/10sgRnfDIuHbMue cDbT4pZ/slylwnb/W+asrk+Rxlz6Rh8BvW9bF9mcnP/PrQf37DeCldaAowuGRD/Z oMmWeEcSYhyU2/Rf4HFMUlsrI8UGqYP4qcJHV9z0IbR1sI8+reRR42gygqAjwiZB dZCsMtFO1GeOcNe4IfE3SR78r92mJOfwxa2Gl63XbWp1DR5XDQTGz24NGjP5hXQT Q6HnRaha/w8eRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=NzRRSnoavTC9ZhyT1FfYg/0aMsGMV mbDSADO7/6SU8U=; b=pz0boXZ3SdC5l4YNtvcAkz0voVgIYyBfyP30cEUeglTpK fpIoul77oVkmVjxEOTg9rIrcA7wPZOAiUFmrbYQF1JaDuKoUfq7DKZZWndp64/4G EAut1iJVZvFiOu6GdvVYfIbKPIQvw03cSG+nvhuK94XfBnS7WDW9wbqQwKMQ5mDj ZXvRM3gZWQtlYlI32pnBLk/GJ12QT2rr1tgjZg75oIQb6+4JPLUykFPQLNWglW/h JpcXPnH9q5wZ2GSGMMIzWmOZQ6yXmASr17eM0ezj6VmKN7/MKrZT/1yeRQqMTPLJ yEcc5hLOBwUmYA3DiDHXu7IKK/DfPWsCcpWDgp5gg== X-ME-Sender: Received: from yliu-mob (unknown [115.148.91.233]) by mail.messagingengine.com (Postfix) with ESMTPA id 46B51246CA; Wed, 10 Jan 2018 08:06:55 -0500 (EST) Date: Wed, 10 Jan 2018 21:06:52 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: Xiao Wang , tiwei.bie@intel.com, dev@dpdk.org, stephen@networkplumber.org, maxime.coquelin@redhat.com Message-ID: <20180110130652.GQ29540@yliu-mob> References: <20180110012356.57456-1-xiao.w.wang@intel.com> <20180110012356.57456-4-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110012356.57456-4-xiao.w.wang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 13:06:59 -0000 Thomas, look good to you? --yliu On Wed, Jan 10, 2018 at 09:23:54AM +0800, Xiao Wang wrote: > Suggested-by: Maxime Coquelin > Signed-off-by: Xiao Wang > Reviewed-by: Maxime Coquelin > --- > lib/librte_net/Makefile | 1 + > lib/librte_net/rte_arp.c | 42 ++++++++++++++++++++++++++++++++++++++ > lib/librte_net/rte_arp.h | 17 +++++++++++++++ > lib/librte_net/rte_net_version.map | 6 ++++++ > 4 files changed, 66 insertions(+) > create mode 100644 lib/librte_net/rte_arp.c > > diff --git a/lib/librte_net/Makefile b/lib/librte_net/Makefile > index 5e8a76b68..ab290c382 100644 > --- a/lib/librte_net/Makefile > +++ b/lib/librte_net/Makefile > @@ -13,6 +13,7 @@ LIBABIVER := 1 > > SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_net.c > SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_net_crc.c > +SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_arp.c > > # install includes > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include := rte_ip.h rte_tcp.h rte_udp.h rte_esp.h > diff --git a/lib/librte_net/rte_arp.c b/lib/librte_net/rte_arp.c > new file mode 100644 > index 000000000..d7223b044 > --- /dev/null > +++ b/lib/librte_net/rte_arp.c > @@ -0,0 +1,42 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#include > + > +#include > + > +#define RARP_PKT_SIZE 64 > +int > +rte_net_make_rarp_packet(struct rte_mbuf *mbuf, const struct ether_addr *mac) > +{ > + struct ether_hdr *eth_hdr; > + struct arp_hdr *rarp; > + > + if (mbuf->buf_len < RARP_PKT_SIZE) > + return -1; > + > + /* Ethernet header. */ > + eth_hdr = rte_pktmbuf_mtod(mbuf, struct ether_hdr *); > + memset(eth_hdr->d_addr.addr_bytes, 0xff, ETHER_ADDR_LEN); > + ether_addr_copy(mac, ð_hdr->s_addr); > + eth_hdr->ether_type = htons(ETHER_TYPE_RARP); > + > + /* RARP header. */ > + rarp = (struct arp_hdr *)(eth_hdr + 1); > + rarp->arp_hrd = htons(ARP_HRD_ETHER); > + rarp->arp_pro = htons(ETHER_TYPE_IPv4); > + rarp->arp_hln = ETHER_ADDR_LEN; > + rarp->arp_pln = 4; > + rarp->arp_op = htons(ARP_OP_REVREQUEST); > + > + ether_addr_copy(mac, &rarp->arp_data.arp_sha); > + ether_addr_copy(mac, &rarp->arp_data.arp_tha); > + memset(&rarp->arp_data.arp_sip, 0x00, 4); > + memset(&rarp->arp_data.arp_tip, 0x00, 4); > + > + mbuf->data_len = RARP_PKT_SIZE; > + mbuf->pkt_len = RARP_PKT_SIZE; > + > + return 0; > +} > diff --git a/lib/librte_net/rte_arp.h b/lib/librte_net/rte_arp.h > index 183641874..dad7423ad 100644 > --- a/lib/librte_net/rte_arp.h > +++ b/lib/librte_net/rte_arp.h > @@ -76,6 +76,23 @@ struct arp_hdr { > struct arp_ipv4 arp_data; > } __attribute__((__packed__)); > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Make a RARP packet based on MAC addr. > + * > + * @param mbuf > + * Pointer to the rte_mbuf structure > + * @param mac > + * Pointer to the MAC addr > + * > + * @return > + * - 0 on success, negative on error > + */ > +int > +rte_net_make_rarp_packet(struct rte_mbuf *mbuf, const struct ether_addr *mac); > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map > index 687c40eaf..213e6fd32 100644 > --- a/lib/librte_net/rte_net_version.map > +++ b/lib/librte_net/rte_net_version.map > @@ -12,3 +12,9 @@ DPDK_17.05 { > rte_net_crc_set_alg; > > } DPDK_16.11; > + > +EXPERIMENTAL { > + global: > + > + rte_net_make_rarp_packet; > +} DPDK_17.05; > -- > 2.15.1