From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0042.outbound.protection.outlook.com [104.47.2.42]) by dpdk.org (Postfix) with ESMTP id EE07B1B215; Wed, 10 Jan 2018 18:51:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lEwd8P1q9edhP6bS2Bu1jf4DJdN7sbPmWqF4txelPv4=; b=HmXsA4XHtKD9UykfOOw0SougJh0VAiRINs2tGrlgP+Alc41DF85VvUReSREjl+SfFPqpDYD++FtJmb+EYPOEegN2DVom0hI4GmSCpq57MT0F1roSRrvdKAZRAb7pFlD1yGTnmslK56yOG9zNLV6f9dUK9bgw9nm1ASGIbaJreZ8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 17:50:55 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org Date: Wed, 10 Jan 2018 09:50:38 -0800 Message-Id: <20180110175038.34374-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR1601CA0014.namprd16.prod.outlook.com (2603:10b6:300:da::24) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9a3d6b8b-4d43-463d-fa7a-08d55852b3aa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:SaLSTkHDdmFGoCc1WF5cOn3gLZGSqWXhEeYOHBDZvwf6vDQARqG+26ETdgYfPckxHCMcd1X9Bcq0LFwUDYRxZzcjjqD2FDjOOPwjzEzTFMzdVgKpkyRgE0NXc4Uv7SyfPmZ0w4SnfilMjGIZXtM4rXnHKtGpG2vtJkiHIvElVgX4iKg3r+EOFuc8SgoghUFrd9UPrK3/ompSQPnxOdwY8x9NNow35ri7p5+qUsVq2zlV9xLb0NkV8htpLMFALkyW; 25:xYQdzhl5C+0hddUL25JP6MPWthBieBZieBCelvGdeKySTCdDm/e3xgXbQ+ojz/uMiUs5OZs7yMk9kXZSW6PPrhXMqd6nHAhkWsg1VagDDvoTSai1YN0mozYCQD2yon1Pb6BGvdTIvS0X+NQKr9o2zP5TV7bd81W4qhc8YyeVgE0JnF/gPQZ0BIGAKqJ7uOB2TNb9mgKi/lTBS6qmwAE9PHzeeWKqOCPCu0AAsjXxHhnJuy5c+zj9EjgRq2qP+qhDhwrOV4XmkwuZs9IicFzeqw9u1hmhLY5KbeH7u5IzNn5ithOvDmyb+iF2FMnh+pl0N5Kz/2f0J0QmOyNx8S/Z9Q==; 31:uWctNkYwZKbljJDynjfj0Nx2Z2oK4wCT60wunl4mRhXcOV5iiWwNo2C/loTjzl5tIUwdqUCtdmu2c8Bt00UnfROqj3NArpCmONdiT7k6OaVFGmlwIOH0iAthWXzTESkVcoMLtRUnY9kpb4DpR8LnvrGrzodzn0XAdaaZeArFfCaPgOFbdC8D8IhCE48d2F69+apFcUTlCTu5p4Xcl16PCWhk0XbKlkgy5JYXKkPzC1w= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:XvkPpRvJEtP1Yv9aXOZsFenUgUxAsR/9Ud7g6Um+0uNd10LAO5j7GsFGEJo9vBE7bAbzQlzBYGoPtWQwfVONFFOgpSM8+nOynmdvhcxTqgQrteODhOMVBYa/xLMYzQ8aePxdjy0sknVCKFQ5+X+mdq0UK/YDiBEo2d9Jgf+i5KqUeVZQZNF08YKEeyc/gV1DoRBM7nmmUg+XskxfHRRDZZUIxqNnRHa4Th32n4IyoGdXFrRTf6SSzgI7gl8PZcbQYFlbgLVqbIZKa4lsafV/vuLp8sM99eI5CRXS9luUXTRvWuWJdDao975Q5sZ7T4iREw4HcLBiCXsIYFq7Pesh/GhsKc8FZkryHwYVGxMhK5GN7oBNEstyj0W1ZQnG823tVRcQzOxT2SLcE8d7tnetvUDX2DGrMELCtQycGiFa5S+ts5ziGPLkL9goTp31y81CK49TIgp1ty2EtbeWRLwrtOeMbsUq+LDSHTZs24J4v4ymAPLGCqE5THAy9mDWmotr; 4:zyBhGt2DUUNmpzPCdFpkhEID1E/pCqFS273CGdg8jU5zXqDhlaA4AeFsGpL9zm5t4jyJKBOH9AZkX7QFvZm3iQC/DMRlIlwF5ViRIpR4yYlFygRk2hhjHiWEm4cQHHhqoTuQyYY8Cfs0rqafNfi6U/+vlh1SLkh7CZ2STiiWjTwAo/RLSvkU8XmQwYVvkh35Ekq0t3raCL6TZ69klfeZ4TacB5YdctJwDIhhKjlaVY54spH5koYVjWUsOTWZi+PzEE8HFiJolpJpEGnFId8fPA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501119)(6055026)(6041268)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(346002)(39860400002)(396003)(376002)(199004)(189003)(316002)(25786009)(106356001)(4326008)(105586002)(386003)(21086003)(16586007)(55016002)(36756003)(48376002)(8936002)(68736007)(16526018)(478600001)(50466002)(59450400001)(50226002)(66066001)(47776003)(8676002)(81156014)(53936002)(86362001)(7696005)(5660300001)(305945005)(7736002)(81166006)(1076002)(6116002)(3846002)(69596002)(52116002)(2906002)(6666003)(51416003)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:3; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:1mMZo0DYlIGf0oQyeVpTSzTb4Sd1fnfD0y8v/nd?= =?us-ascii?Q?L9b5r9fTnDAEoQlXsmZJdJ2j8IT8QwkRaGPLWXScd0FkpcdL0ork8/ypGRs5?= =?us-ascii?Q?3CJjpev891H+OBBvo6l/gWmawrD4zEAbt0bpP0ot97MQFa1I/4Vh7Wp/VGA2?= =?us-ascii?Q?e2n3Po/DBYI9NxSwPX9jtd6sT+fdw8cwwAwMmaG4/H/2xAqQ+Oeqdcge68UR?= =?us-ascii?Q?fn9bDEia5PRyQZLsk1QXAWWEX707Up4Z24kd8TPmC0bcEW73AWe2HdBj2VZf?= =?us-ascii?Q?CI7eaqHmnN15iCMVKWe4HrgeYoL5hyuTy15oZEEqsQV2+YWFXbwzR7ryupTd?= =?us-ascii?Q?hgO9wjb+8FCi/YlDoG1490G1jZKSak/SPzlCvYi+fmaQvrGgV7DEeNKoFwxP?= =?us-ascii?Q?yvXow5FwCeiQ27IIJmjDFnCWoPwOLteyWzoeT1jW1tQsjkfMDamjcb+Cvfyr?= =?us-ascii?Q?u6J1ErfvF08ezWcik/G9XDFZAlu3IMiQGqmEpNL9Yjgksz5bnc9x1WiSKNV3?= =?us-ascii?Q?UmKnwktjoV7orvuyh6RD+peXtpJJG64NMcAcp43eIuo7/qcR3UdQaq+VxsAZ?= =?us-ascii?Q?tGCOZaWmJBDINU0WnyVnxzVJv2CZO6R/BKqBirKFT2w6BR3NtoXAOwU1x/6i?= =?us-ascii?Q?1eBvcmktcGBneNZ0/h3Is1nd0ugzvmWxeTdZtvLkltfy963f4fhMFlyhY1SF?= =?us-ascii?Q?0fIRQQFZ9Db875WOqRo+Y+4aC0Vd8PSzJLbBktCo8te/uzTBUBg1CdpQntY7?= =?us-ascii?Q?6EC16SS+iDyVBiQTD0VFqFTROiGo5M1iGT2VukOyvIFzDEndXIqN3uhIF4m4?= =?us-ascii?Q?8LY40bab/OhHILvtatTOE18LVEZBSVrod3L3QdWlmzBrUKaCBmNbU02LRjb1?= =?us-ascii?Q?EIsaGlqYpQ8N0XTF/03UDRJDybVqvwzx+9MLG1l5XuxN7lcMUdsKIbjpbKGT?= =?us-ascii?Q?VWkaXdAq0s1mQTyiFe9rtsLETQpJ+SjPVuhJRTEXwXYwyxVfRG2XWpf4hdtU?= =?us-ascii?Q?i41K9lPNka8M3m9YZpD0OToZgbzIunSQL2g42iu2RVhQ4AT0VsUBoGvS7yRh?= =?us-ascii?Q?HqBWnBsasfxW+v+cAJ+Ox2DSJtG3U?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:5Awi0Mex7L6zmF6ctR8Wjz+Fjnj/zyaPsZL4c8b+rMaFuuvD7ULK45EKk6eGtIEIpC3tmFo5ckBz5+E0NJn2Q16oxvulAxIqVqZjHKMNl77L650Jvmz1iay7I+jHp5Vp36G9xva4gvCeRZ5AtUvIrBmFKnn9O+kzO5kEBXGOQC4Gb670XI+rY68/gvF4WiTWRaY5sjjXkIEY9xNq0Cd+Q8tvMTmBeSuHNpODOaMylUzC9h+CtTin5fSQmTiclAHaU7C22p6L5pspXTMFoYFvNqQUu7M9iThNak/yCZ/MjWthoXC4qpKYlMAdJmXDXXkgX1ocV/MlrlHKU945oxV0BUDW2Wx9wP3/2wBXqK1p2mA=; 5:3/5SaZ9TNi8PvtoDyyPklYxxuHFlGXEMykmuJ0GRrIFmscy3/TQZVPKmjdLi+q9975jeClsL2aZpGYpdHP3ZYQPZaxwKt0H9I99UN7tiz2soC9yzF3C1BxoSZwfxQRfKQ8Poow2E0sAzfBk5LNPdSyBBM5GKJkiRvGMvKQa9a0Y=; 24:Tjdc6rWmK3Ji2MfWIt/PY5zzYnV5GGaZsKRSjZXSMl2Pqb9iOG6h5D/TlMIuH0f0Fful+xiqc/yKwjjXGQ/YdXNSiCMDNDiT4qEd7HiGJjo=; 7:TqylvUf06WKMVSi0xsj53s35XFYy0hxO/sVeDPavcKzUzjiFHgFlC4uwnD4L1wWFMTlzJr25aEIRqC7lpoVZOMkS/++5KpPKHNYM9xN5t5xhlYR/hAt0f22njbt5FO/4/TZTRnJMkacbAIpzpHP8NJJPTUKIgX5qyqDyUa9ZklVrlAOcqN0ZZzEWGdHrR6MA9W4iklYE28ug+L2okVJhTDjna010l+URQnwvAYsbzBRDz4hUQDH8hDGs5BwXANhU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 17:50:55.4557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3d6b8b-4d43-463d-fa7a-08d55852b3aa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing attribute size for drop action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:51:01 -0000 Adding the size of ibv_flow_spec_action_drop is missing. This can cause overflow when converting rte_flow to ibv_flow and thus corrupt memory. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 305b2ec01..ff9fd78d5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -868,6 +868,10 @@ priv_flow_convert_items_validate(struct priv *priv, parser->queue[n].offset += cur_item->dst_sz; } } + if (parser->drop) { + parser->queue[HASH_RXQ_ETH].offset += + sizeof(struct ibv_flow_spec_action_drop); + } if (parser->mark) { for (i = 0; i != hash_rxq_init_n; ++i) parser->queue[i].offset += -- 2.11.0