From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 583963772 for ; Thu, 11 Jan 2018 09:21:08 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id r78so3707296wme.0 for ; Thu, 11 Jan 2018 00:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=29OSIVzmDA5bt879Zk6n95CpIX9Smxfo7cFGhuENJlA=; b=x/Aj5RkUBhUb3LCiqlF2QhHLF9DRC9zMnT64UZ3HDspMHVM0nXHX4LmoGg1B2CP321 Q/IphmhIl1wzRYx9h8QkV2PZs83cVGyUMKCOnk06ANbuOtfKShNgcqiMh+dfa0uI9MW8 asF7Zgt9YXwd0XfGszxDeZ0H3e0H583+6g5zQSbfnLSYCuxCdAxNmAy5R3x+L9qrEMGX 11loPVvz7lwfM+F7J4LnfzPNbAX2aBYUoqFG2bWVv6Lc4un4D2O4bAYTMmLHsWyKzWsP h+NunvPr0tbPhZjLg2tH9R02om9dNa2+uHVDPm/As86jeYb3vN1fafWO1x63G1kPyYOX EEuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=29OSIVzmDA5bt879Zk6n95CpIX9Smxfo7cFGhuENJlA=; b=f5XS6aCTStQ496cRcePnSeWVWoptQBR92Tv/rMfFqR4jJzKr1XvSTGCWK7mKVuBDTk AEV048JFMhg8/wXIWfUnozX1Nr0IiA8O649boqJQIMTH1fg+hA8xvsh21zOOz2xwiT8H auJa6AhNEmkhwaxKjPu37ZgplrEuu9Fci+6tpK+W/tLjOcRSwXWHiJycwKOPryOz6Zai Lklr5gfZIbQgOMdUZY8R5gLD3Fsnq68FWj+cSpWord2FRdijkFo6hFTY2Q/hsSQAxGNB T4N4m6F0cMbAsxU39sd8FE5CsLI2MytzWdutenpGYduZNh3CWZukOCaQd1dCXffw91zQ /Yuw== X-Gm-Message-State: AKGB3mLRffCMBpDnHj6I9U4mm+vOCL7rVITBTWYptwn4H7kG87wzALQi mXrUD7QkbOxt1/cB1mASSKp2 X-Google-Smtp-Source: ACJfBoskIVqpmhRRv1DwMyIMFxSf+ATS0qShDUk/cCNz9uknKDx/u6ffsINtJi9PVPw/pI/fmxADaw== X-Received: by 10.80.149.243 with SMTP id x48mr29671977eda.13.1515658868073; Thu, 11 Jan 2018 00:21:08 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l50sm11484539eda.85.2018.01.11.00.21.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jan 2018 00:21:07 -0800 (PST) Date: Thu, 11 Jan 2018 09:20:38 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180111082038.fh7m4dkrqdy4rp64@laranjeiro-vm.dev.6wind.com> References: <20180111075153.33537-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180111075153.33537-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix parsing all-multicast from flow item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 08:21:08 -0000 On Wed, Jan 10, 2018 at 11:51:53PM -0800, Yongseok Koh wrote: > As the dst_mac of allmulti is already masked with the mask, it has 0x01 in > the first octet. Checking the least significant bit only can't distinguish > it from broadcast or IPv6 multicast. > > Fixes: bb47fb6e6067 ("net/mlx5: fix flow type for allmulti rules") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 305b2ec01..d01c8069b 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1281,7 +1281,7 @@ mlx5_flow_create_eth(const struct rte_flow_item *item, > eth.val.ether_type &= eth.mask.ether_type; > } > mlx5_flow_create_copy(parser, ð, eth_size); > - parser->allmulti = eth.val.dst_mac[0] & 1; > + parser->allmulti = eth.val.dst_mac[0] == 0x01; > return 0; > } > > -- > 2.11.0 > Seems you are introducing a bug, for broadcast Mac addresses, this will not work i.e. 0xff != 0x01 but it as the multicast bit set. From my understanding, Verbs flow attribute must also be modified in such situation. Are you sure about this change? Thanks, -- Nélio Laranjeiro 6WIND