From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Pavan.Bhagavatula@cavium.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0045.outbound.protection.outlook.com [104.47.36.45])
by dpdk.org (Postfix) with ESMTP id F2753728B
for <dev@dpdk.org>; Thu, 11 Jan 2018 12:34:49 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=2Jes0clawobLn+znAzR618lnkPqhQVZrX+Nlf6ELahQ=;
b=c+JautbNKRkm4EV8F1OtBwhF2wsRRdetcFqIkoT1r7DtrKrOeFkJumWu3x9TO8WKHAYYyxJ2/Z1w+9RB2WbkuBKu6KqhZJKQLzAdXqHo/jmqrMELXqrciKZ/nmLRDAslM0Cbr3k3+jhF17/SSwFupL2StjKI/xSVtcdbnZthn/o=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Pavan.Bhagavatula@cavium.com;
Received: from Pavan-LT (111.93.218.67) by
CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.407.7; Thu, 11 Jan 2018 11:34:46 +0000
Date: Thu, 11 Jan 2018 17:04:39 +0530
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com
Cc: dev@dpdk.org
Message-ID: <20180111113438.hzyq2kizdyue3hre@Pavan-LT>
References: <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com>
<1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com>
<1515630074-29020-11-git-send-email-erik.g.carrillo@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1515630074-29020-11-git-send-email-erik.g.carrillo@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: MWHPR0201CA0018.namprd02.prod.outlook.com (10.167.160.159)
To CY4PR07MB3462.namprd07.prod.outlook.com (10.171.252.143)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1ebfb7e-37bd-47a7-7d7d-08d558e7523a
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020065)(4652020)(5600026)(4604075)(4534095)(4602075)(4627191)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);
SRVR:CY4PR07MB3462;
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
3:PDHTHAU+sv60UqLDv9ZOzu7TTWO6tyLiXNH3NtouyR+/0ufCSwE63oCXwqYE2mEU55sk1ISpQEEvM2WgmTcvVrBL+wHpH/AYrS0fVZS83VsNoiZ/tQqlNItU7rKIgOmU/kCFp24ktSvK+rX0iHRs/JJ+rAsVVo2An8EHcaD4tRHwBC3ulQk2VcWUvnWbFnT3TaGZvrz4IdpsYZe2BKjkwdu0K7DtDdPAL3Oub4xIbznJztJFwcSWG/dNCLlT/RLP;
25:owTNX+aCxjs66wR2tXrrvLafdgbWRk3+FDZwWB67C4UPBs7GhkwQaEVdHBkIlVs3CuxFdo3Oe3xtKpXNPqMulbTplYEn9ZUlBDOcP8zQlxTXpkulQyoWbsqvAifvGQkKP6ceSbGwDd86b/VVV9y54R4rqEpdH4ABehvCxt7SRWy7A7zthYdwD0o9j4xlIVUusSLdeoD+JnbsyV75y5zkylPY4Pp73jK/Fu3RGrcnU+Au3sVreLqFCmRaoJx/r+5/rMvTK1zd7p/B+ea/6Zt4Q062XysARxIadVdhQw5Ju3S92XeY+em8YCsb4qVWiQeO2Vy2kN91ryagh2udrJHHqQ==;
31:s1CJQsy7FXIrGV1JByY+VcnxhRHxDFo6hZQqJXApCMDs3PDSihQkfXtFFbeFfot4TKU40nU9xBzspOp5rdcGgXwe+pNXZVPB8Dwaz6o/wRdtsQpcZD2nF8UDlQroBzzeYPYzA8/GsgSW2eYT2JBgnbgpvubmfGKTYO2yfNOrD8MKyb5rEcjSMTAETsfAZwCjZuOdYNr7Q0SJTyIJoQAvtgChkuSrC9dlOKzER1JOxyY=
X-MS-TrafficTypeDiagnostic: CY4PR07MB3462:
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
20:+TohTS7AnWu2yL/dT+PZdKT24y+PpB/OcXyCCyUkKK4xG2JnoLrUGIHmY3mh0CYXmXEsFTeDKG+z/ENNJv2wrVqa7/kOFOhlHc50W0AtG92Z/nSCMCmGacHvXMIyYgrj2iiF3Nlis/YkKhzepzrptv8lyxAar8rmFgeWDLyOQ6/LCKoTXY9FliO0GDw/Ugf49wjBcs5GBl5ZuwSwMFZnAAhidT2oOwfGhHxq5TEk/EG6RkhdhTqRTObl8b1IKkGO9MBaa1Ocxtn/GUNAsgnocMIAc57zGByRa/UglDTQq1WYEAwf8RopsHRcU4DV6MQW+OaDFnNN7hboBRSx8MUH03Eg+yGQRWlKBROalJV1GN8OHath7XvO9hcakiKgG4hq6Q3jqI2ZkYfZgEmcG4O3POavfw/P/+6gSGig4Jw1m3fqjQnoK3cnjK8Xx7LReBcRnD/2gq4m2iabeQbMWjZKzYtxhq2Qzzk8Tzt5VhA86Y4Bo4xG6SErX/MF17xMgze9GcuaY7ms6zfwe/+3BilXubQRAGLBUo3caVpf8CqgEggJw7vSyh1VTmAIX2LEdLLpRsk1RGbdy5MAzTUibWZ4Z10xo1VS4rPvnm0LXrR+5Xo=;
4:5QPLfEvo4B7PQ2PmWk7KUpegcO2guX26TwMC13tMPr3O6nB0UXDDS5apsybyzL5rDKMo+LXwB9+8cKpJq3O2MfLxRIDY7QXOLpFQrCjK+jpbedvXLHXWi/9zlFk8eS+ogCVxb2d4JjhuVoCVRRNxAvdKOp2w9nZucHuNOSD3/vPQeZ59m4zZcEgQjTlXFTaN68qfzOdd2QhPQ/jP7ZpBWILn4H39sQ6/arvEqq3uaRaJ+t3cSRI3Avi9TWicYQIJ5hhgoZKYDtd4t8JxApzpbz7gHLy+lz5XaVt6aHpfCj7EW4N33kv/mxoZR3x+xXDZ
X-Microsoft-Antispam-PRVS: <CY4PR07MB34625D221DAB988DFCADDDDC80160@CY4PR07MB3462.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231023)(944501134)(6041268)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011);
SRVR:CY4PR07MB3462; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);
SRVR:CY4PR07MB3462;
X-Forefront-PRVS: 0549E6FD50
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(346002)(376002)(39380400002)(396003)(39860400002)(366004)(189003)(199004)(24454002)(42882006)(81156014)(52116002)(8676002)(72206003)(2950100002)(386003)(1076002)(6496006)(97736004)(33896004)(6246003)(478600001)(53936002)(4326008)(7736002)(76176011)(58126008)(81166006)(105586002)(305945005)(25786009)(55016002)(6666003)(9686003)(106356001)(33716001)(8656006)(47776003)(68736007)(3846002)(50466002)(83506002)(316002)(16526018)(8936002)(229853002)(6116002)(23726003)(5009440100003)(5660300001)(66066001)(16586007)(2906002)(107986001)(42262002);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3462; H:Pavan-LT; FPR:; SPF:None;
PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3462;
23:qsJTdsXMrJN/pQwI+vs3r1o/T4h3XF7QLLthGug+3?=
=?us-ascii?Q?EUJUbcDUPJJV1vhmQ3MsHUiQ0NJEO27z4g4UQGCC2K0GefpMqmw3H9WtvoVW?=
=?us-ascii?Q?IQw6n5bt5txp2BfX/7hidBCjlXr1Zxh0sPYS4onX9DL01eJ1e/XGNS92HGYE?=
=?us-ascii?Q?DUL3aEDNwFS59J1tRHArsjY8qRAmc9DTsr+pxFK4p0QU5hzCAHtGFcUqY01S?=
=?us-ascii?Q?whOjXAJ63vwSZVw02yieHuC/C/bcq+T6usGW8OphruXwwP8kh517dthSa+iz?=
=?us-ascii?Q?i69T8rnJZ/VbmSvF/BPKwQG5hbDX4Shn2omvfc82TQ76L4ZC+Sc9aGI6XP2g?=
=?us-ascii?Q?jXzEsfwF5t3dQhaH9/5SqsiDFeR+N1DnkGLhs2enhEGlmU3mxYq/EPulOS5w?=
=?us-ascii?Q?mLEpNp+Dhz6LzySB13J8ltOkOa+1ce5QJlAWjTLXpwsL8d40Dl0on0zBBMvk?=
=?us-ascii?Q?yg/WiMM2aySvcgaz8oyNNQdiNyRiOEV0j/9Ap7nDoi9cWYqc9Ndejag940hN?=
=?us-ascii?Q?YwPSfwoFmS8oDMu2/nJs+uFjU0DhPs4xYibiLkQW0P/P51dbuzcrvZHtEVCF?=
=?us-ascii?Q?XmCzw5jEsqkz0tuNrAdy4sSWErpTa2fvpRQp1KQ+lc31rffe5XVK2c81mdvt?=
=?us-ascii?Q?73wG1LYjnNey6xkUjzjLFOxi6z35LCI0HZx3nfqtAl8D2fYczqvW4c7ql0cz?=
=?us-ascii?Q?wXCh8eqCfH7GuVssAGGyV9AFrFwgXYgoN6D7fO4TZ2DqSinztam8jnSGR45v?=
=?us-ascii?Q?B7LY+4LVFWvo+aS1raobHFKU756Q6F2vIOasnCXy5VdS4FQR96dY9ulQ7Dlc?=
=?us-ascii?Q?E+cxDtONL2YWXZ8POt3OBISYULvc4B1TTJtpI9FxCD3/TtKVOsEAWygQK0l3?=
=?us-ascii?Q?S6a0318FS+FoexitI2uKsUf0dSxqNArXpw4ooZ0WEArklvK8rhFqUZf64i3J?=
=?us-ascii?Q?XavuSLUgpmB4jWRw2tO4CeYiC0H1C9rLCLVFEWl2oyS5p/+MZN61IFWNw7+g?=
=?us-ascii?Q?O+TVJqv4Wss+PJdR8vhkMtASz9ttUjaj2OEJ08BhXc4/i59IRtbQIfkaHKvO?=
=?us-ascii?Q?mFPn8Zp62LeViCRhTlDff21G/IdI4jgMUpJAgnfG1ZLqdIU8fOaAa5Px++LH?=
=?us-ascii?Q?aphi1DJSz1XkYzUi9p9BeViFjaMpqCqQTX9R9REjqP+4rO+eQ6SNFP3oNo6X?=
=?us-ascii?Q?JQD0RVkW8x7a8r5xZpOiOfLuYJ14mjCupsZWkenG/NiFdj0bKiw4UsQpiK6U?=
=?us-ascii?Q?AwvZyEfM2Xtnfarmh36gt+b/22ZTDJ2dSErBj02?=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
6:3tZRxVjREguo1Doj53dWErrxpAvV0hxBfF8FBFxh4zt8CJi2rwMXEnN8p8Xg/RIG50bSlLHf7VC1C2iqOqemR9kDlUYBO9LXcra2g9VhRhgYXQ0wxhiNn/rUDY43wAO4+/0EYsGNLGuYHHOozviqkp5wBb0cPvWQ0AGPCj0JI5LSljJ2RAbl4BteMYOLiHrZGYHQqW/MkT8fOIe6o9FDTzQ7HGsWNPt07x8+1V6R+/WSRnE6B0QBtXSKG6Mn0bEh5HM/8RaWzZLi5Ka5kKnd9oMsOMleyAoq+P3n8/F4IIzp5XHK+Y+ZLtQDMy8ImKKleVOoBLyUfcWJR5M2Puei0fmm90sZXQkCQ6B0ZNGTAa4=;
5:GqDfkEtYDGdw5qoIuoNjGUZT3bOoklM6w20IsuHorXgWkyaNRSUd+lAoGh3zgIlyJhIrVLzQLFi23XbB56ttlETpzzbeYBHtr4X7fmc46H5oEPOiXDAqU+HgPgUlzMi2KK03vaeP5APrpOvI17Dwoy2XEHckUS/Oxslx4m8bpV0=;
24:ffujsvzPx2QzW8EeNkEpsZ039ZzVohcKGytd0ddDCPm191ZxbmroUV4kQArSevYSeD2e87Ml7zE1p+G9X4gVY1MTeyubrzfog+lvw/YGiLo=;
7:+bS6i0xJ98rakThD2GsS3ZE1u4G87BAx2M8qjD2HmMn0EUH0gle3khVxh5kYbSqCy22gpyyRP45YbSbp9HUqALdthmWy2xSKZIDnZ3qrnA3Z+0TNe9FtiZ3MUW+GfqX0hvYszPsyGov4QNFedyzXHPMq5Oo7Irqj/MN5Eh9+lEC+SZoVI4Z9X1WN5pi7RVIVcboCwjKUGZ1kJEf/fqUM52mCeRSsgNz7ISTOHHO8oa2m+3wSlNFIn9d214R0p/DL
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2018 11:34:46.2735 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c1ebfb7e-37bd-47a7-7d7d-08d558e7523a
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3462
Subject: Re: [dpdk-dev] [PATCH v6 10/23] eventtimer: remove service id entry
from info structure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 11:34:50 -0000
On Wed, Jan 10, 2018 at 06:21:01PM -0600, Erik Gabriel Carrillo wrote:
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> lib/librte_eventdev/rte_event_timer_adapter.c | 11 +----------
> lib/librte_eventdev/rte_event_timer_adapter.h | 2 --
> 2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
> index 68748be..a4c8012 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.c
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.c
> @@ -609,15 +609,6 @@ sw_event_timer_adapter_stop(const struct rte_event_timer_adapter *adapter)
> return rte_service_component_runstate_set(sw_data->service_id, 0);
> }
>
> -static void
> -sw_event_timer_adapter_get_info(const struct rte_event_timer_adapter *adapter,
> - struct rte_event_timer_adapter_info *adapter_info)
> -{
> - struct rte_event_timer_adapter_sw_data *sw_data;
> - sw_data = adapter->data->adapter_priv;
> - adapter_info->service_id = sw_data->service_id;
> -}
> -
Removing get_info is not a good idea, the application using event timer might
need some info about capabilities.
Thinking form sw_event_timer perspective I think we need to have a caps to check
if it supports DISTRIBUTED scheduling similar to sw event dev (or) expose
RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT.
> static int
> sw_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter,
> struct rte_event_timer **evtims,
> @@ -661,7 +652,7 @@ const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops = {
> .uninit = sw_event_timer_adapter_uninit,
> .start = sw_event_timer_adapter_start,
> .stop = sw_event_timer_adapter_stop,
> - .get_info = sw_event_timer_adapter_get_info,
> + .get_info = NULL,
> .arm_burst = sw_event_timer_arm_burst,
> .arm_tmo_tick_burst = sw_event_timer_arm_tmo_tick_burst,
> .cancel_burst = sw_event_timer_cancel_burst,
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h
> index 84d3c39..8d29cfc 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.h
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.h
> @@ -283,8 +283,6 @@ struct rte_event_timer_adapter_info {
> /**< Event timer adapter capabilities */
> int16_t event_dev_port_id;
> /**< Event device port ID, if applicable */
> - int32_t service_id;
> - /**< Service ID, if applicable */
> };
>
> /**
> --
> 2.6.4
>