From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0088.outbound.protection.outlook.com [104.47.37.88]) by dpdk.org (Postfix) with ESMTP id B468D7292 for ; Thu, 11 Jan 2018 14:16:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hcm3P/DlsKKQbAgSaDNYG8TGhuZ9TiQsbvsJRO1qDCQ=; b=CqWkD/uFmOLoBG8IGOTOu3DWquVhqUzpednmUfafzGcvHvPL22oc5djAbTTW0u+YrlrM0F3FRdmxH6xtqWHuLEYpW5Eeuk57Se2C83rQ4Wr6AXb0nzSW7k047QoY0YGGy6g/4raldePYc0h3Wis0Ir29i3LEdH3bJKPOeNzL+vI= Received: from Pavan-LT (111.93.218.67) by CY4PR07MB3463.namprd07.prod.outlook.com (10.171.252.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Thu, 11 Jan 2018 13:15:31 +0000 Date: Thu, 11 Jan 2018 18:45:24 +0530 From: Pavan Nikhilesh To: Bruce Richardson , harry.van.haaren@intel.com, jerin.jacobkollanukkaran@cavium.com Cc: dev@dpdk.org Message-ID: <20180111131523.qmwaqjgt2j72chuz@Pavan-LT> References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> <20171231000203.4510-3-pbhagavatula@caviumnetworks.com> <20180109173400.GB6508@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109173400.GB6508@bricha3-MOBL3.ger.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BN6PR16CA0015.namprd16.prod.outlook.com (10.172.212.153) To CY4PR07MB3463.namprd07.prod.outlook.com (10.171.252.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ead2b38-9d19-4e9e-46d2-08d558f5656c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020066)(4652020)(4534096)(4602075)(4627192)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CY4PR07MB3463; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 3:+thRKH6ZSunQUQH/Dcmo/IApCsdt94PUd15bSAZGZa3TRH7de54unGINl/5FLvMNiC5tzQJdjQ73n6mWjdhD9aatDg37vLum12Ora1u/DQAPI66kx90g6Yz4Y9H4H4NWYdet0UUVQI+NVpXb1AfWZTmjpdjExDiAuvmASYiXdIJZVGuMORMVb8kDNG4LTxXBnc02DA+QDokrgabF1XZfs2WDO3eRwJQ3nGG3twx6u07DYFbtiCiUe5GYiK9yZeHu; 25:hip4aIeay4QGpQ7U7c5PGU3IgV2uTD4IVS60BQ8trAw41l6UoLRuzatc0dFhbCvv1TlWKb8VgCvFrpDolEkf3mJabnWmnes/iUicPNDlinkn5a+O+jHuB2fUBtCHHgFd/zDcsf0PQlVXXQzmmThW/oWknDgs9GAao+1m+48K5kdh/hB72RNA7X7pb67sx3HHioQ4INOz0PAKUq935QMPMAgzCO8Bkhrd+w2X/ai1MMEIA6HTndC+bjevtzDrHIodycWijbZYtT5hHSkyJ9KhnsR0TM48h+5FEc8HfkJlBHri+OW2eSGGvXhOuqslVFWPKjwsyu/Fc1TGj9zdiq1UKg==; 31:6NYoOxbOcO6XuBTF0hiYpUKbVnoMSw3M4Txvcvfci22DrNwHFBYjQH44Vgcs+Bj/YYKyO5JJbYO59e0H9RKwFVcSskGhp8KRUMo9QHU33HsHzHY7laDAvsuo6riPmoSksTExRSIGZPY0rwMqttjM/tEQJIIfMYYiF+KuwiamFvLGjVZRsRIudhx6rBh2csMJWN7AgSbIHcqc5ZHaNJWcE1rPppDTFozjdkY7sP6rjL4= X-MS-TrafficTypeDiagnostic: CY4PR07MB3463: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 20:IZfpp9ElJdrYudd8Zp7LUubCsLpKFthaZ0rd8CAvSaAAO82jkcZnknk3965Miz5/O5JbsBPAcH5PFPXVXkcrgJAjfOhtJGSKtluVS6xr1XeTl+5B1Nb0m4FHPzH3/LdaF4QjKmKlBPVL0KV0xJ+NCKbG7Pqdt+SidgvpZO5Ma3BlCHmtLLLwDfmJsLWG6aWloc7oH9aEBmiQSbCu7nSj2O+r5dibdDE+aXCrz5m5Kv+RcAY0WJ9++WjrEv9JD8JF6NKDRHs4EZhl8RRo6ulmovQP9hxPQ8LzEvVV4l8pAvwosS72oiHH2TieAyhIUDk25W3TAXIC9Cr6hm3sl2KkgFcqKrc/hyEm5wLJFO2IrZ5ME8zI9ohnI9b2A1PujBE4FnH6O2llFBLP10uGAIXvJkh14WQfLC7DYqTdM0ucczSp9GC2To7QMAcjYt4TNpvwBrMSOwRffP7DB9Rm5NU/bv7LCyjyIRhkD52Dar3pWebw5V6sNZkeNymZcBZ2hbL9LTzBh8wjdpUkTxZ/NGsqXDsRzY776HG+wO7ElgERTyTf7PgsSe1gYydpSYS95oV9xlGahYB1EDXYW8LOTr+g6lef9ppZHpll6BtOf1QOhcA=; 4:qpAZRotdqSZZDApdc0hJcCUWyDktu/9WCu6hpEj5bgb7qyH5F7wEybS6omgXl00xvA0UpC7y+biHdhvNztiJlT/IMeNNPB4c4ZMEfhVuLW94AQGt6tnxbl5vpx9+ADRkilJx5z/KZL8e4T7N2Xyz6iNj/SNaSCnNMXpG6U4CtDm/6gXM+hblJ1hykn1lnL0MdGtbuq+o7J760dTRYnU7Bm64lzxCP9k5CXHqP+oagNvX4cF4AbjPKMSG5AoqIA1N2mzjtf0o6j3O07PFx7ycZA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231023)(944501134)(93006095)(6041268)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR07MB3463; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB3463; X-Forefront-PRVS: 0549E6FD50 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(396003)(39860400002)(376002)(346002)(24454002)(199004)(189003)(1076002)(76176011)(106356001)(53936002)(59450400001)(6116002)(25786009)(23726003)(6666003)(229853002)(68736007)(8936002)(6496006)(83506002)(3846002)(478600001)(2906002)(7736002)(2950100002)(33896004)(52116002)(55016002)(9686003)(42882006)(305945005)(5660300001)(8676002)(16526018)(386003)(97736004)(6246003)(316002)(66066001)(105586002)(5009440100003)(50466002)(72206003)(81166006)(16586007)(58126008)(33716001)(47776003)(81156014)(4326008)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3463; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3463; 23:5GOuMm0yKx0RlTmXu6pg32OBERYrz1fWLd+aP8X8d?= =?us-ascii?Q?cgX30G+a9kgQq069gq08oq+txNgcAiorOQnlL4oo4mbo7wbx3Yl3U/K3uuHF?= =?us-ascii?Q?kOCRRP9mQcMU25LmDNxS2edW4ysL3LfC8Ata5uQMIMrqrp4wFoqWV/0y2TeN?= =?us-ascii?Q?VTQ2U64BxDjUfUCazRVPGTFqvYFHY88cKLz5XjUCdBxZxOnkIw+WxvqP6aDI?= =?us-ascii?Q?JtuL4AIyDPTL7UZDhtmJHr2SDjst8Ma2oKVbG+9uYm5MLWdVX+Fy94EnMXCM?= =?us-ascii?Q?z/WD06QQuakDwGFz+z0qWfFZXKZSBIvvB6fvJzfXVUmpPPtUO5yIkytQZDN1?= =?us-ascii?Q?vT2gY+/cGek8+GE6VZcUhx2/Gihj5qNiYV4HkoJvpNVkUC37fMiLffA127du?= =?us-ascii?Q?02BdbvJw6ATA+45lXN9F4ar6CXYWicWFg8wle2sHV7OAwXYjwdacMi08WuhE?= =?us-ascii?Q?1/eHWzogKMcb7nAFq0rLeVkZVdtc0432+2g2J4g0/PPF3pt680ym/q5AaCsy?= =?us-ascii?Q?wznwl7E/QkuNP35gvevvb4a2h/0WwM9tp4sgiQCDCslCoQT/Vhs80tSLYIOR?= =?us-ascii?Q?Dx2ZTp565y2KrDts7MUDqjBUJ5ogOR3eSD3Itwn3yWgfd/sk+J+QdMh21aD0?= =?us-ascii?Q?aYFAhXgIt6aFwo+/uvGv5wLMpYY2rQYcj8rq9IPol8Jds4euFVJfqTdpxJ5A?= =?us-ascii?Q?AUbP1HOF73aXz3dsGcYDxJVvDZ6fxI+fXilJJo3cUuHQmAHVJ7wXrwFZk6bJ?= =?us-ascii?Q?E9Qi/QDDL8F0vBUWx/FgB4NDZoiwIaZM6Hb8X8WRjdKgm58fbKv+4lYokVuW?= =?us-ascii?Q?KWGsmV86ZuzAK9Yz5rXPe1ftQ9gKsK6p890ChQu+MkHLocxjGJI1AekyoVsf?= =?us-ascii?Q?SwmJOzdJ+SLrSwZ9wgYIQI4ugNt4nPTUn9O03EWqucaxYPJpCdZf8uZIO7W/?= =?us-ascii?Q?qs5dvfqhhTxMrwt4P3CakdGNZIvGEVcojoWmLZVrC4o2wOziD1hHuBSrdxJS?= =?us-ascii?Q?B9HQXfy7GFWheYr7Jd2yvMugO6ATNBKnG1FXUVpa1o8pyfjUon0hMyJA+9tF?= =?us-ascii?Q?lCTktCIAX1CDVhsNCjpmIsVQOXpyq7iN+OA8dR4xwqCn0mj0VlKz3Q39zFUP?= =?us-ascii?Q?M1hCo215A6oOlMf6SL/eiwlWSPu+0tA1B0cE2M2nTnjjrYbEZ1PqOEZFR739?= =?us-ascii?Q?hEeWOiz1TG6jS8c4nwp39Ql2lsB3HZ0MlBIp5ScKpAqW5XNvbjf+xQeOwrZO?= =?us-ascii?Q?4cSD5u/gK6WA/mR3hVppP9uBt3QxZmOKseOMUYy?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 6:P6VcG+Roprek+1yEM0uz2NlMiF83mBO7r+QFladCbgaLAENC+ZUfQrZ4AAX/dP4H4caES4E0s1UrSTZTWbTVTi+SuHA+BhXbBUuGINmp3NwPkIrH2RQaS6wn/yS+uKDpEAMUtM94f3tCz87mAk2jKlCFry8cdaE2EumWO3DdXvN5fLNZfPfoXexNl2Es/tykWygw5qWHg9W5aerrNJ8TCjS2MfMvwMuVZTw6GZy7dLBqDBjg/am0zWz39KClOi3EVXQ3AvkBnBR52XkEK7fzquQMGlrCLVf7GDSUhV8YQOO9ILKm3pMW/A205jbmLNx6qq6LvI4ocODIrScKOvxYISGGbjr3GxfmyYUbHgIJJoc=; 5:BVeYygd337cOvZ4dGToQf47Ddssd4MeTu5QXyufS4OfdeSr8jkTxLNOar7jeBR4CORUxXnsKBFOsGjGolvT68mMM0cnSw/3zzwPYd/tGv4X8Ac8n/tpQaOg3Zzug/GGbJZRCnrJTfQRnzvz3vWYlVrfOIUMRxL7yY7KPBXa6uOQ=; 24:lq7o4pg9ybz7QkFkxI/F9os91Zz4SiTwgkN3zk1L+FJEF6XgYEbB/JtKzUWSReMMUEuEtj8J274kmpSBQRAK1xXd4hMDaT00KM8uu8ixgzE=; 7:AXFUnhH0lY7yFaCizx1Y2bnJu82TmxRcQ8YqBZKNrfVF0HNmk+HfIQHS+vFX1da0Pg4Iwd/iJSQ5XRu3FRIIE+6pY6Tl0XCdnVG8/OFopXvk/GeIChgGvX79A3uEkzN8VrBl6GdkKzEMMq8nhKpIhu1QPQ/xsR0tHLu2siokuAID6BgR9VPEAcHNieF9INmEqhYxDBZY3l2PATtWwoX4sVGXOVYVarwskoDeKRNuf5kw/YtZ/SoiTcQy4UuyQHhv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2018 13:15:31.3838 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ead2b38-9d19-4e9e-46d2-08d558f5656c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3463 Subject: Re: [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 13:16:19 -0000 On Tue, Jan 09, 2018 at 05:34:00PM +0000, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:02AM +0530, Pavan Nikhilesh wrote: > > Add Cavium octeontx to meson build and change order of drivers built > > from event->mempool->net to mempool->net->event to resolve dependency. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/event/meson.build | 2 +- > > drivers/event/octeontx/meson.build | 5 +++++ > > ...octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} | 0 > > drivers/meson.build | 2 +- > > 4 files changed, 7 insertions(+), 2 deletions(-) > > create mode 100644 drivers/event/octeontx/meson.build > > rename drivers/event/octeontx/{rte_pmd_octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} (100%) > > > > diff --git a/drivers/event/meson.build b/drivers/event/meson.build > > index 437d80bfd..d7bc48545 100644 > > --- a/drivers/event/meson.build > > +++ b/drivers/event/meson.build > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -drivers = ['skeleton', 'sw'] > > +drivers = ['skeleton', 'sw', 'octeontx'] > > std_deps = ['eventdev', 'kvargs'] > > config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD' > > driver_name_fmt = 'rte_pmd_@0@_event' > > diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build > > new file mode 100644 > > index 000000000..fa46a67b5 > > --- /dev/null > > +++ b/drivers/event/octeontx/meson.build > > @@ -0,0 +1,5 @@ > > +sources = files('ssovf_evdev.c', > > + 'ssovf_worker.c' > > +) > > + > > +deps += ['mempool_octeontx', 'bus_vdev', 'pmd_octeontx'] > > diff --git a/drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map b/drivers/event/octeontx/rte_pmd_octeontx_event_version.map > > similarity index 100% > > rename from drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map > > rename to drivers/event/octeontx/rte_pmd_octeontx_event_version.map > > diff --git a/drivers/meson.build b/drivers/meson.build > > index f5009aa2e..52d7176a3 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -driver_classes = ['bus', 'crypto', 'event', 'mempool', 'net'] > > +driver_classes = ['bus', 'crypto', 'mempool', 'net', 'event'] > > This change is ok with me, but I think you need to add an explicit > comment in the file - not just in the comment message - as to why the > order is not alphabetical. > > In fact, it might be good to split out each type on it's own line with a > comment, since bus should almost certainly go first, then probably > mempool - since we might have crypto drivers in future that depend on > it, and then finally the other types. Agreed, will follow the order dictated in make filesystem. > > > > > foreach class:driver_classes > > drivers = [] > > -- > > 2.15.1 > >