From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 86DEC25B3 for ; Mon, 15 Jan 2018 07:53:09 +0100 (CET) Received: by mail-lf0-f45.google.com with SMTP id w23so12009076lfd.11 for ; Sun, 14 Jan 2018 22:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Wg2JCWornHjmhQ2//Zs0CyC10ZhtyAjY7dyfWYQL9Lo=; b=rooaNo7zIIn+lRgav/hiNyyhqz7ZLgOqNYEvIVHRVfmtNX4CCpzUNPcpGqbQyonM6h LbBh4d8L8UqSvNVxx9tuTVLBEdXKLzW4eNHaK0H2g81XEeH7xbJ//uAwN/oTVQozbQXd p60MCbotyrdwZApQ8+RUsogThjn2t+280VvgvSDQkJd2UacwWz1jBel66fKYsdQ7OS+D 4OZsWAEbFuftlsXjuEJ79b73WaPu15c2NFX8ERcDi59FVQRvh81KrUNqDgpXiPBWASNb HrCW4CThF6b+JSg5EtD4xq7C32WHbzYAsk522QRYKshSfs9yU23qqrCvlCOy1SWWkP4O f1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Wg2JCWornHjmhQ2//Zs0CyC10ZhtyAjY7dyfWYQL9Lo=; b=jhfEZPzceku+4CE5VuvVRivo4EpGwmUoNT1WC/TnQyunbl7vxqDTbeaS0kgREg1XtW 43k0nBOae+oIlBNeUTC7ldmaVwWH9IZw2P874jdSegOJIme4aHdb+X9nXRRjGEa4ktL9 wpuU5Ts3CyuORovyb0rBF0Q+pR0Hlgy/G4ztculTDuqO/sYseaEii2PP8fT/9cU8g5QH ktIRZWDq70xo66vEb21F1+n0FJ6V64iuV+p9dzzntTV5Ox10g4fuzTja0Rj7A0E94WBq 1vgEPSvoqqaagi0pnEPNkoksRbHPUNEw52GdhZ8SQ5csrY2rMTaOU7hSjTqgS8u1qRY2 3iyA== X-Gm-Message-State: AKwxyteTQM7pvOgnJB3tAskLEKag2T6TkqDFNpIZ6m3HEYx0+3Mprc/9 bEPBQmuBLMoEjbyRg5J2Qc9dWg== X-Google-Smtp-Source: ACJfBos36itFnvY2677ZhlysXwyBp/mIlSZp4tjZMKXsIrgpA1w4U6TLvqQ2y00+Kzpc3KBxsLzifA== X-Received: by 10.46.86.24 with SMTP id k24mr336532ljb.1.1515999189045; Sun, 14 Jan 2018 22:53:09 -0800 (PST) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id 17sm5297922ljp.13.2018.01.14.22.53.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 22:53:08 -0800 (PST) Date: Mon, 15 Jan 2018 07:53:06 +0100 From: Tomasz Duszynski To: Ferruh Yigit Cc: Tomasz Duszynski , dev@dpdk.org, jck@semihalf.com, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@arm.com Message-ID: <20180115065306.GA17023@sh.semihalf.local> References: <1515684943-32506-1-git-send-email-tdu@semihalf.com> <1515684943-32506-3-git-send-email-tdu@semihalf.com> <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 06:53:09 -0000 On Fri, Jan 12, 2018 at 07:13:22PM +0000, Ferruh Yigit wrote: > On 1/11/2018 3:35 PM, Tomasz Duszynski wrote: > > From: Natalie Samsonov > > Commit title updated to [1] assuming hif is an abbreviation (btw, what is= hif?) Thanks for fixing that. HIF stands for host-interface. You want to allocate it per lcore so that couple of lcores can use MUSDK library simultaneously. > > [1] > net/mrvl: fix HIF objects allocation > > > > > 1. Add checking for non-EAL threads. > > > > 2. Create hif objects on first use since sometimes on probe not all > > lcores are initialized and can be added later. > > In this case the hif objects for later cores were not created and > > this caused system crash. > > > > Fixes: 0ddc9b8 ("net/mrvl: add net PMD skeleton") > > Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") > Cc: stable@dpdk.org > > > > > Signed-off-by: Natalie Samsonov > > <...> > -- - Tomasz Duszy=C5=84ski