From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id 03B557CFC for ; Mon, 15 Jan 2018 13:25:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Sq16kaq+Jd0V7K4voMPsyYMszzlCn4Ph2Ux6GSvy6dk=; b=VR9rZ0A1SIjDWg/sAkGZ/auGEM8lJ2YAOQx7+O4GaRQP1+/S6PxKlaTENk/Uby3COyOW/rXgP3r7RT/8Lx4xcvfhxcpcP6+biuuICn3Ol8B1x1CntnVhwu/XeBsGiskzF2j6cPi8HmNeR/I63GSHkrVOQWSOA9aGjILoC44JK7o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.202.243) by CY1PR07MB2523.namprd07.prod.outlook.com (10.167.16.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 12:25:03 +0000 Date: Mon, 15 Jan 2018 17:54:46 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115122445.GB29114@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [106.200.202.243] X-ClientProxiedBy: MAXPR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (10.174.63.34) To CY1PR07MB2523.namprd07.prod.outlook.com (10.167.16.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68850c73-9602-47ec-a105-08d55c13020f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:CY1PR07MB2523; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 3:07tq/J6Pzoyek83r+lqQrQDcVSbbC5L84ffxsrl7xa0FeTfF1mauPjZQmVQtQLNvSozQ2SFaSS5YVdPv7E4t5/FL3WjGqvlFOWb5iprR+w3OgusUFMzP5PDRmvI2OwILvoYkAL5wHKTmtRCJahz2OpO2CuZvDW1eSygtD8fLQdR1nv4HiXEVRX+fZfV/mJCfq8UaqHgJ+UwB7/Jl0ulJHF+A6vM/MKErT2+nZWGSeAKfX161qVVi+OR1T/i8vXhh; 25:A7x0gjCmw0CC4rJ3Cn0K4r44CYIWd+HJbnLbK5R+FI1pgvRgDjuG0vumyYRnGRX3uT2mweaaT1/ElpZCfs7qB1GOK8O1csvFU43DIFHQW1J6HwLpew5gi5fYCbe6r/op+B5k5bABqNAcZlvcSbm4eRESHMAofCS1V4AG2m3IgxPkD8cgVaAUwo/z/YyahzKthG7tt3LDEL8XY6ljCWMCFFgCapx3HA1vD+1E4l1mReUV6u+Tp9wyqCa+S5yLn/KDOV+uiuffS7a7J67rWN4+zyYqFbpI3O3YWRkgTerlNTMpWbGJnrz8mI0XfmgfUFdG7asj4xTOaeGk+52BQ42G9g==; 31:o9FTnhi27iftbYbjaKckp7LZZ6wQZSYcxl2zGL4tn7n0INEHYZdlg04RmTFKaJLFCwE1doOi6a8Scuhon+az5Y7X83zYG2y40/RcY9ZuzlB5zEi8EqKmOCkwQ73TlQVEZTZwLMEsXRHUXmpQAlFQkxi3ZTgXW/UguIxeYEDCFiIrMY6YWRe3eSpY0b5PZfZxpeFVpyZ0R6+l0u9Y3qBmfVjWrn/XyH0+6BNN6M0HBto= X-MS-TrafficTypeDiagnostic: CY1PR07MB2523: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 20:WGelNqX06QuWfkNmMw6qaqMs3D0A5pzkhABBTwebSSNXr5Ac6sSebBZ1okIhA/JGfBS+v8+0lpBrdByS28SSeesAIVV1w37ddcm+IvPQn7BEPykFnVy7VDE3E+7djL2B7KQ3lkdP6ytVyvMW5vsD1sHDvVguvXnEKiRppNnQSYCR8FhlZPfPzZrV6DtuBsjw5GRNPaiAnkjRTJt4ix1Jn3BmbXV4/tvTv5C+qgZ8OuHCIfHSj6P55F/sZgwR25wMhLHfyg/CnNjQHDEC3cbnjS6+X33WmDS8oxE6sLtbVSBJ1JkEmlKc70CfZ4W0oh5I1AWx0R4epBBYZY13xY7x/KRh0YsoNAfSrhHQptXH6sR9rH7lfkY5w0lytE90/IEJdhzfMeuHnwchzNyc+AdL4KTC6bBDnDDPMVWadkbdnSFSu7QC5K9wDGv7Q3bHVeo3NJrOAEMIccFcfGyOM0ibfAVobq/Wms3Vyc4l1XHxso3LsMVwxtVVuyjIW/CQNVuMaJJS2laAGUymTPgF+4O/y2KvR1CY8D+eMo4EZuUhCyfd2c7mPqlWA0MJ9imqJABtSKubOrnO5sYQlbCyCBGdn3VWoqRM9zdXorVDk6iETEc=; 4:utG79zxtuUg1o2y+40JveS37NneJwpfjv4Lro00HwcHSnken54gSAn2L/Kxlsf0CUFxFh5ksqkOqRe6mfkPdIzmgs+oqvcCBNh5I/2XjjSZUjyMhp6w34c0yLjk2jS2PgK+0dJ0vQyr5XuCjQ20Ib4qn9k7XnfRSCfepqJjC+uN0BYlF50yfccxrtKWdFSAE5jzHdqQUYDZTEUOQw9Kz/XpDI6k8qQl+f/vs5LTMBO0oN1SMkIl7kgTvfqSF2rvRyCLyLFmz0pUZONAgMUBG7ei9n1Fj/jeeBJg+Ca2K3s3JbdDwVzMnPl7+/VRKBqEs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231023)(944501161)(3002001)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR07MB2523; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR07MB2523; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(376002)(39380400002)(346002)(366004)(396003)(199004)(189003)(13464003)(23726003)(2906002)(6116002)(1076002)(105586002)(3846002)(106356001)(305945005)(6916009)(5009440100003)(7736002)(42882006)(2950100002)(229853002)(66066001)(25786009)(53936002)(33656002)(47776003)(4326008)(76176011)(50466002)(55016002)(6246003)(9686003)(68736007)(72206003)(478600001)(8656006)(386003)(97736004)(316002)(16526018)(16586007)(81166006)(81156014)(58126008)(83506002)(8676002)(33896004)(6496006)(52116002)(8936002)(6666003)(5660300001)(575784001)(33716001)(107886003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2523; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2523; 23:CzcHn1wMsMCYbJv2JBuE6adIfWBzbVthZod3mHmIg?= =?us-ascii?Q?I8XFBOACJ0sLPbVBSU1fGx1zdi9xyo+wdvSGIgnmaUhoRSQPe1aWznfBCYzo?= =?us-ascii?Q?03wt+jMR+PZuMRigKESLkmbTyKVutdpVS+ttHYUqb9PQJwycDy6+QLO0x1M+?= =?us-ascii?Q?zggEEu5d/+KEsN9NFqfePiirFb02aYWeNQODtEUhLM+mGS571GlzyeRt6k/W?= =?us-ascii?Q?7FuqSppWxhA/ptE8HsMJtnwFAxD8tjUQLHr6Ig1kbXFgaNHUK4k4NcFDSsze?= =?us-ascii?Q?kRVQ7gHBxAbzpMDbiUVn7q6mRtoWtizSLebIuCa+l8kiSdQvK4jFp1DtAlUw?= =?us-ascii?Q?9nX1hVPlO8WxMk+y7TdYZ8xihelTZMb+YybjVwZdykf6peN237iWBXzoZxvX?= =?us-ascii?Q?jmh7v6+U1WZ+gkDCMGE69mycp/Hupcwju/9YCj3Inx/cwynFhVNj483BADba?= =?us-ascii?Q?sDUdmTRcp7tCodk/KHHXY6nOR/C35IStzsqJttdLqmzhGUUSbihur0a3zUir?= =?us-ascii?Q?odr1YSoHWO6nhCYEYERDOpCfSPSi36UXL5J1c5FOGHba28UFvp1bsjv0eLs5?= =?us-ascii?Q?T36yOOHV64SZsJFNv6DyfMUX9HTontfuXMoe+7x1lL8RqrY/AbaeljO3oGvu?= =?us-ascii?Q?WehU1W8UX06UwopiYXJQgTR8m7Ri/1ZofsHHUs2kcdzfa5Lh1y30wCdlKsNZ?= =?us-ascii?Q?gcbCXwqWaYpFp0Px1YctxqaJjOF3/cF/zIMjtAjlvT5SJKUPpWknW4qDogNv?= =?us-ascii?Q?L6I3ZpUbpPjydthLmooacz4xdb9IWDdQsFZT/y/+A/pQERmN8wof/V98HkD6?= =?us-ascii?Q?yJjdgU1DIZMDhBbLQXlLpeYPflNb2M+iTRvNZn9EzowW9xvMWWGIY3q2uO+P?= =?us-ascii?Q?3p++OFhdi1J3d4wUMbesxEiw7CGyTSIs5zyRMd6Ef1yUpJ2dFBKtT+AWrOE9?= =?us-ascii?Q?sIoFt4MAnxZMJZxqR4wjeqFgxI+LIFENxg61Lyo3GowdG8EvLg3FLgvjRudo?= =?us-ascii?Q?hzA259yASBdH/kH1IYdHs+LY9nfZYaXqeDcCyHi4ZWkeXxfje9DWQz+ZSZhc?= =?us-ascii?Q?2lpKEs0XJ9WEAJZFUvRN4Qbu+wjcE3psVNk96CkYcEnCWSDer6Ywdm5qosSV?= =?us-ascii?Q?YX8edDVHpgMl+xafArmnpwYem7pZ+K22UyyixKRknKN+X3fUlUrJhyv+OVol?= =?us-ascii?Q?/ZjEDhkv7DF/88HsDd1n/9l3dIPWbN8SIrsvjPaH/6EruL4Qfyg4MRdACiFy?= =?us-ascii?Q?uVBYIzZLxu9JK3ceBGoLp1+uFJi8A3KJBvLY1ofzPLEXBjfFPMtu+2O15Q8o?= =?us-ascii?Q?nnlKDGMQJvOomqKs4IwsAS5a0ZHirtfTye8KXwIqEol?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 6:znfnvm5acni/DY7o+GWnwPMAdvYHx0KvwZoE/BhtOhwNCGjBCgSpqmkoKc6Wc+tsK5C0i2HfC/L0Q42xdUBAJDHeMObORcdUBoenNgOPTBPjyoYwgqC/eOjUewkQlGng7iHt5PK366LVDuvkvRft3wEkYroOZOA59R/W+2FqTMyDtDsEajO6Nhv9DehQbZXr1r6HVp5gdW64EI7vqNfOG3cGiFzP2QjNtUWtDGGSO7Ntczkp4yVLi4xo8yCF2UXgfAZcTrd/CKkDDlSgPYKaDJz202DcKOLBasugEllfuIHhnvKDW7uN4VmxLAymAIpV67YWaJFj886U9qy0NHQzm/Gqr1u+aMzyUpUXG+a23Cw=; 5:eiOLYmSwnMI2849BAiE6/TnPON0pGeXf5H1b/OfpKlYBe5HHyLYUd/YWna54iR5pQlCi7/UCz2GHRb2VaxPHWsveH3FS82jkJ0oKYIFCfRg7X9CSKeq6myOqxs7HMMcLD4k6wHo/3dXEyduwFjj2d7I+vRZzQBsGczIEvVCCzmA=; 24:uppDlVSPwSvxCwzBf+n/fZQgF7JFRkwqsCHZ9urBqSRsDJjZizPCdlyeGZ7DOl/iosV+2xzt/VbHaFhX6G0SPHBYnx0N5AjRwjHM0YDW20I=; 7:bSAzyMUWW9nCnU3RdWK5z9+qEiyCGtQarJavJ2Q9HvbDdIgkNMUHE05jb9o0wBofBUcw+bUcL6yh1f87IewABuspJ7VKtMqmtKJOPSyVAI1LSg4GW5Zl8jX8eGiHs5ZvhvOq4S7hwiEzs7peHFmyAM0L22+HCbQSPPY5rm+4aa7QWIj6hrwqy4b6Pteo6iAUxhSB2W4QZgq+MT7x2KGZHKsea1oWU8EIcXwHKrQNC1tGFJrqeXNBKi4HTCJRTaLw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 12:25:03.7131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68850c73-9602-47ec-a105-08d55c13020f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2523 Subject: Re: [dpdk-dev] [PATCH v2 2/5] eal: add platform mempool ops name in internal config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 12:25:07 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 11:41:11 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com, > santosh.shukla@caviumnetworks.com > Subject: [PATCH v2 2/5] eal: add platform mempool ops name in internal > config > X-Mailer: git-send-email 2.7.4 > > Signed-off-by: Hemant Agrawal > --- > lib/librte_eal/common/eal_common_options.c | 1 + > lib/librte_eal/common/eal_internal_cfg.h | 2 ++ > lib/librte_eal/rte_eal_version.map | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index b6d2762..1ed0ddb 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -219,6 +219,7 @@ eal_reset_internal_config(struct internal_config *internal_cfg) > internal_cfg->vmware_tsc_map = 0; > internal_cfg->create_uio_dev = 0; > internal_cfg->user_mbuf_pool_ops_name = NULL; > + internal_cfg->plat_mbuf_pool_ops_name = NULL; > } > > static int > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > index 1169fcc..12c5b8a 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -54,6 +54,8 @@ struct internal_config { > const char *hugepage_dir; /**< specific hugetlbfs directory to use */ > const char *user_mbuf_pool_ops_name; > /**< user defined mbuf pool ops name */ > + const char *plat_mbuf_pool_ops_name; > + /**< platform configured mbuf pool ops name */ > unsigned num_hugepage_sizes; /**< how many sizes on this system */ > struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; > }; > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 3fa1e13..909691f 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -203,6 +203,7 @@ DPDK_17.11 { > DPDK_18.02 { > global: > > + internal_config; I think, exposing the internal_config may not be a good idea. We may need "plat_mbuf_pool_ops_name" value for multi process case too. Considering the above points, How about adding it in struct rte_config and then expose too rte_eal_get_configuration() On the downside, it would be an ABI change. > rte_hypervisor_get; > rte_hypervisor_get_name; > > -- > 2.7.4 >