From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0074.outbound.protection.outlook.com [104.47.38.74]) by dpdk.org (Postfix) with ESMTP id 9308E1B00C for ; Mon, 15 Jan 2018 13:30:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wcd8GHtnDwqWV5P5abum0FbRgpJtXjpbXhY0/acApW8=; b=UoQslgFjwzo4HUU81p79QJbK9PxPedU0vVQnz/iAT/WUKEuDcHuIC0Cir3+TyjwzT2sHN2vEEf5fJZ0NkC17Uva5CU3wx+IZYhdLlArs/mnl9/Zobnk9SueJPmrmGVi3L5hTTXmA+RkPbvneYDPnHj5PJtQwM8Nt++TFyxkR3iA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.202.243) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 12:30:00 +0000 Date: Mon, 15 Jan 2018 17:59:45 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115122944.GA833@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-6-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515996674-26338-6-git-send-email-hemant.agrawal@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [106.200.202.243] X-ClientProxiedBy: MA1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (52.134.136.159) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c624bdd3-5f5c-4afa-01c0-08d55c13b349 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:Xa0jacSKRtX/HgpuRLTr9Cgh18ZZWUZj5eHdZUQpcNA/2tNckvfE1HLQ+38x5TGqseqoqdkHq7clSP8k8w90m8hRUphWGModMYMRB84Tz5Kb00I9wq5pjp1WAuut+S5TjysD2XC7NHIj6UPbQYhg1FYa+ekp+NjvGg831tBeh0uL8lrtzK9Xhz6TM/28UPFTddPCcmpnfrEIAJU6e1GJ2TORIuzR2mhHHplgb3Wipd3dUY3jb4W6NVvYskWw8Yao; 25:ROch+RD+n6HBGWnurcdD4tcB7ntDjEzqbP4qB0rnWIzHXBetc0MiP6QU2arJMBFGtss7gGm4yLk35KsJYcjzglAEEgUGXAu4C9KzJN6xKEpkiKosi96o7VzIGPQyystMoEPFm8E9DDLuXRZNO1vQLiHNncLxeM6RSytVycqJGKHvyHQ3ghcila2GNQjSI8spmwzHgX7/RRPPL5DZ5gRVMhn32+zDQPzYkypc93G0TyZ3BD8NRAXjlIEykwLYTU7uF959ci/6fUDxTYoSGmOfQsiE6DQWVgPmlNT1JhkV3LexQpUOYCxd7JKPbpperTbophEP4BICRCkMfvlX17xpaQ==; 31:FroHuP2mixldvspaAmsOOGNrTcp4phQqrc+z5EEjDm7aFbx1UBrS22Skq5B60k6nkovDBIhis1N3cUmKrX0Mhj+4F3BHpV7bFLIg8MLGVITFskyVqHq7iI/56iSxt1NehwHCwb+kh/aqTDvV9D8+YQt0DIVZTxdQywxIkcZVNAwSmVgepGs8IWYEYh2zx5jmdBUe3YdeBm7QbnvntSXjcNMlwi7cVt/ftszw6AjFrXM= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:Qaf1i2tqouuONK3cOUWBl+ENgr+RVn+U0Oij7RvSLfFlwatiOT1WvuMGtnzKoM8INyJ1Rn3aQ7rY97HTR+LjbtLDn/I2I4J8XHoE5FvzjyD4fg5ObXUTpMhJ8cy0UNZdg+kQ8duX88zfzXDSoAle0LPonxU/GVquHgfp81pPR/jf7PAGSP9TBiyO8TcHToUlAbPRYRg30YStEE54jtLDzy52jy75G9xJIbFOXeB+Bce/+Uc2xIFG8xCrWA+UlNomgDFzVLjaEp7xcf0R83IHupqL0z7d9mhQae3oN2KszodeEhm6dk8rqMcGSbUiGiNHE+AHAh72G2uF9/Ugo8zeCSB3NGrQRCByAjq7fKYpEt+rcxpQTpyiChxRRX/HPpWPszlpV34QgbcItjJobNEMzjWtghSOf2YvCF9yN8nK2Kb9yuiiRCPPE1+uugW7drU2wm+W+cTKytjeuinWEyD85GC7FNBR/2F/dw//2zmNJKC30LTYaGduXHiW4y20wbIzxOm/5DorleQDhd66Yst7LIKatoBb45E+OrFYOYKy/yibK1MKom7ORdwz43jGU7keLJtd+Us21NxphLh3Jg4JiOK25DUbOkRybIx7eAjiTpA=; 4:aKiq13JHUAAb3SEuDnPf1OGB3nL3pHUjGVfT3HWThBfK5/q0l3VQMLHcYVuR86rrLSyRMpBJ3OWeYHgE39b4Tre1oLF2rAUo5N/BMKS175jEfS7MGA2TWoApqXV04+1hn7o8d+To4ONpP0XUdOIFjVIH82nS/NclSq+uepkY7GZjCae0y/T+nBnCUvVU5nxum1OLpsKgTPNrrg4s7kUm5/d4KBb/t25b3Xe/xVoM/75ILev0R9Cofwvd7W5oa+s15son9Oyp3HnBYxZw6UP3afbs/zNZRISMALZV2HykInghHv2cbCbIceu+Rny3W52Z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3002001)(3231023)(944501161)(6041268)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR07MB2513; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39380400002)(346002)(39850400004)(13464003)(199004)(189003)(316002)(386003)(2950100002)(42882006)(6666003)(50466002)(59450400001)(5660300001)(6916009)(68736007)(6246003)(107886003)(52116002)(16586007)(58126008)(97736004)(16526018)(6496006)(33896004)(76176011)(5009440100003)(8656006)(83506002)(2906002)(1076002)(305945005)(7736002)(106356001)(105586002)(33656002)(81166006)(23726003)(47776003)(8676002)(229853002)(33716001)(25786009)(81156014)(3846002)(4326008)(8936002)(55016002)(66066001)(9686003)(6116002)(478600001)(72206003)(53936002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:E4nXNg0PpFcjOMxs3o7orIVzSpNgQ/3XUKo6zdq37?= =?us-ascii?Q?idkC9IbrIzLTz3Nw9p63WecUcKNtn0wT1vBgSYDBcsgHhQr+3sTW94YF1wgl?= =?us-ascii?Q?DglJ73wX2xeGOV5Sjt1fLXJcRJCe9cxZFQGBgLdnmC5TiOjUuPT9tzHdgME9?= =?us-ascii?Q?C/5gTy4sbGMwVLaf99IQD5wTP+dvvrEah3el9iM/QWhK4yXzJKcE2edRseU8?= =?us-ascii?Q?92AhdxR2D87YBtdWuuQv3yBH5nFnrUGua4mggvrSJxWobOT1CrLprAxP4Y3Q?= =?us-ascii?Q?GIBcn2XHF+vEUaaXOTM4x29MCuvCfkXiKPBgJOxp/bHfhnpSbJybM2uRe7f1?= =?us-ascii?Q?8WqRRjY7SRX2SezGz8ZpsrMVFPC175AQeIPnL5mLoKIh35P5uMak22PnfMvE?= =?us-ascii?Q?ooWMqmTS7QRTdWBwWIRgImKmJrUQAEZiDr7J+GNHu6oHBGhCgw+Oogm6GAXt?= =?us-ascii?Q?/qwyLQgUT4F3FV2bnqAqu5BOYtAE1+zNgROEZUHpcxPoXpu4P5mmPLvhMqbr?= =?us-ascii?Q?jKZ3zlqZxbP80qLNDH72o12bw7y8HWkh+Lb0qhjLrjkNNrntfneWm2FDsIGO?= =?us-ascii?Q?9F5ZFAzXwVJUYmqqAwt8J+5sOhCuRBTJkeT/4MVp7jfi4A3nK3VMKVB5XjaK?= =?us-ascii?Q?m+Xic1gOjiGYj5zqLcbG20ZUcC+NV4ha6QEL0MEHn9YdiF9EtDmHtCV5cwbR?= =?us-ascii?Q?I0QIX/zqaRKhFyl232Tcr2y5I71CcUbZ2SuMGxySeWtR7pDqM8vk17dVcLQr?= =?us-ascii?Q?ND0cKcdSdf6a/MjaYPw7BxsO8wjC7j0UHmzWDf6Eg80oqBGm3Su+xYTEZ3w7?= =?us-ascii?Q?9S6ydro4NxrkR6Jl3gbA5HpcCFg8H5lfnSWwVRpmhbZKu3Xf7XVC8FYFXKwq?= =?us-ascii?Q?4ur/xCJEio4sVMAm0St83ksEXQrnpRGEbTKFsOVlpkGRmQWlk7x27nlkJjjm?= =?us-ascii?Q?I+Clf/UIiWogwceJy+ZJs9Q1txmUd7RZ9lZnkppwLPs1o0Y2H1uTXwe/5cwM?= =?us-ascii?Q?jtdO5VXuiMNVslbzTZvrnq/bcR9iFLSSMh80nb+/D6fm6wSDTLMdtKFEDCv5?= =?us-ascii?Q?aWq5dPUc7JCQopidotgGSMC2ogU5MT5CHSkkmmTTyaMSRTGhMQiQyHvrIvjr?= =?us-ascii?Q?hlaWky8Yic0gXsVqIIor7sIoA/pOayZIoN5Kk1s1O+BEHSWUNmNoQVRHuT8X?= =?us-ascii?Q?0S8Zxve/OyZIYDJdmjiXh3Y2GCwByN7gqy+NP32kD2atgdjcM+MXDoUne84f?= =?us-ascii?Q?3P/q3PEB6Ckp5U24lSOcK/3bSyuH9iln2Pd1wZUNUx43aIMZTVjLaSmWwXHH?= =?us-ascii?Q?OH6LwVcZnSmSsfTLQqmcdos8DK060YW97ymh5NGznGB?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:v+yvwKmZLfFxjEur6vNukk08c7HACrTgwACDok4H1NJdnnTNgruLW4R08cLdX7YTtDGTYA/oUTG3O642ZidUWiU6DJWfTzKyrthpKzPQx5vBhugvP+zyx2OBF2NSXhdbCyAO/74SH940SVY8UehYoFj3obW2mHIBHmcZ/Zq3NHsxivpJieXyzc6RBz0u6TxUeyiH3NAnTCNn8Ce4Ks+6+Y5chrPGUM3mpdQ/ROEZJHtKWwcpKFcHX6/EsFsXWbwk5/9eWHjOX1Qi5c+a4qzwEQ9JlLV7M+dv7OJ+BjFW4t/wq2swZnERIaCVxeJq1Rai/N9VzBmazJCidHNhRG3LWnkVmIW2efzEm/1vUHqxDHc=; 5:t96jV8MpEGvHlVG3gtt54Z9abznEDlnJy05xPDMsK6ZXAAu0lj2iNC3rxjf+acbLTPLeoNnyJKkXZ4W5WtgOKgvxwONhJOh912cYBDpGReLTqXYgqh7wNGQlDXBik89ydn8mRnlh9yLAanFkIY6w4xVbnHQRdGf/aaQ8L6sntaU=; 24:axLtMETDySwFzrAgoD/lrb7OOBvrBVrcxDmuK2bVupeUNTwB/XAiOJNlQKD3Odm2tdeSHA1KG0feY3RIlsX0TIWcZj7BcJ6VZRg9Nt82azI=; 7:4XPZXmlGPf5tkwTttLzLsUIEU1ooGZMhakI8Z5ssHB44EJGmxIlgcPuUEu5jRoiEjGs4by37wt7mEcH5jixhyiJfXAUmiKnlfRFLcsN6xiVfcbbOca4rPV0BEVgkZMnpk5cpqiKdMErfgZeIPVwfpdky+01XW9HS6asuhoU6OS7CsKvXkwGlzz9nBkDI7g1NOjoqGh9XIFBPniq61JQxWHu7wIl75y4HjCx+pRUVYZQoNz6mv5NRhOnNDLDebm99 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 12:30:00.7989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c624bdd3-5f5c-4afa-01c0-08d55c13b349 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v2 5/5] mbuf: add user command line config mempools ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 12:30:03 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 11:41:14 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com, > santosh.shukla@caviumnetworks.com > Subject: [PATCH v2 5/5] mbuf: add user command line config mempools ops API > X-Mailer: git-send-email 2.7.4 > > This patch add the user command line configured mempool ops name > API to librte_mbuf and sends a deprecation notice to remove the > similar API from eal. > > Signed-off-by: Hemant Agrawal > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > lib/librte_mbuf/rte_mbuf.c | 8 +++++++- > lib/librte_mbuf/rte_mbuf.h | 10 ++++++++++ > lib/librte_mbuf/rte_mbuf_version.map | 1 + > 4 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 13e8543..ec8018f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -8,6 +8,13 @@ API and ABI deprecation notices are to be posted here. > Deprecation Notices > ------------------- > > +* eal: a mbuf specific API was part of eal APIs. This is now being > + moved to librte_mbuf to be with other similar APIs. > + The following API is target to be deprecated on 18.05. > + > + - ``rte_eal_mbuf_default_mempool_ops`` replaced by > + ``rte_mbuf_user_mempool_ops'' > + I think, deprecation notice need to be in a separate 'doc" patch. > * eal: several API and ABI changes are planned for ``rte_devargs`` in v18.02. > The format of device command line parameters will change. The bus will need > to be explicitly stated in the device declaration. The enum ``rte_devtype`` > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index 482676c..c587d3a 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -168,12 +168,18 @@ rte_mbuf_platform_mempool_ops(void) > return internal_config.plat_mbuf_pool_ops_name; > } > > +const char * > +rte_mbuf_user_mempool_ops(void) > +{ > + return internal_config.user_mbuf_pool_ops_name; > +} > + > /* Return mbuf pool ops name */ > static const char * > rte_mbuf_best_mempool_ops(void) > { > /* User defined mempool ops takes the priority */ > - const char *best_ops = rte_eal_mbuf_default_mempool_ops(); I think, we may need to remove the stale rte_eal_mbuf_default_mempool_ops() once it is replaced. > + const char *best_ops = rte_mbuf_user_mempool_ops(); > if (best_ops) > return best_ops; > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index f958e3c..7feacc0 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1143,6 +1143,16 @@ const char* > rte_mbuf_platform_mempool_ops(void); > > /** > + * Get user command line configured pool ops name for mbuf > + * > + * @return > + * returns user pool ops name. > + */ > + > +const char* > +rte_mbuf_user_mempool_ops(void); > + > +/** > * Get the data room size of mbufs stored in a pktmbuf_pool > * > * The data room size is the amount of data that can be stored in a > diff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map > index 9b53502..d4af497 100644 > --- a/lib/librte_mbuf/rte_mbuf_version.map > +++ b/lib/librte_mbuf/rte_mbuf_version.map > @@ -41,6 +41,7 @@ DPDK_18.02 { > > rte_mbuf_platform_mempool_ops; > rte_mbuf_register_platform_mempool_ops; > + rte_mbuf_user_mempool_ops; > rte_pktmbuf_pool_create_specific; > > } DPDK_16.11; > -- > 2.7.4 >