From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0059.outbound.protection.outlook.com [104.47.36.59]) by dpdk.org (Postfix) with ESMTP id E06153250 for ; Mon, 15 Jan 2018 17:26:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aytLhoH7XQaGxow9ncfo2Bne57op7NQVHtEXW0jdMFU=; b=P2lAKndTfKdid99Wi/fmmuFCjis+tYe+6CUuBco+plmm5+w+WJJY9qd7mej9O+7Ps5erO6Fok+hcbyFURSA5HaudU7gtwjrWLP0syb1GvVqBeBpaQHtWT+SlDcC5rtvNBa4J6/uAVsrT0H/+65u8V4PFB5LfO+zl31lt+sysilU= Received: from jerin (122.167.99.131) by SN2PR07MB2525.namprd07.prod.outlook.com (2603:10b6:804:6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 16:26:51 +0000 Date: Mon, 15 Jan 2018 21:56:36 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115162635.GC1245@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> <20180115122445.GB29114@jerin> <90315b96-e3a1-b47c-935c-e6437cef2716@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90315b96-e3a1-b47c-935c-e6437cef2716@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [122.167.99.131] X-ClientProxiedBy: MA1PR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::17) To SN2PR07MB2525.namprd07.prod.outlook.com (2603:10b6:804:6::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 896691ff-3f56-40ff-815c-08d55c34c98d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:SN2PR07MB2525; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 3:11iWQF5Ml2CYNqzx9aoGM/wfQEdKcK4eEeYkbq7nbxotnc7EvhFAVMIqQ8Fx2hOzuEA3+Awr8+7VheE++HKTxe+kAzYO04p8UoSXvtwuLDDCOF2+OcRJVJl5tG4LA0hOBJc59+Alu34qC1bD5UKehI21jsfUUpfQiGqYUJB16O8UyMZOQ7QcUrMlKOj97+GF57VBqCRJJCqNtNzqoQ8xlyQWJOSypy501DRk3cahBy1pDLmCgJbsvFQUkJzZdmua; 25:SY1tmq4/nGTVhis23FOm3g2yT42shyIX2+tEmaDp1GQLnEpESdzNkbTOZ1Qb6W4ssGftJiLoskM7a/3KM0Lk2bQ42JW8/vEDjPrTJ73bXzk5EUV45Wmzrma6jqQF2cXJNSM5Xa4voLZf1vBnFFqPIt0uJkhCRLWZMeeB8VXqEAoLm8fQ01n2Giw6/RAJl7JeuJSFhJzgwy9HBe2UbttAxcymBecFiGfEMSIoWrSn+MJ7NfkPjamsf/iLFSDGpb2ljdh0phhhdXG+ButA+CfrKARqLWp9eYjt9vL4iQ5LGLp1qnRISx0QrQIx/LRihT44tBogEcar9XOl3Hm6Dr8/oQ==; 31:CGrM2XwlTVj3iQ6BGHXiSeetHqmxvJD3jRt6+mU6BQogYrR1nHK1jyY4TCs5dji1WGW/bh5OcgI5CLTjlU/NWu+SUXu2bwTveqe+VhUBx9AW3FeWAKIoSBuhqhBqS6NnVyqTCu8IsTVhPIKb3OB7gJy4cMkMv02bX0x5m96luTox7kfx+ETs+ACw/VbxKVairGM/oJa9LFk2XV/9TuLD/QfHavN7iNfZt0/qQJpdUKg= X-MS-TrafficTypeDiagnostic: SN2PR07MB2525: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 20:j/XJiUjmEBrIV0sjHf385m9rUkM71fWeL9CSuYCJlCthTUHoEZ4YYbQiDLyp5NY6rGURms+FlBsbicG+3pvTN4oC8B1mlAgbAeCCH6UriMAUG80novTpttd1BkJBpZJvjIfZWYoqEyNT23aGNwaM4xNonKCPIHIoLdPEE/41UGVmSwMQtsbfkc6+es3RgleHe3UFHgW+dzWVC0w5WdBfoVgzebSZMYArl6vMTYi2HHviD4OlLLlJTTx7DdjPuTQkv18E82CzChwU74azqJqyePxoTZVfUQwf/yUyJ5pO9pnZKn1M84x5rC/P69hUcwstDnUI3l3S93EYRQ7dZ2+1mu4r06o2fj2gKgRiegbJsIkA5VrS3lpG33amFyOm4eNhNKL+HTMzk1L06f3zHXA9hvAlVkGD/dr8mn3uI+ONBtF4gq7KiH4a7YafBJFMVHPB5Dd3XdlF3T1ojwBfoJA8ew03ySpsSMGum82KU0KKMDUR1MnmNj7JU4xQa1xsuFnT/wHfKUIxB8c5ZPapiy7Sj3SIGNPCQEq8g3jr8fIjnA4FPip59FmQ12SzsK57t14VRzCbUiOgwQ0Asw/QKEcWkmDZr0o8AiQWF0tA3VFTp+g=; 4:PqLxJquUt6dqc0rM3OFjhJW2qIGfjt+RIcywpl8jHRxMWWc9hgftPotoVEPxAKvdlYv6ipzhnsvozONw2KvYLDvT9rBSyqsEug4AWCXqfDnmzrGi7eOErWiHG+of/pCci6p6Tj+pTIP4hCqxUbCFzYEcX4/dB10E1HwFnBT0fuTEPDXCnyVCCHfhu6NVfIWwmGUi2t63GHFz7m1rmAWMnVdSeKoxD4mStlHcuIe5460PkZV6OP0psgt/cLeAkCkGUFUP3D5o4iGmM1wUDfSxpZL3LLndpzSXsC+lbo+oGJ19qq9G+EpykjTBRmq/T13t X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(3002001)(3231023)(944501161)(10201501046)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:SN2PR07MB2525; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2525; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39850400004)(346002)(396003)(39380400002)(13464003)(199004)(189003)(24454002)(3846002)(478600001)(1076002)(2906002)(23726003)(6116002)(33896004)(386003)(105586002)(72206003)(6496006)(66066001)(305945005)(33656002)(106356001)(7736002)(53546011)(97736004)(42882006)(6916009)(5660300001)(76176011)(6666003)(50466002)(52116002)(2950100002)(229853002)(83506002)(58126008)(16586007)(6246003)(93886005)(25786009)(107886003)(47776003)(8936002)(81166006)(33716001)(9686003)(68736007)(53936002)(81156014)(8656006)(4326008)(55016002)(8676002)(316002)(16526018)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2525; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2525; 23:r1sAXttfwugYv7w6LSAUosdmY7b3BUI6gU9fEiV4p?= =?us-ascii?Q?L3UrmXMd8T3Z1QdzEHdyOKv1/+Oai1nNhJEz5qgk/y4bkvjFOn1mifhfnA9i?= =?us-ascii?Q?1P5ASih2rlHmDjhUvdHrRyJsTIVBml427zpIQRz35FRlHddkBDIPhh7zaf/t?= =?us-ascii?Q?6warAG039MQmLFt3oD79plE54w02IlbvKup4/c0WLeeKU1Pw+DhKjLR6tsvq?= =?us-ascii?Q?aHR6LnJzKDmPv1D/fIjG5UPKTAI2v/e4eAiLiEoXlSoDPihIk/jrj8aq0hzW?= =?us-ascii?Q?f6QCcRjVRJQCYEaAy2jwGr3sqATaL1JSppMvKuK2yaMVOwqqdx607Ii8uQZ2?= =?us-ascii?Q?fLj7wvTYu9FXZ+OrszdiWPzOUx/ueeyewlF/CF4Pqbucg5VkzR7om0kWSswk?= =?us-ascii?Q?ncBqK6pfreQpLs/Ha258AwMzYUGNy2rhsSrE43W6p6vu1nFJOSGswVMP1l3y?= =?us-ascii?Q?Cu6qivTi7fTaK8TwdRUDiiyPsMENFgqB7eBffiL4ppatjPRn9Pr5HEvTMTP/?= =?us-ascii?Q?6b0UdlBch9+i7juOmcPILL+44esi11EHmxTOKax5xHSwGWZexVD0F97GDqwy?= =?us-ascii?Q?RJYs7s9kolAx3apAMjtgz6HL8/LgkJYOWiqKBnErC/RfFABjms79K1tjYoc1?= =?us-ascii?Q?slKeb5HfSDC0uilwR+YQHBIUtNA/ehN2/WmksnuFwLF6UVMgeK6JFdLIwoOk?= =?us-ascii?Q?a2N1DpelUA1xz+3aBBI2Fc8+KrokZgJMmDXD3Ta9y8uE3h0Ct0VzZUft9Cbn?= =?us-ascii?Q?IKb5jw7ZNJP+pNj5j5hhjG5tmaVAdhub5zIertpGvOv8bnjEN0I4cCpaJFDb?= =?us-ascii?Q?0LLaFxibB/ot7CV2RZ9q0Yst5VE4DLP176MjaC8VCd7LEksNT7dhB4FZK2Zf?= =?us-ascii?Q?dBX33+9dctfhjSWhv+jewTnAaavNAcLksxJNF7sGxP7Lxe1ROXOPRVMKWb+v?= =?us-ascii?Q?Zgomk5myCmUJBbA062moSP92jGSPKyOIeS5/nnia1EDGsTnXc6x0NEEE1K3a?= =?us-ascii?Q?/KLyngicdGjlZfrZY1uUcAgus/OrOULwE9LoBjyQN18mikmoIi5hFXI+tHvw?= =?us-ascii?Q?1+Sst9nQiW3U2nkNoNdtUjfd9C4Ae8QcUTIOuEP65HZ6kpEppfhxekTndta7?= =?us-ascii?Q?ltSuDi9povny9A2UaholhgD948gPv4DikOfD46NxI10o5joVNmOauYMbYIcU?= =?us-ascii?Q?8ghitwkU6jUWF8WY8mxSh8i5tOjCHA6ZXF5SwFlXqVIiGr8hAVhiKGG2UlV6?= =?us-ascii?Q?csDedsgGkfpvqqGjEgI2u7HYZmpXayuX+2rsRY7ABy20Gr342nRNERMNx3Jo?= =?us-ascii?Q?WLB/G7EcRGHkx4MpQZ2lLunnvDi8uKk1DUImrBTUMlLZ0aMJsTj+WPxHBff7?= =?us-ascii?Q?H8UdA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2525; 6:MAX3k2Y+8EjKk3QI+c/7y9IH+Jb5ihz1/sNTFTD5YD7U+/d8BrWLiWVIRhf98UGFOE7geGcoLYWkyv6ERB8bAFdqruViW0B5SKnUXQWHnLx2dD6IeVY4lBy4YY0B9ylm1sm7IYwQxftrrLR1Wdti0eXedJahcDWPwbMaAznuQiPAh2NfyUh3tZB9xCkC5J+aCDRNA5PIEv1ySRWgOV2RUn+s6piNX2iDK1gtrl7NhP6OoED34E8UMNoZtKE1ZMJdKdRQ99IJGrHh+yN9/stagsCVQSoefz9pIalb/Yn8vxRtNo0Wg7IG7cPRNi7gqKj/fHozDVqYblO7CFrgs5RzzStZ1ONarGPHSy8InJaVqWA=; 5:s8MICBwUOrkUuwlaHbAZOW6jZzqsr55jBwufYS+OJDlINgYlh54+5K8rkTBLOuLRj0b4izblLM8TmR0XyGoqWcmO1nCNOoC754TPBrDkONU6hxn12wr6kvsA0I/ua4arsVkmPPAat2Wv4lTaBXe0X/Aui15MD+9Kru5Oyk9BQF8=; 24:VZJJwLymYSHJ4moLzhpB5dEKHZdEJCxXkVKqUkmX3CrfbDYwx6CQP21Q6Lc3d06pIejZMB3eCnLs8HLNTZgbSe8rvz1QqnWBFUdibrlsA1E=; 7:AA2iVCR3MKKpGhO7A9Lt/xM5KcCeU/tGDTnv1O4S0xzGPQlMx8I36232zqcS5McbuQRlHUeBD1cR1H0a6UYRUmZndDaaySnH9H6/Mh6KJ0meRGwqPvOqrHI8PJj/t4oCpcW9bgNLIi5Vm2ngRNq/NrVPBffjdQL+8xcVeNCX25wfI8RzvVCheNdzDw7tTeKEIvNILqZuDYkCT5MBgqPlRPSLeM+XV7Tp7nR3PUc85iGMNmGSEB8ubiOEAqcZhteU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 16:26:51.7967 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 896691ff-3f56-40ff-815c-08d55c34c98d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2525 Subject: Re: [dpdk-dev] [PATCH v2 2/5] eal: add platform mempool ops name in internal config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 16:26:55 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 20:01:14 +0530 > From: Hemant Agrawal > To: Jerin Jacob > CC: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com > Subject: Re: [PATCH v2 2/5] eal: add platform mempool ops name in internal > config > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 > Thunderbird/45.8.0 > > On 1/15/2018 5:54 PM, Jerin Jacob wrote: > > > static int > > > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > > > index 1169fcc..12c5b8a 100644 > > > --- a/lib/librte_eal/common/eal_internal_cfg.h > > > +++ b/lib/librte_eal/common/eal_internal_cfg.h > > > @@ -54,6 +54,8 @@ struct internal_config { > > > const char *hugepage_dir; /**< specific hugetlbfs directory to use */ > > > const char *user_mbuf_pool_ops_name; > > > /**< user defined mbuf pool ops name */ > > > + const char *plat_mbuf_pool_ops_name; > > > + /**< platform configured mbuf pool ops name */ > > > unsigned num_hugepage_sizes; /**< how many sizes on this system */ > > > struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; > > > }; > > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > > > index 3fa1e13..909691f 100644 > > > --- a/lib/librte_eal/rte_eal_version.map > > > +++ b/lib/librte_eal/rte_eal_version.map > > > @@ -203,6 +203,7 @@ DPDK_17.11 { > > > DPDK_18.02 { > > > global: > > > > > > + internal_config; > > > > I think, exposing the internal_config may not be a good idea. We may > > need "plat_mbuf_pool_ops_name" value for multi process case too. > > Considering the above points, How about adding it in > > struct rte_config and then expose too rte_eal_get_configuration() > > On the downside, it would be an ABI change. > > Yes! I was also not sure about exposing internal_config. > > rte_config is also a good option. If we add these options in the end, it > should not break ABI? I think, it does break the ABI. > > > > > > > rte_hypervisor_get; > > > rte_hypervisor_get_name; > > > > > > -- > > > 2.7.4 > > > > > >