From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 585671B00B for ; Tue, 16 Jan 2018 10:49:14 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id i186so6976503wmi.4 for ; Tue, 16 Jan 2018 01:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=QaVJ5p1BoQXpVBFzS+/iYcWCpO7b0jtbRG/SBDctqxY=; b=JDtZuoSqP/cBGLKypuVi/Z+tr5Juq8D9oUR0lHigYnoLQRCobFU+x3eSv2U0immVDC gkrF7lfBsXs/0i5caRRW/DnnP5PFF6VeETO/CxbGACzeMZa0ylGXfrqJ4cVLQaSfdDzL oFzdAsKNYdIkCF/9DB1Ia3L+kQaA9koKpUqOCcNLyTxbVGagPxy6ZzPtOirG0S68s4O1 oJAvjyjGcrnvNIxXzPqnAspWB+YAe02WxT3au8Qh5671vivmHVdh94dWEYP0T6rzYAgg ayCLXui3mPIpRWm2wDDjMLnGTRvXNF8joQLT+0nOT+pzbQMT/AL1Bo0rmze+IbQrhOMX v4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QaVJ5p1BoQXpVBFzS+/iYcWCpO7b0jtbRG/SBDctqxY=; b=N9E1XJOw5v5rbVzglkCelSTQ59EsWsXDyhia0F2dQux31fKDdkqfPbZ8r7j9XqgDVs gPvtbyBtLHhDyuJMU9e6/COCh9MXAEGASsmk57Be7uE2V/knNV41NkzmHT0jaD+mWS6R xAaiwq+66zFP4DOsRCqrBJYdU/F3GQI7EFtpNrlxo8SQX7wk7v8844EBiSLFL1B3o+rl G52XxyjbRIBdSjQzJ/1sAoZGPtyRotKbw26AOuMPoJKXXiamTUiQxM+xNVc0oHHyVosw VZKwaGLBso6sbn+tcmX56VHvajh0E+PeKTQOo++xVyWomrLG1nwq1kOdnBxrFc4XUqSE LfTg== X-Gm-Message-State: AKwxytcrdAIOb+9wqMSIGveerNSVJENqp1usgiwYNkwHPOlA+CTKdQJC 9G1x7goqysQ9esBfJF/ch+aYEg== X-Google-Smtp-Source: ACJfBouZZr2EsxTVu2JTpbIWUv3V+mL3FmB+i2Z066TfIjVFJ79G0+0mPq2oE+wtDSWi8FT6roDe7A== X-Received: by 10.28.26.144 with SMTP id a138mr7803969wma.61.1516096153650; Tue, 16 Jan 2018 01:49:13 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p132sm19266209wmb.0.2018.01.16.01.49.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 01:49:12 -0800 (PST) Date: Tue, 16 Jan 2018 10:49:00 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Olivier Matz Cc: george.dit@gmail.com, "Lu, Wenzhuo" , "dev@dpdk.org" , "Adrien Mazarguil (adrien.mazarguil@6wind.com)" Message-ID: <20180116094900.hm4bhwlpj5aji26o@bidouze.vm.6wind.com> References: <1515790887-64502-1-git-send-email-george.dit@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com> <20180116083958.hk4rtxfoa2y3uydk@platinum> <20180116092425.h4qecfmki2ih5shq@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180116092425.h4qecfmki2ih5shq@platinum> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 09:49:14 -0000 Hi Olivier, George, thanks for following up on that, On Tue, Jan 16, 2018 at 10:24:25AM +0100, Olivier Matz wrote: > Hi, > > > On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz wrote: > > > > On Tue, Jan 16, 2018 at 08:45:32AM +0000, george.dit@gmail.com wrote: > > > Hi Georgios, > > > > > > On Mon, Jan 15, 2018 at 01:30:35AM +0000, Lu, Wenzhuo wrote: > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Georgios Katsikas > > > > > Sent: Saturday, January 13, 2018 5:01 AM > > > > > To: olivier.matz@6wind.com > > > > > Cc: dev@dpdk.org; Georgios Katsikas > > > > > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to > > > > > librte_cmdline > > > > > > > > > > Signed-off-by: Georgios Katsikas > > > > Looks like a good idea to move this code to the lib. > > > > cc Adrien the author of this file, app/test-pmd/cmdline_flow.c. > > > > > > If the command line parsing of rte_flow is something that has some > > > chances to be shared among multiple applications, I agree it makes sense > > > to move it in a library. > > > > > > However, my opinion is that it would be better to have a specific > > > library for it, like librte_flow_cmdline, because I'm not sure that > > > people linking with librte_cmdline always want to pull the rte_flow > > > parsing code. > > > Why not a .config option to enable its build, instead of a separate library? > > > > > Hi Lu, Oliver, > > > > Thanks for your feedback! > > You have a point here, flow commands are only a subset of the parser. > > Do you want me to create this new library and send another patch? > > Let's first wait for Adrien's feedback, he can have counter-arguments. > > > I guess I have to use librte_cmdline as a template/example for creating the > > librte_flow_cmdline library. > > It can be used as an example for Makefile and .map file. -- Gaëtan Rivet 6WIND