From: Stephen Hemminger <stephen@networkplumber.org>
To: gaetan.rivet@6wind.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [BUG] failsafe depending on return value from PMD link_update function.
Date: Tue, 16 Jan 2018 10:29:06 -0800 [thread overview]
Message-ID: <20180116102906.0df665b6@xeon-e3> (raw)
While doing link status refactoring, I noticed that the eth_dev_link_update function
return value is unused by common code (in rte_eth_dev_link_get); but is being expected
by failsafe driver.
The return values are not consistent across drivers, and link update function is only
valid if device is not using LSC. Therefore, the failsafe PMD should not be calling
device internal functions directly and expecting a valid return value.
next reply other threads:[~2018-01-16 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 18:29 Stephen Hemminger [this message]
2018-01-16 22:48 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116102906.0df665b6@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).