From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 04D41A495 for ; Tue, 16 Jan 2018 12:13:39 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id 143so7501830wma.5 for ; Tue, 16 Jan 2018 03:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3g7phST6KaNC2GZf1+btHG8nQ87mzF1mbqZIOitpjhE=; b=fmQtHW4hheNSlKSFzwECpOn6RuJZLxtf0pUQ0MaYve8s90RMXtKnge1IpRJk8GJKJZ /aXWdfEuzlaczGPUpw5nHJWyqZAHtTDLaBC9pRSp6JoUCaqbMCoqrTXIwKGGzBlq1j0h 6h4NP/Djgb4WhCnfF6uAzxO/75z6jzlXviBDRrIWNYxcvbwUcu0W+vUcjtvMUxsYjhzu TBefKWelCTdofezclAXwZBcX3SSlD8NTzipvrvohEVlUpYXE+EkdkiL8TzHt91f6bZjU ya13LKWpIjkjxroSH6fpAmyPbWyc6qOswowsqvxs85Nwi2ZG9uE376a29J5SCZJvVNR9 LR8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3g7phST6KaNC2GZf1+btHG8nQ87mzF1mbqZIOitpjhE=; b=eDmK8yfSmGdJ8HBsJfilaD8sA4eQ9XWykBVf1/aAdBzVoFwFZri/gwSUH+0a/Y/cfg jBHa/EOifZm5PZaHLca5IP4rR0NDfN+3niNEQ3B3ksL1MePEDVbP4ouBiMH2lnlPodyM dxkgrSWAIop44VilpLYf2DVFUZDJU8Eb6dJT3MRwZ5DMgQZ3xmPM37ZkiWYZ12pg6uaU SsiNMr3niSWkgvvdCU0AnO5UyxEyO0d+n7I4s8sXQ7vdZ0zhsGQaIkpCcdwM8oO9S0W8 yxrlyegstnHeDVgH7NILV+AZKutSrXotAVyF/XYGuSlgIZBlg60lt4pYaRuBvnBiPDKL eRvQ== X-Gm-Message-State: AKwxytfkdmUL/H8Vj6kPl06uNcFFMhKBaOHhN+GcHTcBkDwQFTN2xdLj DP/PaoA+D8SV9hhaKXK7+pUvDQ== X-Google-Smtp-Source: ACJfBouugXp7GHMjZPHg04lchcpbfGbWOoP+Xg1kvk+5hiWdfkS1Tr8jH/wkTAxGhx+9GvOjVYP1ew== X-Received: by 10.80.181.85 with SMTP id z21mr18772178edd.150.1516101218750; Tue, 16 Jan 2018 03:13:38 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g21sm1438648edg.88.2018.01.16.03.13.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 03:13:38 -0800 (PST) Date: Tue, 16 Jan 2018 12:13:26 +0100 From: Adrien Mazarguil To: "Rybalchenko, Kirill" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "johndale@cisco.com" , "neescoba@cisco.com" , "nelio.laranjeiro@6wind.com" , "yskoh@mellanox.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Chilikin, Andrey" Message-ID: <20180116111326.GD4256@6wind.com> References: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> <20171204174304.GK4062@6wind.com> <696B43C21188DF4F9C9091AAE4789B824E2B6786@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2B6786@IRSMSX108.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 11:13:39 -0000 On Tue, Jan 09, 2018 at 03:16:13PM +0000, Rybalchenko, Kirill wrote: > > -----Original Message----- > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > Sent: Monday 4 December 2017 17:43 > > To: Rybalchenko, Kirill > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; johndale@cisco.com; neescoba@cisco.com; > > nelio.laranjeiro@6wind.com; yskoh@mellanox.com; Lu, Wenzhuo > > ; Ananyev, Konstantin > > ; Chilikin, Andrey > > > > Subject: Re: [PATCH] ethdev: increase flow type limit from 32 to 64 > > > > Hi Kirill, > > > > On Mon, Nov 27, 2017 at 12:29:47PM +0000, Kirill Rybalchenko wrote: > > > Increase the internal limit for flow types from 32 to 64 to support > > > future flow type extensions. > > > Change type of variables from uint32_t[] to uint64_t[]: > > > rte_eth_fdir_info.flow_types_mask > > > rte_eth_hash_global_conf.sym_hash_enable_mask > > > rte_eth_hash_global_conf.valid_bit_mask > > > > > > This modification affects the following components: > > > net/i40e > > > net/enic > > > net/mlx5 > > > net/ixgbe > > > app/testpmd > > > > > > Signed-off-by: Kirill Rybalchenko > > > > Can you elaborate a bit on the need for these changes? > > Have you considered implementing those future extensions through > > rte_flow instead? > > Hi Adrien, this is not a new feature but rather fix of existing limitation. > In current implementation the symmetric hash mask and flow mask are > represented by 32-bit variable, while hardware bitmask has 64 bits. > Unfortunately, this modification changes ABI of the library as it changes size > of rte_eth_fdir_info structure. All related PMDs (listed above) had to be modified > accordingly. OK, no problem with this change. I assume you'll re-submit it since you sent a deprecation notice, we'll review/ack subsequent mlx5 patches. -- Adrien Mazarguil 6WIND