From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v4 00/15] common ethdev linkstatus functions
Date: Tue, 16 Jan 2018 10:25:43 -0800 [thread overview]
Message-ID: <20180116182558.6254-1-stephen@networkplumber.org> (raw)
While reviewing drivers, noticed a lot of unnecessary
duplication of code in drivers for handling the eth_dev link status
information. While consolidating this, it also became obvious that
some drivers behave differently for no good reason.
It also was a good chance to introduce atomic exchange primitives
in EAL because there are other places using cmpset where not
necessary (such as bonding).
Mostly only compile tested only, don't have all of the hardware
available (except ixgbe and virtio) to test.
Note: the eth_dev_link_update function return value is inconsistent
across drivers. Should be changed to be void.
v4
- incorporate review feedback
- rename _rte_linkstatus to rte_linkstatus
- change return value of _rte_linkstatus
- optimize get on 64bit platforms
- change return value of rte_linkstatus_set
v3
- align rte_linkstatus_get with rte_atomic64_read
- virtio use ETH_SPEED_NUM_10G
- add net/
v2
- function names changed
- rebased to current master
Stephen Hemminger (15):
eal: introduce atomic exchange operation
ethdev: add linkstatus get/set helper functions
net/virtio: use eth_linkstatus_set
net/vmxnet3: use rte_eth_linkstatus_set
net/dpaa2: use rte_eth_linkstatus_set
net/nfp: use rte_eth_linkstatus functions
net/e1000: use rte_eth_linkstatus helpers
net/ixgbe: use rte_eth_linkstatus functions
net/sfc: use new rte_eth_linkstatus functions
net/i40e: use rte_eth_linkstatus functions
net/liquidio: use rte_eth_linkstatus_set
net/thunderx: use rte_eth_linkstatus_set
net/szedata: use _rte_eth_linkstatus_set
net/octeontx: use rte_eth_linkstatus_set
net/enic: use rte_eth_linkstatus_set
drivers/net/dpaa2/dpaa2_ethdev.c | 75 ++---------------
drivers/net/e1000/em_ethdev.c | 71 ++--------------
drivers/net/e1000/igb_ethdev.c | 70 ++--------------
drivers/net/enic/enic_ethdev.c | 5 +-
drivers/net/enic/enic_main.c | 17 ++--
drivers/net/i40e/i40e_ethdev.c | 43 ++--------
drivers/net/i40e/i40e_ethdev_vf.c | 18 +---
drivers/net/ixgbe/ixgbe_ethdev.c | 96 ++++------------------
drivers/net/liquidio/lio_ethdev.c | 53 ++----------
drivers/net/nfp/nfp_net.c | 77 ++---------------
drivers/net/octeontx/octeontx_ethdev.c | 17 +---
drivers/net/sfc/sfc_ethdev.c | 21 +----
drivers/net/sfc/sfc_ev.c | 20 +----
drivers/net/szedata2/rte_eth_szedata2.c | 19 ++---
drivers/net/thunderx/nicvf_ethdev.c | 18 +---
drivers/net/virtio/virtio_ethdev.c | 67 +++------------
drivers/net/vmxnet3/vmxnet3_ethdev.c | 86 ++++---------------
.../common/include/arch/x86/rte_atomic.h | 24 ++++++
.../common/include/arch/x86/rte_atomic_32.h | 12 +++
.../common/include/arch/x86/rte_atomic_64.h | 12 +++
lib/librte_eal/common/include/generic/rte_atomic.h | 78 ++++++++++++++++++
lib/librte_ether/rte_ethdev.c | 22 +----
lib/librte_ether/rte_ethdev.h | 62 ++++++++++++++
23 files changed, 304 insertions(+), 679 deletions(-)
--
2.15.1
next reply other threads:[~2018-01-16 18:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 18:25 Stephen Hemminger [this message]
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 05/15] net/dpaa2: " Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 09/15] net/sfc: use new " Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 10/15] net/i40e: use " Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 12/15] net/thunderx: " Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 15/15] net/enic: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116182558.6254-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).