From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 146C61B393 for ; Tue, 16 Jan 2018 19:26:20 +0100 (CET) Received: by mail-pg0-f68.google.com with SMTP id m20so9890777pgc.11 for ; Tue, 16 Jan 2018 10:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w0ZfWX2gAb176R6FQUmUmmU72ko3PVuiIPsh56sGRVs=; b=fScBUtGt0by/muiQs+HcrS973M5Sr1rCWlol0KU3kpZ2RuQW4IEjRLFxQbkQmv3xja zH6ic547at+NIyXjFzykpiGLwxIsHLJRhyAq+eRNsyf0I/sAfabAVzreyr2HM4g4pUsE U0BXWG7uEXi0YGKMZzWBkyyVWnjR9qFkKg+WVXMNuGRGzolUNJ5hCiUSPS+gJbRTwAAK tLnoIuhzG//+v9K9HlSNN11wPFwalZyn5iCTz+RnpgxVKDcqFBvJ8Rzewd0QF1/vtzrU dcysLeO7pCDbQMoQ268SXygMbiLsCGiYSrH6o5IRCsI8sZsuNNR6BiGEiCqLSPVjSON7 vOYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w0ZfWX2gAb176R6FQUmUmmU72ko3PVuiIPsh56sGRVs=; b=LLhrKz/WHaZ531p9bf1asixZHWZF7wdn3Ik7lz+jfiv9WUpjpD0jd5YjN6hZeT05gd lfLqBID9eppy64HtOx9VANkkpVCUgkpLgLikm3ZAvbX/De0jzT2vuk1yK5MwTAfi6BS8 GsM/1cZCoxOWl126lDH7vUp1QNZtMRhzo9YV3RZngjVWI5hIMYKzpWyAw1iPeqYV+uoQ y1LWNREYvfE6X/WhGmbWj+cuEX4lJQj/r691f4wGCtQXMLJYtlaqXf5UN6pWmwF1jEeU +cr3Og/JhHXr2nAkg/yGRlYMnrInPXq6G7xXLBNQlyfNEmKFZJz0hKrD7QtJDU8Ipq96 77HA== X-Gm-Message-State: AKwxyteZtZKXMeNH9vdnN2aNI/DPtAUSJTLzetHSumPlUyAEQos3XkzA ai6yZeqfHyjPbGRgcdPBzzDGqLpKqaU= X-Google-Smtp-Source: ACJfBovymrnezMzO8IWpnLDX++VfqrXS+oGcC0GFYQDGDVZvE3p51qaEEf6HDUMS0HrPqy9q7zhI1Q== X-Received: by 10.101.96.6 with SMTP id m6mr6253785pgu.131.1516127178935; Tue, 16 Jan 2018 10:26:18 -0800 (PST) Received: from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id x17sm3940497pge.50.2018.01.16.10.26.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 10:26:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 16 Jan 2018 10:25:56 -0800 Message-Id: <20180116182558.6254-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180116182558.6254-1-stephen@networkplumber.org> References: <20180116182558.6254-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH v4 13/15] net/szedata: use _rte_eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 18:26:20 -0000 Yet another driver which was not returing correct value on link change. Since this driver can't be built on x86 could not even do a compile test. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c index 74f151c4ad8e..c902e29d8ff2 100644 --- a/drivers/net/szedata2/rte_eth_szedata2.c +++ b/drivers/net/szedata2/rte_eth_szedata2.c @@ -50,7 +50,6 @@ #include #include #include -#include #include "rte_eth_szedata2.h" #include "szedata2_iobuf.h" @@ -1173,14 +1172,15 @@ static int eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) { - struct rte_eth_link link; - struct rte_eth_link *link_ptr = &link; - struct rte_eth_link *dev_link = &dev->data->dev_link; struct pmd_internals *internals = (struct pmd_internals *) dev->data->dev_private; const volatile struct szedata2_ibuf *ibuf; uint32_t i; bool link_is_up = false; + struct rte_eth_link link = { + .link_duplex = ETH_LINK_FULL_DUPLEX, + .link_autoneg = ETH_LINK_SPEED_FIXED, + }; switch (get_link_speed(internals)) { case SZEDATA2_LINK_SPEED_10G: @@ -1197,9 +1197,6 @@ eth_link_update(struct rte_eth_dev *dev, break; } - /* szedata2 uses only full duplex */ - link.link_duplex = ETH_LINK_FULL_DUPLEX; - for (i = 0; i < szedata2_ibuf_count; i++) { ibuf = ibuf_ptr_by_index(internals->pci_rsc, i); /* @@ -1212,13 +1209,9 @@ eth_link_update(struct rte_eth_dev *dev, } } - link.link_status = (link_is_up) ? ETH_LINK_UP : ETH_LINK_DOWN; - - link.link_autoneg = ETH_LINK_SPEED_FIXED; - - rte_atomic64_cmpset((uint64_t *)dev_link, *(uint64_t *)dev_link, - *(uint64_t *)link_ptr); + link.link_status = link_is_up ? ETH_LINK_UP : ETH_LINK_DOWN; + rte_eth_linkstatus_set(dev, &link); return 0; } -- 2.15.1