From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 637F91B373 for ; Tue, 16 Jan 2018 19:38:10 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id y5so10156747pff.13 for ; Tue, 16 Jan 2018 10:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR0V1AUa7cLLWnF6idqOuMz6+pNa43U8efZDnn6MeLE=; b=Y0Mkp6MN908j1A1XtHHpZarUNqCUDVv+lt/4IBYMBJz967tq3+k8CUCvj48R7Bl3wW wxZ1LmOpm67XJCF0le0wOVeN5lZZ0G8YUSgnaL2t7mP8Kc5CLl6416Z8u6vZ1t8+EPTe RRbcXI5LHgYcVpk3Njj2nB8VzEDl8a+I4U6VvHHnR/yGvujmP/eJeKOhPToRj8IpP3Yf pnwnAUmggSjSR/IyrIVR1ygHJJqWU6ST1bSCNwugnhKDUBdDpG63Ys9rTXIZ+hzIh+Lm ZiAjZfWGKeYmbzJPHBgm9WA3422qNbmH80fW0aE6nj0fDAnYcKRDVRLRRsnAvH7crFJf oXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR0V1AUa7cLLWnF6idqOuMz6+pNa43U8efZDnn6MeLE=; b=ah1Oaw25DNAV2J1zXM+oWVeDrOWuhHlkPajY7XuxnTGbAxB27ULb/7llRrwEjdLN+S FRv6GtYUfsH+CpxsIclEZySqCX9DKxwHfKga6aHmIXpil4PTJnEJDbeuJw/efPDRsHdL TJnEbZKUhY7yCzm5cBPaRfMnrCiE0ipLW+jyguzoDTuVgeWrCWjuJuDKNELq6zj9vZCB HiEULWPRdtPYkTNBhFl6U42H9aoIPx6I0tZkD1elzWP84flCdmHMsC4fZDquAHinHreU WzuRd572IZVDUkAYcF1DH6SgFXYaHIPyJq4ieAk48CRJeN7aqw8BVJPpM3DdLzGpZaaa eYNg== X-Gm-Message-State: AKwxyteRhhz9tefUTrIqWBIr2VcbPrUOBRQPGlLmTxAYSNT5NjlOeC1D PwW2zbTeGkqfDl/JcZmkQ/N5t9OwclM= X-Google-Smtp-Source: ACJfBotNBS4nOsB039WC8YDD/mQQShPeSxH8kovLUEG+hipJuwA36WfVwna/zWqUhYkQ+88aZmDnRA== X-Received: by 10.98.55.3 with SMTP id e3mr4037451pfa.119.1516127889239; Tue, 16 Jan 2018 10:38:09 -0800 (PST) Received: from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id 77sm4560351pfc.187.2018.01.16.10.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jan 2018 10:38:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 16 Jan 2018 10:37:45 -0800 Message-Id: <20180116183755.24542-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180116183755.24542-1-stephen@networkplumber.org> References: <20180116183755.24542-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH v5 05/15] net/dpaa2: use rte_eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 18:38:10 -0000 Use new helper function to update the link status. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 75 ++++------------------------------------ 1 file changed, 7 insertions(+), 68 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2f99d95d2216..c2aed380e408 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -56,58 +56,6 @@ static int dpaa2_dev_set_link_up(struct rte_eth_dev *dev); static int dpaa2_dev_set_link_down(struct rte_eth_dev *dev); static int dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); -/** - * Atomically reads the link status information from global - * structure rte_eth_dev. - * - * @param dev - * - Pointer to the structure rte_eth_dev to read from. - * - Pointer to the buffer to be saved with the link status. - * - * @return - * - On success, zero. - * - On failure, negative value. - */ -static inline int -dpaa2_dev_atomic_read_link_status(struct rte_eth_dev *dev, - struct rte_eth_link *link) -{ - struct rte_eth_link *dst = link; - struct rte_eth_link *src = &dev->data->dev_link; - - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, - *(uint64_t *)src) == 0) - return -1; - - return 0; -} - -/** - * Atomically writes the link status information into global - * structure rte_eth_dev. - * - * @param dev - * - Pointer to the structure rte_eth_dev to read from. - * - Pointer to the buffer to be saved with the link status. - * - * @return - * - On success, zero. - * - On failure, negative value. - */ -static inline int -dpaa2_dev_atomic_write_link_status(struct rte_eth_dev *dev, - struct rte_eth_link *link) -{ - struct rte_eth_link *dst = &dev->data->dev_link; - struct rte_eth_link *src = link; - - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, - *(uint64_t *)src) == 0) - return -1; - - return 0; -} - static int dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) { @@ -804,7 +752,7 @@ dpaa2_dev_stop(struct rte_eth_dev *dev) /* clear the recorded link status */ memset(&link, 0, sizeof(link)); - dpaa2_dev_atomic_write_link_status(dev, &link); + _rte_eth_link_write(dev, &link); } static void @@ -836,7 +784,7 @@ dpaa2_dev_close(struct rte_eth_dev *dev) } memset(&link, 0, sizeof(link)); - dpaa2_dev_atomic_write_link_status(dev, &link); + _rte_eth_link_write(dev, &link); } static void @@ -1284,15 +1232,13 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev, int ret; struct dpaa2_dev_priv *priv = dev->data->dev_private; struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw; - struct rte_eth_link link, old; + struct rte_eth_link link; struct dpni_link_state state = {0}; if (dpni == NULL) { RTE_LOG(ERR, PMD, "dpni is NULL\n"); return 0; } - memset(&old, 0, sizeof(old)); - dpaa2_dev_atomic_read_link_status(dev, &old); ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state); if (ret < 0) { @@ -1300,11 +1246,6 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev, return -1; } - if ((old.link_status == state.up) && (old.link_speed == state.rate)) { - RTE_LOG(DEBUG, PMD, "No change in status\n"); - return -1; - } - memset(&link, 0, sizeof(struct rte_eth_link)); link.link_status = state.up; link.link_speed = state.rate; @@ -1314,12 +1255,10 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev, else link.link_duplex = ETH_LINK_FULL_DUPLEX; - dpaa2_dev_atomic_write_link_status(dev, &link); - - if (link.link_status) - PMD_DRV_LOG(INFO, "Port %d Link is Up\n", dev->data->port_id); - else - PMD_DRV_LOG(INFO, "Port %d Link is Down", dev->data->port_id); + if (rte_eth_linkstatus_set(dev, &link)) { + PMD_DRV_LOG(INFO, "Port %d Link is %s\n", dev->data->port_id, + link.link_status ? "Up" : "Down"); + } return 0; } -- 2.15.1