From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 072AF1B28B for ; Thu, 18 Jan 2018 14:16:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 818E320E50; Thu, 18 Jan 2018 08:16:52 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 08:16:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=S9tPQqy2nqhlu8xwCYVUq7Ah6VQzPOIkC0+Kn9sf7QQ=; b=PSdP3F0h IoLMUINc8QZjK6V32E+/FCMAzHpHk9tW72/nD+M6McJySo0KpBPdna0HJpKLScUe i1YG7/Sho3RfMeAcYNWJMZ92YfJ0jWCVLYu6k4toti00fgE4fIdspYbluDRdvcJB jBlrpys+SVMByJPbdvzfsuxaKyJRIvyMoH/ajAunXswRf91qYO5VdLYCv9qGYAtO rY0bwJ9jCRL1gIy8vnUnbWHhO1ef5D7nf1ADkGI5mipNAtridrSPYvc6IWc5mZW/ u/IfC5f1n12Q3yC+1WR0CWmSrjD24YpSv10SSKRvmR5oMPa7Tn82qM7S2a0li/mg RaN+pExS0o4c0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=S9tPQqy2nqhlu8xwCYVUq7Ah6VQzP OIkC0+Kn9sf7QQ=; b=CegoX9vQEYNeiVtGK89GI29Vf+06IfujhxCP+sPseDQi4 lO3CxT5Tzgmjuf6xK0MPTa2YdNq2P78W25lB7EIjO+/zHK1XlNi1Gc3U7gf0TbBg FUW8xP6+nQ75xN4yDUNKfCyyH4FsGAoeZhVyXBeJPW9Agc6BurrW0fuHOPIC314P 5SZv9vySNt3y7Am9PLhyuD2tlK/Qut3TZ6FUXcljhFbjbHQQ2hkjDCGGFjwbi5ci WjOZKxC8RMdGH99x9U6GKFnaQ5GzG01nu/+dlj3LLE4W8sBRD5hSe7qkmFAVHEmY EpF0MIrf/m2RBRXg5oHUQY2lftfdnANEmGMrv3I5Q== X-ME-Sender: Received: from yliu-mob (unknown [115.148.90.22]) by mail.messagingengine.com (Postfix) with ESMTPA id 354DF7E3DF; Thu, 18 Jan 2018 08:16:50 -0500 (EST) Date: Thu, 18 Jan 2018 21:16:47 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: Junjie Chen , jianfen.tan@intel.com, dev@dpdk.org Message-ID: <20180118131647.GF29540@yliu-mob> References: <1516185726-31797-1-git-send-email-junjie.j.chen@intel.com> <1516203953-152604-1-git-send-email-junjie.j.chen@intel.com> <0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 13:16:53 -0000 On Thu, Jan 18, 2018 at 09:44:41AM +0100, Maxime Coquelin wrote: > > > On 01/17/2018 04:45 PM, Junjie Chen wrote: > >dequeue zero copy change buf_addr and buf_iova of mbuf, and return > >to mbuf pool without restore them, it breaks vm memory if others allocate > >mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova. > > > >Signed-off-by: Junjie Chen > >--- > >v2 changes: > >Remove useless restore > > lib/librte_vhost/virtio_net.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio, with below addings: Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Cc: stable@dpdk.org Thanks. --yliu