From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0050.outbound.protection.outlook.com [104.47.0.50]) by dpdk.org (Postfix) with ESMTP id 0A0791B2DA; Fri, 19 Jan 2018 08:53:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dlNE5sFsOKZXCdzGEJnWH0WT0d6mKhFLed8Mb0x4+Hs=; b=eD2KOGUzLSlJvyEUSrYU0AZbAopq9w5ZgOMDqZ/rLNTtWxUfcJfwgnhKoIA35QwE91vossc/NnCuuiO6xK4iOYal5Zapfe3XF/PAwG46mkRVm0M2+YRYgWME7pFY4soPLWFUNpRqhlvdIJcb+CFOQGOM9Rl4+xzly0jgHrXUsM0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Fri, 19 Jan 2018 07:53:24 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, xuemingl@mellanox.com, Yongseok Koh , stable@dpdk.org Date: Thu, 18 Jan 2018 23:52:55 -0800 Message-Id: <20180119075255.2542-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR0201CA0006.namprd02.prod.outlook.com (2603:10b6:301:74::19) To VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b57795cb-76d2-4913-ef37-08d55f11b8c1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:VI1PR0501MB2046; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 3:gFNM4MRcwqFMVbmeN9lTu/apTfqYWl+ee1pqfDJUJTEdhbr9PKdBsrIhVz2j2zLxVIqPajhevkKJrNZTAJ0UboDCpkb2g7kGj0ceWRX+FWvtO363WHAZf7xgJ7Xnv5mRx7pZFMiDjfvWaiMD2KKEl1s95bR6uHmht765QQ58Qj25ODBKwxbxwfV/8SNl0s4sIUE045Z1xnaNs50wK5dnv+ZMIoVQSAD7W4LUThUWYkyD39ogkwrLAEVFC20P0YIh; 25:3paFtjK8erXIlWdtVnSGEb0SnmxcA8qyCroH/J6o60AaxQNhfrlvkgrcwPxmZ49ez1QHvLBdr5tOi2iRoJzAa8vXccEQXSLnsKPWhDElJaoTwe8twI9A4FGWRF07ANzcBemiq/6wC2gvys+74jNOOEEz70sWl/W4QrFqLtBqBRDKRtPnNb9J2iBN4wEwbgTGReti2Y8z/WTc4H6N7dVb/2ulU+cqgcrdpRCmU7LfcrKo/deSnhyyo0ieB6wzMkJEBJBv7yFtfdpdHQwrx44pAgiua50LhqflI+pI8ZSEQ8RoHWjdf4hqNpV8r79htSaglTTxVpuAXwZ31Fmw/B4reA==; 31:zJ70CAZ8dFbZlczvDAqiA4ljvD7LiR8ea4Pe3y22LN/vDScPukmiV3Qrd35sWZDF3BoFzmrcKruP2IZjq4dYk2KprSP8dIrYpFbHiuDlt4KmSj/FkR062NtrYgLRDLUBp1YO9QPIZarC6ovr5Z8GfoBsnAQtGzxhSvQyUH9wtzRZ7WWYzF643+VrG1EeEP1PFSEbKypZbE4rdW3+4uXn3kl6kmCJDXuRheBF9DicbzU= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2046: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 20:ClWapNNFZ2/N1bYpRXNaACBuX+UgilQr0glGWkliMS/2fORx7ZWwN41K12UQDU8KkqeGPbAktWKhBZ8XeqZ8CMT+A3yAtf3xGiPJaWety5JGsqAhPLwbHU0/12hk6DaBFvQGPyzVHbcgyV+G7ag87AYfK6DMp/+FxJKYPFi4ooa2QYdEhyqnq3jKKPc44KioIDQMe/jS7pvxovJLFGdZEYbXbGd5OjbwGD6HneZv6jgqJfyB8UwVA24H0+UtuMZ0oSlNPIMjqmgiAfllqIx0IBhRZdYMqcthg6EZtWceXy/O5NJm+rbfA6Vzlc+4aPJWP/9aX1mtJZOYBeW1AdV1RZDfWBxsgNJnG8IKnKNFCbZJdPJHosO3H22iv2zV9E641tMjzZackoea/54JjC1u9lqwx+OsRtc5DI9qvcQFy/EJjHqpIwGIuxQi2lARUdKIXBy6HXWAE6mqqxpVDmpbIUPYVTRMwqfUnfM5AWshm+w/QGVR7z2imYtMChIslZA0; 4:SiBuhmngnNW/GP1bSnB8ADG8x0y0DYSZcJXK53U5uq6jXR2/r2SkKQxKmLvG5RQ7mP9rZQ4PGAYAffZTDIF12+CxDO8HBkcJl0xOgMDnb2KP1ADkIsNREbbvbcibntQXt30oA4883e4g4XBvYICESuJHwM+FQjXpPKzrujnJ4DfNylsJNnE7YYPd3t1SDg9b2VuP8Po5fZ867tZLxxRfs403dVrPwlNXikWmyNDAzA2DLF5+n2memLKJgVYioXSLYdiJMMYovtySgrBbP2BN5A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501161)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB2046; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2046; X-Forefront-PRVS: 0557CBAD84 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39380400002)(366004)(39860400002)(199004)(189003)(50466002)(16526018)(86362001)(575784001)(6666003)(25786009)(5660300001)(7736002)(50226002)(2906002)(48376002)(478600001)(8936002)(6116002)(21086003)(316002)(16586007)(52116002)(8676002)(97736004)(81166006)(69596002)(305945005)(59450400001)(105586002)(386003)(3846002)(81156014)(106356001)(26005)(36756003)(53936002)(4326008)(51416003)(7696005)(55016002)(66066001)(47776003)(1076002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2046; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2046; 23:hmomEWkri4iuv6XW50Rg4yNcvqd81BAEpjsE7q1?= =?us-ascii?Q?LSNUNyzcivU7vZDpT4UZeo39S5G5QXxlpdkQj0Z92H73rEAH+r/+Arb/nLKj?= =?us-ascii?Q?OYLbC0KrUSS52CjJg8H+KEVEhZ6jkZG1B3z2GlZnytKhmhLL6ttXzFSeh/xI?= =?us-ascii?Q?8pj+0y2A+tjxRWXfQog9jgFimh8wzpV4Z42IoBMW1Xm8iUIWn3QkqSZnR9o4?= =?us-ascii?Q?IONwVLCnggSsYvRZVts7Wo76Udwihib/Da2JU4YIF5sfD8LRCP/6m15KhTfr?= =?us-ascii?Q?d54LOBUBsnuBfQKRR3P2tKVPOXLS9huuDlZsGsNIOIjmH0BSpCyH9aMSUGgk?= =?us-ascii?Q?cx65mwZ0OhaHRRFCiJuZEAD/Js+rv8cqF+OErb7ci//V6/FSxjfJdhcWSs9B?= =?us-ascii?Q?QUB8cCZbqxyw5FeWiSPRVcsyE9bP6ZceZdXjXeC0BNlTXJkCQQIfbpEUVao9?= =?us-ascii?Q?Y8j8TmcsRiObrwb8r5QlV+xsVMyHrzQvmv9FtNK3CKDi8UT9vnMiAnRgSxKL?= =?us-ascii?Q?Q2PabQmnGUvhJeAyjvJkMxAQdAoXBkuaN4AFqxHvAidOsSvUzml5D1AKbcvU?= =?us-ascii?Q?iBwXDH42RMS1oBc4CAbkJYXtdJ8oczpAPK62Rjz4Mu60mXZmOx8m1ppNkMEj?= =?us-ascii?Q?ph3UN6L0ymA4kl7En9bmliqdNBPPbdJVfwhIqOQVH0F31mY1PcNA6cIj2zXu?= =?us-ascii?Q?o/PrjcPEx6lRmdWRZ5y0t6oaQynL5h9qIpgrh3x0WzfKj6e3fVUr4u2mlNZn?= =?us-ascii?Q?O1RcmFgoCOJIrqycEu17DYHRjK2ycNKjjtm4gKwS3RRjHWhAWsSDMcKdL0SY?= =?us-ascii?Q?XBXSryv5wkslzq2+7cffeJHiZrSd2vOV+m4BZiWn4/TXDi+sQe/7xsezXcio?= =?us-ascii?Q?1NqjZq1OjnyrM4a7JDNdN2xGS+VJQUJoHBQk/6j0DiE6KtKmERRmLTqlGNp0?= =?us-ascii?Q?oRp7jrqmVAzsaQ+G2omOo2/10cr9UWKanG8fSEZBl56EWPBTb2izpf08Ip/v?= =?us-ascii?Q?mcpVGMvlUTItRuHin4KlsobNWITX6JSNqqBRqOxnIfNlsRCsg9GqljUFqDKn?= =?us-ascii?Q?Z4p0Sr9uL7prg1f89Ozq0JiMYalTmKXwae0vIikcoG+WbWUnavGx77D17MeH?= =?us-ascii?Q?sFR7w9/Ob/a0=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 6:XglUiS0OCInn91pfP3vNBdHMjU8mGI14pJT2WtggnpI5Zegm47Y86eaAiGoCDaA4mD923QeZoyMT8jSpM1eDTBx6uPRl+Sj71wdLIdFnMvHUZ8YlDkj4aAUtjTsD+E0IHVHB5Tvf7QlhXfAExnDl96v14nBKuhXTG50oQYaIa5aKA8SQoD6smHfMtxA+aIbeGOtuY06Gcn3rC/18H3kRdXRf3J6BRckKTHu5frPgG5zLgpRoSQ23W0Qk5lA77M3pa0/AgE16wASMvwACaJIBkCgU+C+smAVyLw0TK7LEHb+y2X7640hNcsxjcwOZMfVr5Z4jDfJQWeXDC8rJ3fI2qzF8DTKBgs1m3IR8Rc3pl7E=; 5:vdUphr/yFQ4NhsHcZw5BV4FHdFii46i1yA4qhD7bvXXLM6ClcmoLzAoj3tzSN52GPnTHib0/4TwjPgLVTGwL+Dn3ZO4VND5B6y9Aekb14Y++oDPMi5sk+oXIY442n27nK7p+q5PVbG1fgxRZKC3Rtx4XLNW8F7k+q9O+ddnR7cM=; 24:F8Vx+f9eoMLn4Pl11SKyzIk7nvDMKb7tZW0x3VKSmZ+J8UsrrBir37S/BqJbGDpiLWHZV8di65EpQmypJl+ebqGHOJDf7+aAC5jDx2ZXVw4=; 7:3OezPP/ml7QxkmLeQy/mRF8FjRbpHrI/5CGxS+poPVabgkk8HDnQHGemBiCaKaO8VsMmitLcilDkBLbd6DYpFfgXjWdP7DdX1DAwLRWyG35yEbeA9QuJuL3ZV+onj24P1NlDgJD0ifxOl7zzNerIOyoSg03ZVHTsl2pnq0o+NE/EzvkSL2S9jYb8MvjL4CYP2J7EMK0eTtTlq/Cu9Yx+rV/5JgvgCy3KwrrgDzMf0iG2Amns0dSYgellkJfEhaVD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2018 07:53:24.6749 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b57795cb-76d2-4913-ef37-08d55f11b8c1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2046 Subject: [dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 07:53:29 -0000 This patch reverts: commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") Although granularity of chunks in a mempool is a cacheline, addresses are extended to align to page boundary for performance reason in device when registering a MR (Memory Region). This could make some regions overlap, then can cause Tx completion error due to incorrect LKEY search. If the error occurs, the Tx queue will get stuck. It is because buffer address is compared against aligned addresses for Memory Region. Saving original addresses of mempool for comparison doesn't create any overlap. Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search") Fixes: 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") Cc: stable@dpdk.org Reported-by: Xueming Li Signed-off-by: Xueming Li Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_mr.c | 5 +++-- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index 6b29eed55..2776dc700 100644 --- a/drivers/net/mlx5/mlx5_mr.c +++ b/drivers/net/mlx5/mlx5_mr.c @@ -291,6 +291,9 @@ priv_mr_new(struct priv *priv, struct rte_mempool *mp) DEBUG("mempool %p area start=%p end=%p size=%zu", (void *)mp, (void *)start, (void *)end, (size_t)(end - start)); + /* Save original addresses for exact MR lookup. */ + mr->start = start; + mr->end = end; /* Round start and end to page boundary if found in memory segments. */ for (i = 0; (i < RTE_MAX_MEMSEG) && (ms[i].addr != NULL); ++i) { uintptr_t addr = (uintptr_t)ms[i].addr; @@ -309,8 +312,6 @@ priv_mr_new(struct priv *priv, struct rte_mempool *mp) IBV_ACCESS_LOCAL_WRITE); mr->mp = mp; mr->lkey = rte_cpu_to_be_32(mr->mr->lkey); - mr->start = start; - mr->end = (uintptr_t)mr->mr->addr + mr->mr->length; rte_atomic32_inc(&mr->refcnt); DEBUG("%p: new Memory Region %p refcnt: %d", (void *)priv, (void *)mr, rte_atomic32_read(&mr->refcnt)); diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index a239642ac..2eb2f0506 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -548,7 +548,7 @@ static __rte_always_inline uint32_t mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) { uint16_t i = txq->mr_cache_idx; - uintptr_t addr = rte_pktmbuf_mtod_offset(mb, uintptr_t, DATA_LEN(mb)); + uintptr_t addr = rte_pktmbuf_mtod(mb, uintptr_t); struct mlx5_mr *mr; assert(i < RTE_DIM(txq->mp2mr)); -- 2.11.0