From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, xuemingl@mellanox.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup
Date: Fri, 19 Jan 2018 09:37:09 +0100 [thread overview]
Message-ID: <20180119083709.p7p5p6xmlqp6eh6x@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180119075255.2542-1-yskoh@mellanox.com>
On Thu, Jan 18, 2018 at 11:52:55PM -0800, Yongseok Koh wrote:
> This patch reverts:
> commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration")
>
> Although granularity of chunks in a mempool is a cacheline, addresses are
> extended to align to page boundary for performance reason in device when
> registering a MR (Memory Region). This could make some regions overlap,
> then can cause Tx completion error due to incorrect LKEY search. If the
> error occurs, the Tx queue will get stuck. It is because buffer address is
> compared against aligned addresses for Memory Region. Saving original
> addresses of mempool for comparison doesn't create any overlap.
>
> Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search")
> Fixes: 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration")
> Cc: stable@dpdk.org
>
> Reported-by: Xueming Li <xuemingl@mellanox.com>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-01-19 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 7:52 Yongseok Koh
2018-01-19 8:37 ` Nélio Laranjeiro [this message]
2018-01-21 6:37 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119083709.p7p5p6xmlqp6eh6x@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xuemingl@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).