From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 7E1071B2BF for ; Fri, 19 Jan 2018 09:37:21 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id v123so1831127wmd.5 for ; Fri, 19 Jan 2018 00:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=O3OOK+/tuj4QvgfN90mrPJvhEdYqrpxPuwX3+cKN1lI=; b=Pfo8pYWbprc6zCEgFMGTIuTugXYVav7wa9ImXGwehxzJAK21NxFKkRY8vYhC9oa/MO 6YizKtITv2AZwGMNG6xyw4dLzAAU9+b8e4Ca69dctMkFFV3wTDN1/Q8yqtI1jSHRXIAV HGRPYp7rOlDVXgyte+UcLqyz8OGWHo7ey1kY3zryX3NSZOtqsKRKJl5bVSiEdpbeheGb bVRnaTHxEslPduq3SndEnxUK9IyM0jhXBm2AuSqFd4VkauJHuW/D7gZviNTVOJ/l/2TF f7vt9l7/nloyn+aCuzlNm16QBnN5fiPHHCPAub9Cf4h7W6XLAf4V340p5JUCQTNx/o4X KVDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=O3OOK+/tuj4QvgfN90mrPJvhEdYqrpxPuwX3+cKN1lI=; b=Iyip2KgdHNEKzLcIaUJm8pk7Ngzlv/yyOHbE7bSBex3WiptkMf9VYbG2GeEfDqTk+A OXikpwIhQFC1OjjpK3RAzdfm1g/yaemnUfFm9oOwcDXjJ1o0671lDvJjvblmPoFvb7of 2RR5qOeL8f0kWDhoqfbIE70OoQLCTOMCS5jytzCl/5X0bs7QfcRPJfZPPC3ucfqurUwR P60WjTnkA28/IBswZBHiCWpvwmj3YsSbviXADWfZxGFy0n05DBmR/pTqbr16XDvVVhBB JQcSDUG/yDOQgEzHx1KS7FDPVyv3DBmA+MeNXc45gj+EMuDMX9vTmW4YZogsnT1Q5T3O Z/RA== X-Gm-Message-State: AKwxytczJU/6htBVVXnirJV/QrZvKLW5ybiRo5Q/w3wM6WC4O0H8tfi8 cwTJjmRGOl02yp77Tfcj6aQi X-Google-Smtp-Source: ACJfBosZOtT7qkmzBvPCe02uoToQugrUMmqPeMByF2EoqY1yQxD2rrzPq6TyyonV3yk4VH7gJEIU0Q== X-Received: by 10.80.175.162 with SMTP id h31mr2313491edd.48.1516351041118; Fri, 19 Jan 2018 00:37:21 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u4sm4263705edc.91.2018.01.19.00.37.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jan 2018 00:37:20 -0800 (PST) Date: Fri, 19 Jan 2018 09:37:09 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, xuemingl@mellanox.com, stable@dpdk.org Message-ID: <20180119083709.p7p5p6xmlqp6eh6x@laranjeiro-vm.dev.6wind.com> References: <20180119075255.2542-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180119075255.2542-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 08:37:21 -0000 On Thu, Jan 18, 2018 at 11:52:55PM -0800, Yongseok Koh wrote: > This patch reverts: > commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") > > Although granularity of chunks in a mempool is a cacheline, addresses are > extended to align to page boundary for performance reason in device when > registering a MR (Memory Region). This could make some regions overlap, > then can cause Tx completion error due to incorrect LKEY search. If the > error occurs, the Tx queue will get stuck. It is because buffer address is > compared against aligned addresses for Memory Region. Saving original > addresses of mempool for comparison doesn't create any overlap. > > Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search") > Fixes: 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") > Cc: stable@dpdk.org > > Reported-by: Xueming Li > Signed-off-by: Xueming Li > Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND