From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 3886C1B29D; Fri, 19 Jan 2018 14:30:48 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ecWkt-0001YA-CO; Fri, 19 Jan 2018 14:30:52 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 19 Jan 2018 14:30:45 +0100 Date: Fri, 19 Jan 2018 14:30:45 +0100 From: Olivier Matz To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Cc: dev@dpdk.org, Adrien Mazarguil , Yongseok Koh , stable@dpdk.org Message-ID: <20180119133045.2skvdjis6yxk3bet@platinum> References: <20180118130043.31773-1-olivier.matz@6wind.com> <20180118160427.4fokyhq7koux6ga6@laranjeiro-vm.dev.6wind.com> <20180118161308.26ssahokrsu4e2rn@platinum> <20180119083501.osf4rnd4y4lwujwn@laranjeiro-vm.dev.6wind.com> <20180119084314.uvjbhtveuq7wfpj3@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180119084314.uvjbhtveuq7wfpj3@platinum> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 13:30:48 -0000 On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote: > On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote: > > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > > > > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > > > > > On error, mlx5_dev_start() does not return a negative value > > > > > as it is supposed to do. The consequence is that the application > > > > > (ex: testpmd) does not notice that the port is not started > > > > > and begins the rxtx on an uninitialized port, which crashes. > > > > > > > > > > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Olivier Matz > > > > > --- > > > > > drivers/net/mlx5/mlx5_trigger.c | 4 +++- > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c > > > > > index 1a20967a2..44f702daa 100644 > > > > > --- a/drivers/net/mlx5/mlx5_trigger.c > > > > > +++ b/drivers/net/mlx5/mlx5_trigger.c > > > > > @@ -166,6 +166,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) > > > > > ERROR("%p: an error occurred while configuring control flows:" > > > > > " %s", > > > > > (void *)priv, strerror(err)); > > > > > + err = -err; > > > > > goto error; > > > > > } > > > > > err = priv_flow_start(priv, &priv->flows); > > > > > @@ -173,6 +174,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) > > > > > ERROR("%p: an error occurred while configuring flows:" > > > > > " %s", > > > > > (void *)priv, strerror(err)); > > > > > + err = -err; > > > > > goto error; > > > > > } > > > > > err = priv_rx_intr_vec_enable(priv); > > > > > @@ -196,7 +198,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) > > > > > priv_rxq_stop(priv); > > > > > priv_flow_delete_drop_queue(priv); > > > > > priv_unlock(priv); > > > > > - return -err; > > > > > + return err; > > > > > } > > > > > > > > > > /** > > > > > > > > err in the function is handled with positives errno's, adding only those > > > > two and returning err will make the other positive. > > > > > > I tried to check the return value of all functions called by mlx5_dev_start() > > > (negative or positive). Do you see something wrong? > > > > What I mean is priv_flow_start() is returning a positive errno as all > > other functions priv_*() that's the main reason for the final rteurn -err; priv_txq_start(priv); -> negative on error priv_rxq_start(priv); -> negative on error priv_dev_traffic_enable(priv, dev); -> positive (+errno) on error priv_flow_start(priv, &priv->flows); -> positive (+errno) on error priv_rx_intr_vec_enable(priv); -> negative (-1 or -errno) on error > > Internally MLX5 driver only works with positives errnos as lot of them > > are retuning the values from ioctl directly. Only the public ones are > > returning negatives. > > So, what should I modify in this patch for v2? > Do you agree that there is a bug regarding the return value of mlx5_dev_start()? > > It can be reproduced easily by starting testpmd on a dual-socket machine, > use the core and memory from socket 0, and have the mlx device on socket 1. > Then start traffic forwarding, it will crash.