From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4F1841B341 for ; Fri, 19 Jan 2018 15:42:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B16322083A; Fri, 19 Jan 2018 09:42:58 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 19 Jan 2018 09:42:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=yzGGgksSuzhsDwU/BN9/2/lA0wy1odl/maCWl2S/rMw=; b=iB9RgU3Q qr0CTM5ILMNE3mCC9dph7uBvGY7NAB4n1424xt6DIzYpubIwbeiX2dacOEbyPLPx tRLlUhJai8kdOvhxBygMUhixQ9gsgDT2A05xkoO1P/W707IxgtE7BkIde1B91r+W 0sYb0gEQ6aOobxVoI0BQ1DAbsG0brdxYmYeAO6ikQUsAw/a+DWbVy6iA8mqP7NPm gK0XtNtr0twsTueGXtm/jGuLzFjHeEpQaq/a1Bmi6iBKDhsmZn+U8xyAwmVGQed1 ZipHjSdRI4bCtqM5hyRJzMYDeuj8j4Hw9yjk1H7P3EybnYRe4uqblyxkoK0eByts zqYd/ktTtdV5yg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=yzGGgksSuzhsDwU/BN9/2/lA0wy1o dl/maCWl2S/rMw=; b=qMbxKKRlNZCjVt7EUVcP/pSkSINXNJuSxyjlQFL4Ud7Uj jSsUMR6zgbm/VMHflDTTtySq7z23e7hD3a9rC18p/OSWCxiFsNyHpOrTInWX7Y6i 0jaNNaUlupNKyFc/kzmIvFXpxOYWi9ni1aRXJHMJWsLPXaO+qryBgFlzX0xQCHJ8 mj3QpHQ3RXe2dJh1RfX6AjMX6FNjl/DQmJY9aUqbFZFuw2BOAsPKx3ImzM7RHcoi OdKlCSZE7kLaMm9mbx4DHY9xxFHrxjR8RpAp9qRhr24NAPo0kBk25u6ZC4PDlbl3 ZYMFVR3OekkOUuKLkG1CiigUEj8giKn2Y54K6t1Ww== X-ME-Sender: Received: from yliu-mob (unknown [115.148.90.22]) by mail.messagingengine.com (Postfix) with ESMTPA id 516F8240DE; Fri, 19 Jan 2018 09:42:56 -0500 (EST) Date: Fri, 19 Jan 2018 22:42:54 +0800 From: Yuanhan Liu To: Zhihong Wang Cc: dev@dpdk.org, jianfeng.tan@intel.com Message-ID: <20180119144254.GQ29540@yliu-mob> References: <1516388570-42634-1-git-send-email-zhihong.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516388570-42634-1-git-send-email-zhihong.wang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 14:42:59 -0000 On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > descriptor layouts. The vhost-user lib already supports it, but the > feature declaration is missing. This patch fixes the mismatch. I remembered there was a long discussion one year ago, that we can't blindly set this feature, as this flag is reserved (thus should not be set) for virtio 1.0. We should set it when v1.0 is not enabled. However, as you know, v1.0 is also enabled by default in DPDK vhost-user. --yliu > > Signed-off-by: Zhihong Wang > --- > lib/librte_vhost/vhost.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index b2bf0e8..57a9bea 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -170,6 +170,7 @@ struct vhost_msg { > > /* Features supported by this builtin vhost-user net driver. */ > #define VIRTIO_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ > + (1ULL << VIRTIO_F_ANY_LAYOUT) | \ > (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ > (1ULL << VIRTIO_NET_F_CTRL_RX) | \ > (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \ > -- > 2.7.5