From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5BFE91B2CA for ; Fri, 19 Jan 2018 18:16:34 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 09:16:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,382,1511856000"; d="scan'208";a="12474919" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by fmsmga002.fm.intel.com with SMTP; 19 Jan 2018 09:16:31 -0800 Received: by (sSMTP sendmail emulation); Fri, 19 Jan 2018 17:16:30 +0000 Date: Fri, 19 Jan 2018 17:16:30 +0000 From: Bruce Richardson To: Pavan Nikhilesh Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, dev@dpdk.org Message-ID: <20180119171630.GE16980@bricha3-MOBL3.ger.corp.intel.com> References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> <20180119131204.7391-1-pbhagavatula@caviumnetworks.com> <20180119131204.7391-2-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119131204.7391-2-pbhagavatula@caviumnetworks.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 17:16:34 -0000 On Fri, Jan 19, 2018 at 06:42:02PM +0530, Pavan Nikhilesh wrote: > Add Cavium octeontx and thunder nicvf to meson build infrastructure. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/net/meson.build | 3 ++- > drivers/net/octeontx/base/meson.build | 21 +++++++++++++++++++++ > drivers/net/octeontx/meson.build | 13 +++++++++++++ > drivers/net/thunderx/Makefile | 2 +- > drivers/net/thunderx/base/meson.build | 14 ++++++++++++++ > drivers/net/thunderx/meson.build | 14 ++++++++++++++ > ...cvf_version.map => rte_pmd_thunderx_version.map} | 0 > 7 files changed, 65 insertions(+), 2 deletions(-) > create mode 100644 drivers/net/octeontx/base/meson.build > create mode 100644 drivers/net/octeontx/meson.build > create mode 100644 drivers/net/thunderx/base/meson.build > create mode 100644 drivers/net/thunderx/meson.build > rename drivers/net/thunderx/{rte_pmd_thunderx_nicvf_version.map => rte_pmd_thunderx_version.map} (100%) > > diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build > new file mode 100644 > index 000000000..7333738de > --- /dev/null > +++ b/drivers/net/thunderx/meson.build > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2017 Cavium, Inc > + > +subdir('base') > +objs = [base_objs] > + > +sources = files('nicvf_rxtx.c', > + 'nicvf_ethdev.c', > + 'nicvf_svf.c' > + ) > + > +cflags += '-fno-prefetch-loop-arrays' > + This flag doesn't work with clang (at least with 5.0.0), so needs to be: if cc.has_argument('-fno-prefetch-loop-arrays') cflags += '-fno-prefetch-loop-arrays' endif I'm also getting errors with gcc builds due to maybe-uninitialized variables, so I also had to add: if cc.has_argument('-Wno-maybe-uninitialized') cflags += '-Wno-maybe-uninitialized' endif Regards, /Bruce