From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 51AC2A48F for ; Sun, 21 Jan 2018 18:35:01 +0100 (CET) Received: by mail-pf0-f193.google.com with SMTP id 23so5261370pfp.3 for ; Sun, 21 Jan 2018 09:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=avJbRyCfr7poIisTN5cROO+uTRRkufOGH5jwC3Yi9b0=; b=cf+v/xulBwdqTkQmx03mwykNuG3kowr8LjTB6JLVP5GovzQUrs2mP+jYUnI8I162hJ f5qwF7si2LcW61VAuGTYcwtT3/Lr2OiPIsbCLalQ02PjVr609xweWa8fn7wss4ifxt/U H5tol1aiaUl5RTgO+NA2pe+VIUo19N4yz+tTkeXgHtAj8ZBXuQrruaMYS0dVPCQ2R7m0 Ap6PwtSdCO2uqk7EqPG0xRIpil13LeXz00yp5iu+NAwxYWIlJCvE4iURTX4fDHxIRJh0 QjKsIkimBJ+P2RGPMMabdfjSIDiLVeR0ahG18kIVyZD1nt5RRkay6nAUxVx5wmrfoiNQ xyvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=avJbRyCfr7poIisTN5cROO+uTRRkufOGH5jwC3Yi9b0=; b=t4fsUs5L9uFBR2G7zsmWszkW5dUkoYGYy8STmkZ7ALbuEKPwGl2FhHvqfKohxbeaPm PaPyC0LZiVrfbyJhJBvKfrzduyqKvwB86K6jiIm8fbPmgWrczZcU/Hg6nrrJlE8MoqhD MF/SA24KqxeZd2qPnARR0NkaDjxcqctO/XDR4jtWjfAurOsoFBYZLMdgehcTjw3Q0vky oI1L0QAV+ENbMMgjXvQdOmcPNoCCmReb155zWPAIjHVB3MM0gyJRXx8KCdjqNKv/uC8i UFs8L0REiAGkrEII/XxOpxTRPZLC1DPdqCl3iB18NnlLBVkIu1UAfcXTOgTdr5mEJWvE 8T0A== X-Gm-Message-State: AKwxytemBW+Rx62K3LeNFlPeSCdMrGi8YfP2dTXDTgKh8Syq0tFfbo0p 5fRlPLn0MyAPOdtxI/gBjBSkuA== X-Google-Smtp-Source: AH8x224AverP8ef3/eyRuPtETcqADvx3+CQOUjWfUrzju9FiOT5YMqNKqKBkzYIX09HovENo5bb/0g== X-Received: by 10.99.191.78 with SMTP id i14mr5198757pgo.246.1516556100329; Sun, 21 Jan 2018 09:35:00 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id b6sm21515111pgc.2.2018.01.21.09.34.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Jan 2018 09:35:00 -0800 (PST) Date: Sun, 21 Jan 2018 09:34:58 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: "Patil, Harish" , "liang.j.ma@intel.com" , "peter.mccarthy@intel.com" , jerin.jacob@caviumnetworks.com, dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20180121093458.082f4589@xeon-e3> In-Reply-To: <20236883.VkVyGBRfOF@xps> References: <20236883.VkVyGBRfOF@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] Compilation errors in drivers/event/opdl/ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 17:35:01 -0000 On Sat, 20 Jan 2018 09:44:46 +0100 Thomas Monjalon wrote: > 20/01/2018 06:18, Patil, Harish: > > Hi, > >=20 > > I am seeing below compilation errors in drivers/event/opdl/, this is wi= th > > cloned latest DPDK (git clone http://dpdk.org/git/dpdk). > >=20 > > .. > > .. > > /home2/hpatil/e4/jan19-inbox-submit/dpdk/drivers/event/opdl/opdl_evdev_= xsta > > ts.c: In function =C3=A2=E2=82=AC=CB=9Copdl_xstats_get_names=C3=A2=E2= =82=AC=E2=84=A2: > > /home2/hpatil/e4/jan19-inbox-submit/dpdk/drivers/event/opdl/opdl_evdev_= xsta > > ts.c:89:2: error: =C3=A2=E2=82=AC=CB=9Cfor=C3=A2=E2=82=AC=E2=84=A2 loop= initial declarations are only allowed in > > C99 mode > > for (uint32_t j =3D 0; j < max_num_port_xstat; j++) { > > ^ =20 >=20 > My compiler does not raise this error. > What is your compiler? >=20 > Anyone to fix it QUICKLY please? today? >=20 > Harish, do you think we should revert if not fixed? Using declaration in for loop is a C++ thing which was inherited into C99. Does DPDK require C99 mode? Putting loop variables in for() looks better, but the rest of DPDK doesn't use that style.