From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 673A558C6 for ; Mon, 22 Jan 2018 17:54:06 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id n17so7511049pgf.10 for ; Mon, 22 Jan 2018 08:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bou0oQ9B6hoEXzlgZdUAHgmMxC+fWmhxgYJ1DQDflvo=; b=Z68cbPrvyZReopFHV1jfAVT8PW5zRdffyPrhPDwoIEdZJkqEhK8CdNevK7obGs8WFw 1fbRLY2CVKyAdrG+6iUGP7Jto+w46gvc3Z8wKy+LhEWKf3t8544Z1zLkJ08aBTlwh9CP FQlLdMOPMV5SgfjUrMqRwPg6U08HWo1m7K2faOQP16LXQGKkoBhtdfmJAQW35OAr/sj2 wFJZajhe46TXPMAoO41LUSWSwrF0AlD7vUy2nsHvZhg8RUbb5Itfr1Qrl2h7Ya6hKk4a SXwuKzE1LmhHMOrkNnwkwgmnU62dXfmT2X84GdEwDUbxTFW4Z8hLMloS9xhNc4wLG8Pd xOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bou0oQ9B6hoEXzlgZdUAHgmMxC+fWmhxgYJ1DQDflvo=; b=ZxqLzH9rdk5RoTrH9jMDLQThyDmrc+Mzpnq36LzAQKyHYKKTSwzyP8lQzEPoWG8dI9 KnA7pb4lZ0xw6SIjfF8SovSWd1KKoK7k9wbPWiS6B6pzU2wADYY17p5BvNmaNzCl6ndJ m1tPK+Xe+mTskzGbRl+fTcx59iC4ec2Ph6jzs0l9IzqyPaUxf0VX8kdPpgsA+Z2/CPhd 7OpIE8jg+MLJbHRykipOQZ6LpwUBUEJlKVsZAfDkhzsVfFKfjxhpKTCeF2WfUYNArdwC vR6YmNOyrnT936e5W21olpXNNvfIPHNYJhsd4mxLX4+NQ8niIS1JVQ7XGDUvhz6163cY +Hxg== X-Gm-Message-State: AKwxytciIfGTw8UCtGK14OyaJY2P6+5ZGAeptnJ//Dqfwfmk2wHb0czY HAWCB4MF+nZkfKztvfp3VVhTMg== X-Google-Smtp-Source: AH8x224D2CJsCrqVOn75su1v8RpJ4A2TDbbm0s4L9rezKUCFwfqXCz4J3hA78eTrsXOtISbasfdZPQ== X-Received: by 10.99.36.68 with SMTP id k65mr7676355pgk.345.1516640045502; Mon, 22 Jan 2018 08:54:05 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id c184sm1248777pfc.60.2018.01.22.08.54.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 08:54:05 -0800 (PST) Date: Mon, 22 Jan 2018 08:54:03 -0800 From: Stephen Hemminger To: Hemant Agrawal Cc: Olivier Matz , Jia He , "dev@dpdk.org" , "Thomas Monjalon" , Jerin Jacob , Jianbo Liu , Jan Viktorin , "konstantin.ananyev@intel.com" , Jia He Message-ID: <20180122085403.4de6d399@xeon-e3> In-Reply-To: References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-3-git-send-email-hejianet@gmail.com> <20180119163820.lk6mi6mjxaomb5nq@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 16:54:06 -0000 On Fri, 19 Jan 2018 16:47:36 +0000 Hemant Agrawal wrote: > Hi Olivier, > > > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: > > > Hi Jia, > > > > > > On 1/17/2018 9:33 AM, Jia He wrote: > > > > Move the common part of rte_ring.h into rte_ring_generic.h. > > > > Move the memory barrier part into update_tail(). > > > > > > > > No functional changes here. > > > > > > > > Signed-off-by: Jia He > > > > Suggested-by: Jerin Jacob > > > > Suggested-by: Ananyev Konstantin > > > > Acked-by: Jerin Jacob > > > > Acked-by: Olivier Matz > > > > --- > > > > diff --git a/lib/librte_ring/rte_ring_generic.h > > > > b/lib/librte_ring/rte_ring_generic.h > > > > new file mode 100644 > > > > index 0000000..01f2cae > > > > --- /dev/null > > > > +++ b/lib/librte_ring/rte_ring_generic.h > > > > @@ -0,0 +1,202 @@ > > > > +/*- > > > > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > > > > + * All rights reserved. > > > > + * > > > > + * SPDX-License-Identifier: BSD-3-Clause > > > > > > The SPDX should be first line. See other files for Intel or NXP. > > [Hemant] Don't add SPDX to this file. > This file is not BSD-3 licensed. Please keep the full text as in the original file. If it can't be BSD-3 licensed, then it needs to be removed. Mixing licenses is a real problem