DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-dev]  [PATCH] drivers/event: fix resource leak in selftest
Date: Mon, 22 Jan 2018 23:16:01 +0530	[thread overview]
Message-ID: <20180122174601.19217-1-pbhagavatula@caviumnetworks.com> (raw)

Free resources leak in eventdev selftests.

Coverity issue: 257044
Coverity issue: 257047
Coverity issue: 257009
Fixes: 9ef576176db0 ("test/eventdev: add octeontx multi queue and multi port")
Fixes: 3a17ff401f1e ("test/eventdev: add basic SW tests")
Fixes: 5e6eb5ccd788 ("event/sw: make test standalone")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 drivers/event/octeontx/ssovf_evdev_selftest.c | 4 +++-
 drivers/event/sw/sw_evdev_selftest.c          | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/event/octeontx/ssovf_evdev_selftest.c b/drivers/event/octeontx/ssovf_evdev_selftest.c
index 3866ba968..5e012a95a 100644
--- a/drivers/event/octeontx/ssovf_evdev_selftest.c
+++ b/drivers/event/octeontx/ssovf_evdev_selftest.c
@@ -624,8 +624,10 @@ launch_workers_and_wait(int (*master_worker)(void *),
 
 	ret = rte_event_dequeue_timeout_ticks(evdev,
 		rte_rand() % 10000000/* 10ms */, &dequeue_tmo_ticks);
-	if (ret)
+	if (ret) {
+		free(param);
 		return -1;
+	}
 
 	param[0].total_events = &atomic_total_events;
 	param[0].sched_type = sched_type;
diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c
index 8c2eef569..78d30e07a 100644
--- a/drivers/event/sw/sw_evdev_selftest.c
+++ b/drivers/event/sw/sw_evdev_selftest.c
@@ -3016,9 +3016,12 @@ static struct rte_mempool *eventdev_func_mempool;
 int
 test_sw_eventdev(void)
 {
-	struct test *t = malloc(sizeof(struct test));
+	struct test *t;
 	int ret;
 
+	t = malloc(sizeof(struct test));
+	if (t == NULL)
+		return -1;
 	/* manually initialize the op, older gcc's complain on static
 	 * initialization of struct elements that are a bitfield.
 	 */
@@ -3236,6 +3239,7 @@ test_sw_eventdev(void)
 	printf("SW Eventdev Selftest Successful.\n");
 	return 0;
 test_fail:
+	free(t);
 	printf("SW Eventdev Selftest Failed.\n");
 	return -1;
 }
-- 
2.16.0

             reply	other threads:[~2018-01-22 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 17:46 Pavan Nikhilesh [this message]
2018-01-23 14:17 ` Van Haaren, Harry
2018-01-24 18:01   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122174601.19217-1-pbhagavatula@caviumnetworks.com \
    --to=pbhagavatula@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).