From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id AE5E92BF4 for ; Tue, 23 Jan 2018 17:31:09 +0100 (CET) Received: from core.dev.6wind.com (unknown [10.0.0.1]) by proxy.6wind.com (Postfix) with ESMTPS id 9597812604E; Tue, 23 Jan 2018 17:29:21 +0100 (CET) Received: from [10.16.0.195] (helo=6wind.com) by core.dev.6wind.com with smtp (Exim 4.84_2) (envelope-from ) id 1ee1TN-00005r-OF; Tue, 23 Jan 2018 17:30:58 +0100 Received: by 6wind.com (sSMTP sendmail emulation); Tue, 23 Jan 2018 17:30:57 +0100 Date: Tue, 23 Jan 2018 17:30:57 +0100 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, Samuel Gauthier Message-ID: <20180123163057.lbrgzsjq2zbqh2xl@glumotte.dev.6wind.com> References: <20171214142411.25375-1-olivier.matz@6wind.com> <5295568.lEBEY0ou7Q@xps> <20171215104558.47nnc2nzmhbqndc6@platinum> <3286914.MMPEBl9nmj@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3286914.MMPEBl9nmj@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 16:31:09 -0000 Hi Thomas, On Fri, Dec 15, 2017 at 12:00:01PM +0100, Thomas Monjalon wrote: > 15/12/2017 11:45, Olivier MATZ: > > On Fri, Dec 15, 2017 at 11:32:12AM +0100, Thomas Monjalon wrote: > > > 15/12/2017 11:25, Olivier MATZ: > > > > On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote: > > > > > 14/12/2017 15:24, Olivier Matz: > > > > > > @@ -157,6 +157,8 @@ install-sdk: > > > > > > $(Q)cp -a $O/.config $(DESTDIR)$(targetdir) > > > > > > $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app > > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) > > > > > > + $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir)) > > > > > > + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir) > > > > > > $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) > > > > > > > > > > The libs are already installed with "make install-runtime". > > > > > Either we add a dependency between install-sdk and install-runtime, > > > > > or we clearly document it. > > > > > > > > To me, libs are needed when installing the sdk (to compile against them) > > > > and when installing the runtime (to use them). > > > > > > > > Is it a problem to have it in both targets? > > > > > > Yes it is a problem because the general use is to call every targets, > > > so the libs will be installed twice. Look at the global "install" target. > > > > > > Do you want to be able to install the SDK without the runtime? > > > > Hmm, you're right, installing the runtime instead of the sdk may be a > > solution in our case. We don't need the bin, man, ... but it's probably > > not an issue to have them anyway. > > > > So, to summarize: > > install-runtime is the equivalent of the binary package > > install-sdk is the equivalent of the -devel package > > Yes > > > And install-sdk depends on install-runtime, right? > > Depends logically, yes. But no dependence in the Makefile. Coming back on this topic, actually I think an issue remains with "make install-sdk" which generates a bad symlink. # ls -l /tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc drwxr-xr-x 2 root root 4096 Dec 11 11:49 app lrwxrwxrwx 1 root root 21 Dec 11 11:49 include -> ../../../include/dpdk lrwxrwxrwx 1 root root 12 Dec 11 11:49 lib -> ../../../lib # BAD LINK Would it make sense to remove the creation of the symlink? Something like this: --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -157,7 +157,6 @@ install-sdk: $(Q)cp -a $O/.config $(DESTDIR)$(targetdir) $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) - $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) install-doc: ifneq ($(wildcard $O/doc/html),) Thanks, Olivier