From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C57341B16F for ; Wed, 24 Jan 2018 16:24:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5CD0222359; Wed, 24 Jan 2018 10:24:36 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LHmdKKN9FqYLXfRLC 89xXie91o70TyjvmGDKJ4ed0Ec=; b=k3q6Hjt1TyRwHv6xyHAZmtfBn5/jyJNBi QeCwIrPoZIgWbZU5A5CjNZYK7jmpJqqpw5bkBWarxw1XtlNfMQom4Ik2cZfCKrfR 0rbes/Nn7WMO1quqOlmDYVh4k6RwnCtbIDcxu2NmQeH12Kcu1uc5e9OJbmVBzuVP CGIbxSmfaJKrqAy3SbZ7uz1uUCygUQRJKGofFYpd/vkllNxggJunkzXB7sNkHUgD s8TH/yl7/6orlWMAWg8gKFjubbIsXFyvaF8DZQ0ssSQ91IkEd4UdKxnYSjsDRe6L 05Y4qJUW/QVePafuI56hCLrs5hyAdyiwNgzmDn1nQvj8hAL6See2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LHmdKK N9FqYLXfRLC89xXie91o70TyjvmGDKJ4ed0Ec=; b=Ne0ocTxb48yDIF8sGS9rQ4 7a7S5iK7CY/1cl4eaQQdEvR1EsDVCeLTsmnqpAr/5GwiTlFtGPhOp0UDrBhuP7Ax Nrm0/H8hFZ80PH6YfShQOEnUzVSlz3RLjlesGB4U3AY/JxLP2SYbHKltJIw66+Wi vknrtbpXXmvccYteM/a+OYgoMFnQ98dhE32rdTa9w/qnr8VLAVloxOQ2GN5iVfaA DtglaAtwiPLWn4drVLsW41gfGchXYAzMOzJHhi5rtxIhc43RT6WI4kiyVoncwTux DFpDzf3ZMI9mlZ1o6qgx31cLdqMsqFu6/y7UyMkZpSvehTTn252uwZw46PB2nxBA == X-ME-Sender: Received: from yliu-mob (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 408AA7E3D6; Wed, 24 Jan 2018 10:24:34 -0500 (EST) Date: Wed, 24 Jan 2018 23:24:32 +0800 From: Yuanhan Liu To: =?iso-8859-1?Q?Ga=EBtan?= Rivet Cc: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180124152432.GX29540@yliu-mob> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <20180118094623.gu5ahrfd75b5gcct@bidouze.vm.6wind.com> <20180123124602.GS29540@yliu-mob> <17059484.9s6tGoQGou@xps> <20180123160816.uvsvegtltmzrr4yi@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180123160816.uvsvegtltmzrr4yi@bidouze.vm.6wind.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:24:37 -0000 On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > standardized objects in response to parameters that are given to them > for init. I think matching properties should be restricted to higher > classes (bus, eth/crypto), That's also what I thought. But I'm okay to have "driver" category included for matching. I just don't really see a good example for that. > while the driver class should be left > free-form and to the responsibility of the PMD itself (while having the > proper libraries for helping parsing safely, thus driving developpers > toward similar syntaxes, while not forcing them in those). I agree. The drv args are parsed by the drivers after all. It's hard to have a good parser for all. I also don't know why we have to force them to use "key=value" pairs. I even see some drawbacks from the forcement: - some PMDs already use none key/value format. Forcing them breaks more. If the "-w" "--vdev" compatibility is kept", nothing will be broken from the user point of view. However, if "key=value" pair is going to be used, user have to do some changes. - Some "value" might have to use the nested "=". Handling the nested pairs introduces more complexity. - sometimes, it's simple without an assignment. For example, it could be "driver=vhost-pmd,...,client" to let the vhost PMD acts as the client mode. Both Linux kernel and QEMU don't force the "key=value" pair usage, I don't see any good reason why we have to do that. --yliu