From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51]) by dpdk.org (Postfix) with ESMTP id 492DD3250 for ; Thu, 25 Jan 2018 17:01:46 +0100 (CET) Received: by mail-pg0-f51.google.com with SMTP id m136so5310587pga.12 for ; Thu, 25 Jan 2018 08:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SAMD9IdCj0NBZF9T9Uyd82fHe2hiYFPZi89xYnfOIdU=; b=oqadtwA/hHPFgQemiZ4wVkjzIaUqaaxVOrYwFnHY2H1pdcj02aFLuZ5io3WL1alVbm 6KTBXHTx50aTIy+ytc8qe1RtDiP6fg+vMB7PM4ny6UXG3puaWn8uW4GmOiJSrpplXXGe h2E8x/T6cOwUFHnE4MjBorfzh5PmxwgoqF9hvB9Gg3TNa+nia7gFamiRdAUmpKYsWjrP bVKMjLSrKjvTfSDZRpZEp5lK2HZUzSKSEihBUoSGwXjWDwN3xinnIqVAeaFoJuj3waSJ F/zZMmXKjYkp2Q+CWvW9nnlSUS9dAq0E0nZGz8wHCbEP9n4MlUxyz2+9l35gmzebOZfG jfow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SAMD9IdCj0NBZF9T9Uyd82fHe2hiYFPZi89xYnfOIdU=; b=tjoW09tLFD4ceSNwwXMXl0RblXyTIi0zWIIvrA1cF7rInuW6B4KNfDG8NLsfLRVnI8 2ikJEOeY4ec2pl3DD0pjqj9FVWziGDwnEWl0tAFRqSPYLAE16NLn9yJHgoQq/WA584hR p+Pnc/G45Y52DoEpZNqL6XSWhd8lr5hokHWngC/tJ813k4Jcq+CxfmHg+YEqUUQgLXA3 LOf9Hc22FGJI+wnuuUArjmgCCLC8SJq/DnHPWTBqc0SK+Yfx4CkjQ71cW/29Y5foWkrn IElmQSiGvj9Y36Bx8jsnGLy1EOsckbIY3xhDf5YBQxVcGkIsb+fPRPH3Enn5mFJEhC3t R+aA== X-Gm-Message-State: AKwxytddIKerMh957Lt+7fvarE9M9Ro+oelV6LavT/OZg/2W2Fsn1t+G s4ZdMRj19fQl2d/acCQY8ZHyXw== X-Google-Smtp-Source: AH8x225WSby8N9xuwnsx6QCIo9W6N4yJ4PKCOZ8Ss/3u1+baqHHSGlz4XFOko4ZvHhV3hYov0mZA5w== X-Received: by 2002:a17:902:6bca:: with SMTP id m10-v6mr11470139plt.351.1516896105295; Thu, 25 Jan 2018 08:01:45 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id w2sm4835080pgm.59.2018.01.25.08.01.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 08:01:45 -0800 (PST) Date: Thu, 25 Jan 2018 08:01:41 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: "Lu, Wenzhuo" , Moti Haimovsky , dev@dpdk.org, shahafs@mellanox.com, ferruh.yigit@intel.com Message-ID: <20180125080141.0dd6ac91@xeon-e3> In-Reply-To: <60691740.PPs9Gye6m2@xps> References: <1516695081-178919-1-git-send-email-motih@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B715D7A@shsmsx102.ccr.corp.intel.com> <60691740.PPs9Gye6m2@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 16:01:46 -0000 On Thu, 25 Jan 2018 10:04:11 +0100 Thomas Monjalon wrote: > 25/01/2018 02:11, Lu, Wenzhuo: > > > --- a/app/test-pmd/testpmd.c > > > +++ b/app/test-pmd/testpmd.c > > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = { > > > */ > > > struct rte_eth_rxmode rx_mode = { > > > .max_rx_pkt_len = ETHER_MAX_LEN, /**< Default maximum frame > > > length. */ > > > - .offloads = (DEV_RX_OFFLOAD_VLAN_FILTER | > > > - DEV_RX_OFFLOAD_VLAN_STRIP | > > > - DEV_RX_OFFLOAD_CRC_STRIP), > > > + .offloads = 0, > > > > Change the default behavior may trigger other problems. I think TX offload could be a good reference. Get the capability and check what's supported first, then ignore the not supported functions with printing a warning but not block anything... > > I agree that we should check the capabilities before requesting an offload. > But I disagree on another point: we should not enable an offload if the > user did not request it explicitly. It makes things unclear. > This is a testing tool, it should be close to the ethdev API behavior. > > Why these offload flags are silently enabled? Also all virtual devices ignore CRC strip.