From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D54A31B172 for ; Thu, 25 Jan 2018 12:03:43 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 03:03:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,411,1511856000"; d="scan'208";a="198700426" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga006.fm.intel.com with ESMTP; 25 Jan 2018 03:03:41 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w0PB3emu027536; Thu, 25 Jan 2018 11:03:40 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w0PB3ekl028609; Thu, 25 Jan 2018 11:03:40 GMT Received: (from lma25@localhost) by sivswdev01.ir.intel.com with LOCAL id w0PB3eMo028605; Thu, 25 Jan 2018 11:03:40 GMT Date: Thu, 25 Jan 2018 11:03:40 +0000 From: "Liang, Ma" To: Zhiyong Yang Cc: dev@dpdk.org, peter.mccarthy@intel.com, ferruh.yigit@intel.com Message-ID: <20180125110340.GC9466@sivswdev01.ir.intel.com> References: <20180125070350.14735-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180125070350.14735-1-zhiyong.yang@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] event/opdl: fix ICC fails at compile time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 11:03:44 -0000 On 25 Jan 15:03, Zhiyong Yang wrote: > ICC reports the issue at compile time as follows. > error #592: variable "i" is used before its value is set > RTE_SET_USED(i); > > The patch is to fix it. GCC and CLANG has been tested as well. > > Fixes: d548ef513cd7 ("event/opdl: add unit tests") > Cc: liang.j.ma@intel.com > Cc: peter.mccarthy@intel.com > Cc: ferruh.yigit@intel.com > > Signed-off-by: Zhiyong Yang > --- > drivers/event/opdl/opdl_test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/event/opdl/opdl_test.c b/drivers/event/opdl/opdl_test.c > index 13d4f6b45..39c6cf8cf 100644 > --- a/drivers/event/opdl/opdl_test.c > +++ b/drivers/event/opdl/opdl_test.c > @@ -562,7 +562,6 @@ single_link_w_stats(struct test *t) > uint32_t deq_pkts; > struct rte_mbuf *mbufs[3]; > RTE_SET_USED(mbufs); > - RTE_SET_USED(i); > > /* Create instance with 3 ports */ > if (init(t, 2, tx_port + 1) < 0 || > @@ -702,10 +701,8 @@ single_link(struct test *t) > /* const uint8_t w3_port = 3; */ > const uint8_t tx_port = 2; > int err; > - int i; > struct rte_mbuf *mbufs[3]; > RTE_SET_USED(mbufs); > - RTE_SET_USED(i); > > /* Create instance with 5 ports */ > if (init(t, 2, tx_port+1) < 0 || > -- > 2.13.3 > Many thanks Zhi Yong. Acked-by: Liang Ma