* [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API
@ 2018-01-23 6:43 Wei Zhao
2018-01-25 3:59 ` Zhang, Qi Z
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Wei Zhao @ 2018-01-23 6:43 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, Wei Zhao
This patch fix issues check from DPDK coverity issues.
Fixes: ecad87d22383e ("net/i40e: move RSS to flow API")
Coverity issues: 257020 257024 257037
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
drivers/net/i40e/i40e_flow.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5ea9f99..b0db458 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
sizeof(uint32_t);
}
- return i40e_hw_rss_hash_set(pf, &rss_conf);
+ i40e_hw_rss_hash_set(pf, &rss_conf);
rte_memcpy(rss_info,
conf, sizeof(struct i40e_rte_flow_rss_conf));
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index cd9a9b6..a23f485 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info;
uint16_t i, j, n, tmp;
uint32_t index = 0;
+ uint64_t hf_bit = 1;
NEXT_ITEM_OF_ACTION(act, actions, index);
rss = (const struct rte_flow_action_rss *)act->conf;
@@ -4219,7 +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
if (action_flag) {
for (n = 0; n < 64; n++) {
- if (rss->rss_conf->rss_hf & (1 << n)) {
+ if (rss->rss_conf->rss_hf & (hf_bit << n)) {
conf_info->region[0].hw_flowtype[0] = n;
conf_info->region[0].flowtype_num = 1;
conf_info->queue_region_number = 1;
@@ -4313,7 +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
}
rss_config->queue_region_conf = TRUE;
- return 0;
}
if (!rss || !rss->num) {
--
2.9.3
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-23 6:43 [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API Wei Zhao @ 2018-01-25 3:59 ` Zhang, Qi Z 2018-01-25 5:40 ` Zhang, Qi Z ` (2 subsequent siblings) 3 siblings, 0 replies; 13+ messages in thread From: Zhang, Qi Z @ 2018-01-25 3:59 UTC (permalink / raw) To: Zhao1, Wei, dev > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, January 23, 2018 2:43 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > This patch fix issues check from DPDK coverity issues. > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > 257020 257024 257037 > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> Acked-by Qi Zhang <qi.z.zhang@intel.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-23 6:43 [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API Wei Zhao 2018-01-25 3:59 ` Zhang, Qi Z @ 2018-01-25 5:40 ` Zhang, Qi Z 2018-01-26 3:17 ` Zhao1, Wei 2018-01-25 6:12 ` Zhang, Qi Z 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao 3 siblings, 1 reply; 13+ messages in thread From: Zhang, Qi Z @ 2018-01-25 5:40 UTC (permalink / raw) To: Zhao1, Wei, dev Hi Wei: > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, January 23, 2018 2:43 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > This patch fix issues check from DPDK coverity issues. > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > 257020 257024 257037 > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_flow.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 5ea9f99..b0db458 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > sizeof(uint32_t); > } > > - return i40e_hw_rss_hash_set(pf, &rss_conf); > + i40e_hw_rss_hash_set(pf, &rss_conf); > > rte_memcpy(rss_info, > conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git > a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > cd9a9b6..a23f485 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; > uint16_t i, j, n, tmp; > uint32_t index = 0; > + uint64_t hf_bit = 1; > > NEXT_ITEM_OF_ACTION(act, actions, index); > rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 > +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > if (action_flag) { > for (n = 0; n < 64; n++) { > - if (rss->rss_conf->rss_hf & (1 << n)) { > + if (rss->rss_conf->rss_hf & (hf_bit << n)) { > conf_info->region[0].hw_flowtype[0] = n; > conf_info->region[0].flowtype_num = 1; > conf_info->queue_region_number = 1; @@ -4313,7 > +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > } > > rss_config->queue_region_conf = TRUE; > - return 0; > } Seems if you remove return 0, rss_config->queue_region_conf will be overwrite by FALSE at end, right? > > if (!rss || !rss->num) { > -- > 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-25 5:40 ` Zhang, Qi Z @ 2018-01-26 3:17 ` Zhao1, Wei 2018-01-26 8:32 ` Zhang, Helin 0 siblings, 1 reply; 13+ messages in thread From: Zhao1, Wei @ 2018-01-26 3:17 UTC (permalink / raw) To: Zhang, Qi Z, dev Hi, zhang qi V2 for this patch. Thanks. https://dpdk.org/dev/patchwork/patch/34533/ > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 1:40 PM > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > Hi Wei: > > > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, January 23, 2018 2:43 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei > > <wei.zhao1@intel.com> > > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > > > This patch fix issues check from DPDK coverity issues. > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > > 257020 257024 257037 > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > --- > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > drivers/net/i40e/i40e_flow.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > > sizeof(uint32_t); > > } > > > > - return i40e_hw_rss_hash_set(pf, &rss_conf); > > + i40e_hw_rss_hash_set(pf, &rss_conf); > > > > rte_memcpy(rss_info, > > conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git > > a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > > cd9a9b6..a23f485 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > *dev, > > struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; > > uint16_t i, j, n, tmp; > > uint32_t index = 0; > > + uint64_t hf_bit = 1; > > > > NEXT_ITEM_OF_ACTION(act, actions, index); > > rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 > > +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > > if (action_flag) { > > for (n = 0; n < 64; n++) { > > - if (rss->rss_conf->rss_hf & (1 << n)) { > > + if (rss->rss_conf->rss_hf & (hf_bit << n)) { > > conf_info->region[0].hw_flowtype[0] = n; > > conf_info->region[0].flowtype_num = 1; > > conf_info->queue_region_number = 1; @@ - > 4313,7 > > +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > } > > > > rss_config->queue_region_conf = TRUE; > > - return 0; > > } > > Seems if you remove return 0, rss_config->queue_region_conf will be > overwrite by FALSE at end, right? > > > > if (!rss || !rss->num) { > > -- > > 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-26 3:17 ` Zhao1, Wei @ 2018-01-26 8:32 ` Zhang, Helin 2018-01-26 8:56 ` Zhao1, Wei 0 siblings, 1 reply; 13+ messages in thread From: Zhang, Helin @ 2018-01-26 8:32 UTC (permalink / raw) To: Zhao1, Wei, Zhang, Qi Z, dev Hi Wei I need your helps to rework the patch to follow the commit log styles other commits use. Please find some good examples via git log. Thanks! /Helin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Friday, January 26, 2018 11:18 AM > To: Zhang, Qi Z; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API > > Hi, zhang qi > > V2 for this patch. > Thanks. > https://dpdk.org/dev/patchwork/patch/34533/ > > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, January 25, 2018 1:40 PM > > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > > Hi Wei: > > > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Tuesday, January 23, 2018 2:43 PM > > > To: dev@dpdk.org > > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei > > > <wei.zhao1@intel.com> > > > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > > > > > This patch fix issues check from DPDK coverity issues. > > > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > > > 257020 257024 257037 > > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > > drivers/net/i40e/i40e_flow.c | 4 ++-- > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > > > sizeof(uint32_t); > > > } > > > > > > - return i40e_hw_rss_hash_set(pf, &rss_conf); > > > + i40e_hw_rss_hash_set(pf, &rss_conf); > > > > > > rte_memcpy(rss_info, > > > conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git > > > a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > > > cd9a9b6..a23f485 100644 > > > --- a/drivers/net/i40e/i40e_flow.c > > > +++ b/drivers/net/i40e/i40e_flow.c > > > @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > > *dev, > > > struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; > > > uint16_t i, j, n, tmp; > > > uint32_t index = 0; > > > + uint64_t hf_bit = 1; > > > > > > NEXT_ITEM_OF_ACTION(act, actions, index); > > > rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 > > > +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > > > > if (action_flag) { > > > for (n = 0; n < 64; n++) { > > > - if (rss->rss_conf->rss_hf & (1 << n)) { > > > + if (rss->rss_conf->rss_hf & (hf_bit << n)) { > > > conf_info->region[0].hw_flowtype[0] = n; > > > conf_info->region[0].flowtype_num = 1; > > > conf_info->queue_region_number = 1; @@ - > > 4313,7 > > > +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > } > > > > > > rss_config->queue_region_conf = TRUE; > > > - return 0; > > > } > > > > Seems if you remove return 0, rss_config->queue_region_conf will be > > overwrite by FALSE at end, right? > > > > > > if (!rss || !rss->num) { > > > -- > > > 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-26 8:32 ` Zhang, Helin @ 2018-01-26 8:56 ` Zhao1, Wei 0 siblings, 0 replies; 13+ messages in thread From: Zhao1, Wei @ 2018-01-26 8:56 UTC (permalink / raw) To: Zhang, Helin, Zhang, Qi Z, dev Hi, helin A new v3 has been commit, https://dpdk.org/dev/patchwork/patch/34546/ Thanks. > -----Original Message----- > From: Zhang, Helin > Sent: Friday, January 26, 2018 4:32 PM > To: Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > Hi Wei > > I need your helps to rework the patch to follow the commit log styles other > commits use. Please find some good examples via git log. Thanks! > > /Helin > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > > Sent: Friday, January 26, 2018 11:18 AM > > To: Zhang, Qi Z; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API > > > > Hi, zhang qi > > > > V2 for this patch. > > Thanks. > > https://dpdk.org/dev/patchwork/patch/34533/ > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, January 25, 2018 1:40 PM > > > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > > > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > > > > Hi Wei: > > > > > > > > > > -----Original Message----- > > > > From: Zhao1, Wei > > > > Sent: Tuesday, January 23, 2018 2:43 PM > > > > To: dev@dpdk.org > > > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei > > > > <wei.zhao1@intel.com> > > > > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > > > > > > > This patch fix issues check from DPDK coverity issues. > > > > > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity > issues: > > > > 257020 257024 257037 > > > > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > > > --- > > > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > > > drivers/net/i40e/i40e_flow.c | 4 ++-- > > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > > b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > > @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > > > > sizeof(uint32_t); > > > > } > > > > > > > > - return i40e_hw_rss_hash_set(pf, &rss_conf); > > > > + i40e_hw_rss_hash_set(pf, &rss_conf); > > > > > > > > rte_memcpy(rss_info, > > > > conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git > > > > a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > > > > index > > > > cd9a9b6..a23f485 100644 > > > > --- a/drivers/net/i40e/i40e_flow.c > > > > +++ b/drivers/net/i40e/i40e_flow.c > > > > @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct > > > > rte_eth_dev *dev, > > > > struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; > > > > uint16_t i, j, n, tmp; > > > > uint32_t index = 0; > > > > + uint64_t hf_bit = 1; > > > > > > > > NEXT_ITEM_OF_ACTION(act, actions, index); > > > > rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 > > > > +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > > > > > > if (action_flag) { > > > > for (n = 0; n < 64; n++) { > > > > - if (rss->rss_conf->rss_hf & (1 << n)) { > > > > + if (rss->rss_conf->rss_hf & (hf_bit << n)) { > > > > conf_info->region[0].hw_flowtype[0] = n; > > > > conf_info->region[0].flowtype_num = 1; > > > > conf_info->queue_region_number = 1; @@ - > > > 4313,7 > > > > +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > > } > > > > > > > > rss_config->queue_region_conf = TRUE; > > > > - return 0; > > > > } > > > > > > Seems if you remove return 0, rss_config->queue_region_conf will be > > > overwrite by FALSE at end, right? > > > > > > > > if (!rss || !rss->num) { > > > > -- > > > > 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-23 6:43 [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API Wei Zhao 2018-01-25 3:59 ` Zhang, Qi Z 2018-01-25 5:40 ` Zhang, Qi Z @ 2018-01-25 6:12 ` Zhang, Qi Z 2018-01-25 6:22 ` Zhao1, Wei 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao 3 siblings, 1 reply; 13+ messages in thread From: Zhang, Qi Z @ 2018-01-25 6:12 UTC (permalink / raw) To: Zhao1, Wei, dev > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 12:00 PM > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, January 23, 2018 2:43 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei > <wei.zhao1@intel.com> > > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > > > This patch fix issues check from DPDK coverity issues. > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > > 257020 257024 257037 > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > Acked-by Qi Zhang <qi.z.zhang@intel.com> Nacked-by Qi Zhang <qi.z.zhang@intel.com> since new issue is found, v2 is required. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API 2018-01-25 6:12 ` Zhang, Qi Z @ 2018-01-25 6:22 ` Zhao1, Wei 0 siblings, 0 replies; 13+ messages in thread From: Zhao1, Wei @ 2018-01-25 6:22 UTC (permalink / raw) To: Zhang, Qi Z, dev Ok, v2 will commit later. > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, January 25, 2018 2:12 PM > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, January 25, 2018 12:00 PM > > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org > > Subject: RE: [PATCH] net/i40e: fix issues for RSS flow API > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Tuesday, January 23, 2018 2:43 PM > > > To: dev@dpdk.org > > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei > > <wei.zhao1@intel.com> > > > Subject: [PATCH] net/i40e: fix issues for RSS flow API > > > > > > This patch fix issues check from DPDK coverity issues. > > > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues: > > > 257020 257024 257037 > > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > > > Acked-by Qi Zhang <qi.z.zhang@intel.com> > > Nacked-by Qi Zhang <qi.z.zhang@intel.com> since new issue is found, v2 is > required. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: fix issue for RSS flow API 2018-01-23 6:43 [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API Wei Zhao ` (2 preceding siblings ...) 2018-01-25 6:12 ` Zhang, Qi Z @ 2018-01-26 3:08 ` Wei Zhao 2018-01-26 7:32 ` Zhang, Qi Z ` (2 more replies) 3 siblings, 3 replies; 13+ messages in thread From: Wei Zhao @ 2018-01-26 3:08 UTC (permalink / raw) To: dev; +Cc: qi.z.zhang, stable, Wei Zhao This patch fix issue check from DPDK coverity issues. Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issue: 257020 257024 257037 Signed-off-by: Wei Zhao <wei.zhao1@intel.com> --- v2: -fix an error introduced in v1 patch. --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_flow.c | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, sizeof(uint32_t); } - return i40e_hw_rss_hash_set(pf, &rss_conf); + i40e_hw_rss_hash_set(pf, &rss_conf); rte_memcpy(rss_info, conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index cd9a9b6..2cb9c64 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; uint16_t i, j, n, tmp; uint32_t index = 0; + uint64_t hf_bit = 1; NEXT_ITEM_OF_ACTION(act, actions, index); rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, if (action_flag) { for (n = 0; n < 64; n++) { - if (rss->rss_conf->rss_hf & (1 << n)) { + if (rss->rss_conf->rss_hf & (hf_bit << n)) { conf_info->region[0].hw_flowtype[0] = n; conf_info->region[0].flowtype_num = 1; conf_info->queue_region_number = 1; @@ -4313,9 +4314,11 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, } rss_config->queue_region_conf = TRUE; - return 0; } + if (rss_config->queue_region_conf) + return 0; + if (!rss || !rss->num) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, -- 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: fix issue for RSS flow API 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao @ 2018-01-26 7:32 ` Zhang, Qi Z 2018-01-26 8:43 ` [dpdk-dev] [PATCH v3] " Wei Zhao 2018-01-26 8:46 ` Wei Zhao 2 siblings, 0 replies; 13+ messages in thread From: Zhang, Qi Z @ 2018-01-26 7:32 UTC (permalink / raw) To: Zhao1, Wei, dev; +Cc: stable > -----Original Message----- > From: Zhao1, Wei > Sent: Friday, January 26, 2018 11:08 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Zhao1, Wei > <wei.zhao1@intel.com> > Subject: [PATCH v2] net/i40e: fix issue for RSS flow API > > This patch fix issue check from DPDK coverity issues. > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issue: > 257020 257024 257037 > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > > --- > > v2: > -fix an error introduced in v1 patch. > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_flow.c | 7 +++++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 5ea9f99..b0db458 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > sizeof(uint32_t); > } > > - return i40e_hw_rss_hash_set(pf, &rss_conf); > + i40e_hw_rss_hash_set(pf, &rss_conf); > > rte_memcpy(rss_info, > conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git > a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index > cd9a9b6..2cb9c64 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; > uint16_t i, j, n, tmp; > uint32_t index = 0; > + uint64_t hf_bit = 1; > > NEXT_ITEM_OF_ACTION(act, actions, index); > rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 > +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > if (action_flag) { > for (n = 0; n < 64; n++) { > - if (rss->rss_conf->rss_hf & (1 << n)) { > + if (rss->rss_conf->rss_hf & (hf_bit << n)) { > conf_info->region[0].hw_flowtype[0] = n; > conf_info->region[0].flowtype_num = 1; > conf_info->queue_region_number = 1; @@ -4313,9 > +4314,11 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > } > > rss_config->queue_region_conf = TRUE; > - return 0; > } > > + if (rss_config->queue_region_conf) > + return 0; > + > if (!rss || !rss->num) { > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > -- > 2.9.3 Acked-by: Qi Zhang <qi.z.zhang@intel.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao 2018-01-26 7:32 ` Zhang, Qi Z @ 2018-01-26 8:43 ` Wei Zhao 2018-01-26 8:46 ` Wei Zhao 2 siblings, 0 replies; 13+ messages in thread From: Wei Zhao @ 2018-01-26 8:43 UTC (permalink / raw) To: dev; +Cc: qi.z.zhang, stable, Wei Zhao This patch fix issue check from DPDK coverity issues. Coverity issue: 257020, 257024, 257037 Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao <wei.zhao1@intel.com> --- v2: -fix an error introduced in v1 patch. v3: -change coverity writing style for DPDK rule. --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_flow.c | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, sizeof(uint32_t); } - return i40e_hw_rss_hash_set(pf, &rss_conf); + i40e_hw_rss_hash_set(pf, &rss_conf); rte_memcpy(rss_info, conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index cd9a9b6..2cb9c64 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; uint16_t i, j, n, tmp; uint32_t index = 0; + uint64_t hf_bit = 1; NEXT_ITEM_OF_ACTION(act, actions, index); rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, if (action_flag) { for (n = 0; n < 64; n++) { - if (rss->rss_conf->rss_hf & (1 << n)) { + if (rss->rss_conf->rss_hf & (hf_bit << n)) { conf_info->region[0].hw_flowtype[0] = n; conf_info->region[0].flowtype_num = 1; conf_info->queue_region_number = 1; @@ -4313,9 +4314,11 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, } rss_config->queue_region_conf = TRUE; - return 0; } + if (rss_config->queue_region_conf) + return 0; + if (!rss || !rss->num) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, -- 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao 2018-01-26 7:32 ` Zhang, Qi Z 2018-01-26 8:43 ` [dpdk-dev] [PATCH v3] " Wei Zhao @ 2018-01-26 8:46 ` Wei Zhao 2018-01-30 2:46 ` Zhang, Helin 2 siblings, 1 reply; 13+ messages in thread From: Wei Zhao @ 2018-01-26 8:46 UTC (permalink / raw) To: dev; +Cc: qi.z.zhang, Wei Zhao This patch fix issue check from DPDK coverity issues. Coverity issue: 257020, 257024, 257037 Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao <wei.zhao1@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> --- v2: -fix an error introduced in v1 patch. v3: -change coverity writing style for DPDK rule. --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_flow.c | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5ea9f99..b0db458 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, sizeof(uint32_t); } - return i40e_hw_rss_hash_set(pf, &rss_conf); + i40e_hw_rss_hash_set(pf, &rss_conf); rte_memcpy(rss_info, conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index cd9a9b6..2cb9c64 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info; uint16_t i, j, n, tmp; uint32_t index = 0; + uint64_t hf_bit = 1; NEXT_ITEM_OF_ACTION(act, actions, index); rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7 +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, if (action_flag) { for (n = 0; n < 64; n++) { - if (rss->rss_conf->rss_hf & (1 << n)) { + if (rss->rss_conf->rss_hf & (hf_bit << n)) { conf_info->region[0].hw_flowtype[0] = n; conf_info->region[0].flowtype_num = 1; conf_info->queue_region_number = 1; @@ -4313,9 +4314,11 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, } rss_config->queue_region_conf = TRUE; - return 0; } + if (rss_config->queue_region_conf) + return 0; + if (!rss || !rss->num) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, -- 2.9.3 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API 2018-01-26 8:46 ` Wei Zhao @ 2018-01-30 2:46 ` Zhang, Helin 0 siblings, 0 replies; 13+ messages in thread From: Zhang, Helin @ 2018-01-30 2:46 UTC (permalink / raw) To: Zhao1, Wei, dev; +Cc: Zhang, Qi Z, Zhao1, Wei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, January 26, 2018 4:47 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z; Zhao1, Wei > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix issue for RSS flow API > > This patch fix issue check from DPDK coverity issues. > > Coverity issue: 257020, 257024, 257037 > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com> > Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel, with commit log changes. Thanks! /Helin ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-01-30 2:46 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-23 6:43 [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API Wei Zhao 2018-01-25 3:59 ` Zhang, Qi Z 2018-01-25 5:40 ` Zhang, Qi Z 2018-01-26 3:17 ` Zhao1, Wei 2018-01-26 8:32 ` Zhang, Helin 2018-01-26 8:56 ` Zhao1, Wei 2018-01-25 6:12 ` Zhang, Qi Z 2018-01-25 6:22 ` Zhao1, Wei 2018-01-26 3:08 ` [dpdk-dev] [PATCH v2] net/i40e: fix issue " Wei Zhao 2018-01-26 7:32 ` Zhang, Qi Z 2018-01-26 8:43 ` [dpdk-dev] [PATCH v3] " Wei Zhao 2018-01-26 8:46 ` Wei Zhao 2018-01-30 2:46 ` Zhang, Helin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).