From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0075.outbound.protection.outlook.com [104.47.40.75]) by dpdk.org (Postfix) with ESMTP id 79AE21B342 for ; Fri, 26 Jan 2018 08:20:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eS1IWDOX3qSBKFko2b1EYLx+Oz+L1D5tMJZQP4usZrI=; b=Hf56yDksZUoUYutkdrVZlbPjn4m8Yk7zkXd+qMEoMZTCvhgJJlrhx14ZqyCd9QOi2qQ/P1gRau8A2LSwIWzcdqXYPFlzdllBs5leOzVzC+BsH5V0bH+SjvOlCtG21JVDxAE7xm1R4HYiAgRjUAViuAfsY8nKaRcCLQa43orWaZE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.201.178) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 26 Jan 2018 07:20:51 +0000 Date: Fri, 26 Jan 2018 12:50:32 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180126072031.GA7454@jerin> References: <20180123162240.26831-1-pbhagavatula@caviumnetworks.com> <20180126064016.9966-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180126064016.9966-1-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [106.200.201.178] X-ClientProxiedBy: BMXPR01CA0012.INDPRD01.PROD.OUTLOOK.COM (10.174.214.150) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 766413e5-5332-4438-05c7-08d5648d55ac X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:Wvfo82TyNfMJZmW17jjzEYkBA2S87GK0CLOhJ+DISvGOJ9AsOPNP/iq2m/TCtNFHoPmmz9zf9kp/w0e9TeEJ1XZxn7VadpsCL/dSrnI67icu+WlwbLi8CC6p+KCm88tU9xTDP0PYrLQhsB6ikaOZPdsMk4AkBzMw343BGX48CPtT+wa8MOOQwJZdedf4/F+oGFSWCtSq+I12Dky7oekun05DBWi5fyFbRxBxYyVv3skFh461zO1jHtzOM/Jt9H5p; 25:3sGhZDBZrxgJFqNLeni1lSttg7uYgjOs+W+idtFXc5j3+hB0I2WbW3af8EO8SZpDpakwtzdL0OOyde3BgP8YUNj7E57+Tm134/civdh284ZByjntLxH6/djAO3b1p6swPmx1TrUbz2ac+auYk33vzEd8QUkhiOruIlh9bEPi75O4JXQKO+t4bPBVtFXWsLVuTNxhYb5EaDHr3LTJ9vyf/tMcEV4EYKcn2c64kCMvhHjFWRwg2toaNZDPowjfqXl8t+xoJxtJLc7JQjwHbMPUW8mgtJM9Jy71zv2T65K/RW/9gj1TQJZHjGrBvxDIHHMUlHVCXL70FD1PWpVG01rUmQ==; 31:hMnqh8qhw/wssNGFdNdW2f+taUBr9nv0hTcnYFWMMepEMUxD2c7ij41Sv6BYIIgBERv6EnKDYMpHPbbTLwNt5eT9Scp7o0V8Xnaz6msRQn3WrbHa635iGb313IK+gED6TyGQr/OfbK4NwjZYdb9pfKvrhJsxzwFypw7u5XgwNJQxx10cSFxIpEMJCUrp4XXkygy7h7jnRZgyemFMdiG9PlsqDmRuj3k6zmz1CsNHoX0= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:3izw2gTh/9nQYXWYhpbbePzQLBrnNLp0t/qEG8/PYiYXByMMultA85mjEQpYUw4w99yqgmrZYDW3Al7QbAImZpmGQFR917nMaFT0RACm+s5LVs1Wa+C5qgJU0rG3X/3gLqkxelu1MDqmfOFPGsZW0FTdHSlevHaikt45PSdg0DvG8fZyhymrhqOnh3WNeheLjNIDGRjG8FK39Pbt5eYKAvFl/U4zQFszf4gzx4U3DhKv0SdcxuVw7p/WDhBG8tnylS2WyvZv7YRQsWxZV+Bn9QmxnD+x9WwH9BF2z8+x6uBRks+qp3IvYfHzkjqZJDsEziO73TkpjYaOzPy3gIg7K5iHv2WVe32DH0D9JD9ypK7E4UTAzWXYX13wJaKVla/NORxHUPrntXNkGqUjH5KGILNbqivhSk8XyG8bsp17mFsxKdNH9dBk+xxTgxN/Bj4DfpgzuPRJNYREDf5YQSEduCcnwZ09V4BDxfdvtWQA1ihHcRAuNpRZXF9z0Cx80YxUGr/e7AhRA8d+YX9QwC6/9+2vYUk47zEHadBvF4PMx2/GnW4sr9qYTr7Bj+0N0C073LH0toRf7foMyvxmuYYiofN4eGxE0uOS3O+bU3z7YZc=; 4:WT1sICr5V6Ki9I9sLPy2nPzaSMS8uWChrcF539J/D0IkOn2SKvWLlwt2WGZPBN7rKz7kxtbSDL9DDp7IlCO+rt1L5kMcXvSTwtUyvR46SGgmzST7z+1EI0AHRf+oi7ED1JCAIpyFGRU+hcL2CxCfoZE7hd9b74gqh2zZ+D17dVfueyktz+oMrjJpa0zCGj5qQWoajjoj1eckhjdgUaVdjTa+tml+KO0RU4iXL+aJrk1tYnGhqhTFpPIs7X9I8cAJbDUw5KedAjQKPtaGqHXieMaaeiiBuZ0i+NKUDGQB64D8t7JYBM9zwpsD0MyEJkgl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231023)(2400081)(944501161)(6041288)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2522; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(376002)(346002)(396003)(366004)(13464003)(199004)(189003)(68736007)(575784001)(52116002)(9686003)(6496006)(50466002)(97736004)(66066001)(81156014)(47776003)(81166006)(8936002)(8676002)(59450400001)(386003)(33896004)(76176011)(2950100002)(229853002)(42882006)(6636002)(6862004)(4326008)(2906002)(478600001)(5660300001)(33656002)(3846002)(6116002)(7736002)(106356001)(1076002)(83506002)(23726003)(55016002)(26005)(53936002)(33716001)(105586002)(5009440100003)(58126008)(16526019)(305945005)(6246003)(72206003)(25786009)(6666003)(16586007)(316002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:SovVTGEIgjrzb1XXhmEr2CL5f9xmREkVTsT+Qfow2?= =?us-ascii?Q?HWu0nCQd/WzbaBOz1LDzdtTL7ROW7p4pALs4Y+5Jde/lEhIXKg2hd/tKryoz?= =?us-ascii?Q?HQRnsD/O8ZIxSA3r5RhhN5Mk9IMTrwLVfLRRbQbTQ3AOYnsfU2ajx9ogwOXg?= =?us-ascii?Q?HIcgGeIIY59XyJuPBpUG+LAdc2STMmV6qwhVtzwQaq3hs2ZFFZp6NYfqD3+c?= =?us-ascii?Q?Lay0SnfUumVeQgP59bwXhzVpCnDE4DyMp4x5MIsQUAAyAHVAa/WAzs5vC6Nj?= =?us-ascii?Q?iK1y90LIRzatMBLZLSwB4b1+hH9J7vMxlxPGTkge5ePiViKhlBBNmqdqLmnb?= =?us-ascii?Q?//fsX37gMwwdwgt7rOn0Sdl6GcmheO4aORWBCQDl+SaEET9ekFp+8RaGuywT?= =?us-ascii?Q?nMc2+vS5owmnzCLUfzIxM2lOZ5rVqTMHtdPUlQRgMCCbWIY3TEhS92oG/sgR?= =?us-ascii?Q?oMqK1cr2uUxRqjRRVfDn3ddLOTsighhoMmi1jQ3auuizjYcGL/lcDrxtCYfE?= =?us-ascii?Q?edkxWAdNo7SHZhcK6v5GGAOf45jzJzenI0YZoI0XS09GCyyY80r1ry2YQ4GQ?= =?us-ascii?Q?D4uSSXf75w7M7uyNQG4GNVBaJMTBl6TyYJfW93TrI8gS3t7s5OQbM5MNVN0V?= =?us-ascii?Q?OxRRdBH9j1eMt/akq94HHKpdt/EzYqc5sfoAcc+S0Elqe94rbaWq1lUvtxl3?= =?us-ascii?Q?AdTxD45ktgLP6ms7Tw6N+mnF/XsvHUuqX+wuPkb6eV+LoRch7FMCayaDu2mU?= =?us-ascii?Q?hMwQhcB/QhiXjQzshXiKnOtHBuoKuDLAK0+WXDUtR8d2jHthgmc8JRsi06yW?= =?us-ascii?Q?z4Z+weYgIRvRhvz64I2VsOG0ZvTlPlvbYr0XVXKuoCWSlVkY+blHE4lrirMf?= =?us-ascii?Q?5Y2iIX/Q8QgBiUJM4Kkfk49e/7x2MqrusOjueH6HCEfzBbSUjThM1oGHeKyY?= =?us-ascii?Q?yoOAVbt6PCMhzoMpbqf7pP2lVGvTQ8RZ9VOEcyYzj78STkWa+GNBrXPHhugN?= =?us-ascii?Q?cO4huhTs4pf/BX9prLeakzDrd5JTDqm/KfOiUCrU/Tnz/z8hcjWUo+w90c2Q?= =?us-ascii?Q?s0pMZdR+Yx4dadH94GvyeJI+cU/xh/waCLJE+zQuNFNui16V84eVBiExp7QO?= =?us-ascii?Q?UvyC8yOFlrwwXSQrQJvU3k2ciLyokcPRyMkCnYx5SzNHvrJ2DWssp+osIW2F?= =?us-ascii?Q?fwm9+ybPSCHTRtzewDijGfds+F0b8ULSB9tb81tfwvquARNKgtfQu2aRLXSM?= =?us-ascii?Q?m/MkWfKKeXQAWVpVEwbnCoFjXPydNfHWsWQpQmjYcW2k0mlCk10WzYzu0Owi?= =?us-ascii?Q?rJtAOEGgfWRdGSCiCBz7XQV8sgSQaaT0x94Iaf8AGBXFY6LaCGljgH0gGCqV?= =?us-ascii?Q?99WLA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:9Es6gJ7BF5VPbihPOX4KcJhd3YAsDgtq/lsbkPEYe8ueVOd66vHHu8c8t1DLtOG8gDQeZ9kM5P4teG6mbT1qVEEsX7mvpRdiHSk+NsnzsuFZjyBaGyAK72NvcefleNszD28tOAYW8jxeRYfiVsqmUHM+6532h/+A+J1s4BOOdtk1atO6rIA9z4pqhX/p0iHwzL/MQoTkmSHUitJAK9Qki4kcmeczewucx1KClEsLEanxAVrMnm8tQIwtSiVjjKGuMlsEVmKC4pCyfnpBrTjFmRShmf+pzHE008vaTvko/Lxfl4/ljLC0qX+hw81xbFvGi99RTeVDi8fiZXKzMn7YzYgG68xWA+Nsi3p3Suc/7c4=; 5:FXN3j3ClplPILamKv0VPp7RL7/vLt9rIS8CYidXS/6ee6H/hkJ62G+0qG1Z86MggW01PlWJiFFm2AIOlguacYfV75eD0crvyBEAVIbqWn4z8wPTEF0v289rhmUABy8TTumuNeeQhQM0rUung2EY53RPKuuPKWz80NInBswXA2SY=; 24:2pY7yI06zyTjzBHcaeIvF9l5SPCiAn3/C8yge0df/rVJkdXL8noxO77Lx0BvCWhDBm1g3HwuUaZ1clBKLWkSWCuRwzVPqfYI7GC69ryE9ys=; 7:T1HGj0VBA5yRmYAA3WDMi44qWVzjBL/6VXmeTHobnKJlcBDMsNulP29xufma4KJJtQV/FozsEXn1LtWU0sT4N/fMJqzjbprp/d4h9fo7SVN7snm22LU6u9S4MLhQW+4SvsuN+omEST5JQBcbZE0nussvtzBKeFTTVXWtJMiNrf1EP3jrC+a2mSePRxNYAeYbkyrPo9SrC8x+VQJN66+O+sEBQIgX7KcHTtzdoOVAAmdlOVnlKkKBojmQoCJYOThf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 07:20:51.4546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 766413e5-5332-4438-05c7-08d5648d55ac X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx: use stub for building in old compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 07:20:56 -0000 -----Original Message----- > Date: Fri, 26 Jan 2018 12:10:16 +0530 > From: Pavan Nikhilesh > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, > ferruh.yigit@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2] net/octeontx: use stub for building in old > compilers > X-Mailer: git-send-email 2.14.1 > > Use stub for building clang < 4.0 as it doesn't support the following > arm machine directives: > > .cpu > > Signed-off-by: Pavan Nikhilesh > --- > > v2 Changes: > - use stub for older clang compilers instead of disabling PMD > > drivers/net/octeontx/Makefile | 8 ++++++++ > drivers/net/octeontx/base/octeontx_io.h | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/octeontx/Makefile b/drivers/net/octeontx/Makefile > index b47bf7a40..5244eedd3 100644 > --- a/drivers/net/octeontx/Makefile > +++ b/drivers/net/octeontx/Makefile > @@ -30,6 +30,14 @@ SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += octeontx_pkivf.c > SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += octeontx_bgx.c > SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += octeontx_ethdev.c > > +ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > + > +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 40 && echo 1), 1) > +CFLAGS += -D CLANG_BUILD_BUG > +endif > + > +endif > + > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > CFLAGS_octeontx_rxtx.o += -fno-prefetch-loop-arrays > > diff --git a/drivers/net/octeontx/base/octeontx_io.h b/drivers/net/octeontx/base/octeontx_io.h > index d51ded236..1c0a941a5 100644 > --- a/drivers/net/octeontx/base/octeontx_io.h > +++ b/drivers/net/octeontx/base/octeontx_io.h > @@ -51,7 +51,7 @@ do { \ > } while (0) > #endif > > -#if defined(RTE_ARCH_ARM64) > +#if defined(RTE_ARCH_ARM64) && !defined(CLANG_BUILD_BUG) It will build silently and break while running the PMD. I think, We should disable building the PMD if dependencies are not meet. Instead of building something that known to not work. > /** > * Perform an atomic fetch-and-add operation. > */ > -- > 2.16.0 >