* [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF
@ 2018-01-29 8:07 Wei Zhao
2018-01-30 2:25 ` Lu, Wenzhuo
0 siblings, 1 reply; 4+ messages in thread
From: Wei Zhao @ 2018-01-29 8:07 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, Wei Zhao
There is no specific handling when there is error happened
of hardware reset process in VF device start process.
Fixes: 0a45657a6794a ("pci: rework interrupt handling")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 4f4334d..585c77c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5001,7 +5001,11 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)
PMD_INIT_FUNC_TRACE();
- hw->mac.ops.reset_hw(hw);
+ err = hw->mac.ops.reset_hw(hw);
+ if (err) {
+ PMD_INIT_LOG(ERR, "Unable to reset vf hardware (%d)", err);
+ return err;
+ }
hw->mac.get_link_status = true;
/* negotiate mailbox API version to use with the PF. */
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF
2018-01-29 8:07 [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF Wei Zhao
@ 2018-01-30 2:25 ` Lu, Wenzhuo
2018-01-30 2:26 ` Zhao1, Wei
2018-01-30 6:03 ` Zhang, Helin
0 siblings, 2 replies; 4+ messages in thread
From: Lu, Wenzhuo @ 2018-01-30 2:25 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
Hi,
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 29, 2018 4:07 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/ixgbe: fix hardware reset issue in VF
>
> There is no specific handling when there is error happened of hardware
> reset process in VF device start process.
>
> Fixes: 0a45657a6794a ("pci: rework interrupt handling")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Please cc stable next time if it fixes an old issue. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF
2018-01-30 2:25 ` Lu, Wenzhuo
@ 2018-01-30 2:26 ` Zhao1, Wei
2018-01-30 6:03 ` Zhang, Helin
1 sibling, 0 replies; 4+ messages in thread
From: Zhao1, Wei @ 2018-01-30 2:26 UTC (permalink / raw)
To: Lu, Wenzhuo, dev; +Cc: stable
Ok.
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Tuesday, January 30, 2018 10:25 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/ixgbe: fix hardware reset issue in VF
>
> Hi,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 29, 2018 4:07 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/ixgbe: fix hardware reset issue in VF
> >
> > There is no specific handling when there is error happened of hardware
> > reset process in VF device start process.
> >
> > Fixes: 0a45657a6794a ("pci: rework interrupt handling")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Please cc stable next time if it fixes an old issue. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF
2018-01-30 2:25 ` Lu, Wenzhuo
2018-01-30 2:26 ` Zhao1, Wei
@ 2018-01-30 6:03 ` Zhang, Helin
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2018-01-30 6:03 UTC (permalink / raw)
To: Lu, Wenzhuo, Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Tuesday, January 30, 2018 10:25 AM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF
>
> Hi,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 29, 2018 4:07 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/ixgbe: fix hardware reset issue in VF
> >
> > There is no specific handling when there is error happened of hardware
> > reset process in VF device start process.
> >
> > Fixes: 0a45657a6794a ("pci: rework interrupt handling")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, with commit log changes, thanks!
/Helin
>
> Please cc stable next time if it fixes an old issue. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-30 6:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 8:07 [dpdk-dev] [PATCH] net/ixgbe: fix hardware reset issue in VF Wei Zhao
2018-01-30 2:25 ` Lu, Wenzhuo
2018-01-30 2:26 ` Zhao1, Wei
2018-01-30 6:03 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).