From: Chas Williams <3chas3@gmail.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com,
"Charles (Chas) Williams" <chas3@att.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues
Date: Mon, 29 Jan 2018 10:21:15 -0500 [thread overview]
Message-ID: <20180129152115.26359-1-3chas3@gmail.com> (raw)
From: "Charles (Chas) Williams" <chas3@att.com>
.dev_configure() may be called again after RX queues have been setup.
This has the effect of clearing whatever setting the RX queues made for
rx_bulk_alloc_allowed or rx_vec_allowed. Only reset this configuration
is there aren't any currently allocated queues.
Fixes: 01fa1d6215fa ("ixgbe: unify Rx setup")
Signed-off-by: Chas Williams <chas3@att.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 37eb668..b39249a 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2348,6 +2348,7 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)
struct ixgbe_adapter *adapter =
(struct ixgbe_adapter *)dev->data->dev_private;
int ret;
+ uint16_t i;
PMD_INIT_FUNC_TRACE();
/* multipe queue mode checking */
@@ -2363,11 +2364,17 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)
/*
* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
- * allocation or vector Rx preconditions we will reset it.
+ * allocation or vector Rx preconditions we will reset it. We
+ * can only do this is there aren't any existing RX queues.
*/
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ if (dev->data->rx_queues[i])
+ goto out;
+ }
adapter->rx_bulk_alloc_allowed = true;
adapter->rx_vec_allowed = true;
+out:
return 0;
}
@@ -4959,6 +4966,7 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev)
struct rte_eth_conf *conf = &dev->data->dev_conf;
struct ixgbe_adapter *adapter =
(struct ixgbe_adapter *)dev->data->dev_private;
+ uint16_t i;
PMD_INIT_LOG(DEBUG, "Configured Virtual Function port id: %d",
dev->data->port_id);
@@ -4981,11 +4989,17 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev)
/*
* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
- * allocation or vector Rx preconditions we will reset it.
+ * allocation or vector Rx preconditions we will reset it. We
+ * can only do this is there aren't any existing RX queues.
*/
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ if (dev->data->rx_queues[i])
+ goto out;
+ }
adapter->rx_bulk_alloc_allowed = true;
adapter->rx_vec_allowed = true;
+out:
return 0;
}
--
2.9.5
next reply other threads:[~2018-01-29 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 15:21 Chas Williams [this message]
2018-01-29 16:25 ` Ananyev, Konstantin
2018-01-29 16:49 ` Chas Williams
[not found] ` <2601191342CEEE43887BDE71AB97725890565545@IRSMSX103.ger.corp.intel.com>
2018-01-29 18:05 ` Ananyev, Konstantin
2018-01-29 18:30 ` Chas Williams
[not found] ` <2601191342CEEE43887BDE71AB97725890565AC3@IRSMSX103.ger.corp.intel.com>
2018-01-30 13:14 ` Ananyev, Konstantin
2018-01-30 16:15 ` Chas Williams
[not found] ` <2601191342CEEE43887BDE71AB977258905662FE@IRSMSX103.ger.corp.intel.com>
2018-01-31 13:38 ` Ananyev, Konstantin
2018-03-29 5:14 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129152115.26359-1-3chas3@gmail.com \
--to=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).