From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: thomas@monjalon.net, zhiyong.yang@intel.com,
ferruh.yigit@intel.com, olivier.matz@6wind.com,
pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH] lpm: fix allocation of an existing object
Date: Wed, 31 Jan 2018 00:21:54 +0530 [thread overview]
Message-ID: <20180130185154.20095-1-pbhagavatula@caviumnetworks.com> (raw)
Fix rte_lpm_create_*() functions to return NULL and set rte_errno to
EEXIST when lpm object name already exists.
This is the behavior described in the API documentation in the header
file.
Fixes: 134975073af3 ("lib: remove unnecessary pointer cast")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
This was already fixed in a previous patch by Olivier commit id
f82f705b635d31a63446a16bc4526dbebf293c5a.
But for some reason was undone in 134975073af3.
lpm6 is untouched.
Fixes currently broken 'func_reentrancy_autotest'.
lib/librte_lpm/rte_lpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index d464dbda9..d00b13d93 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -180,6 +180,7 @@ rte_lpm_create_v20(const char *name, int socket_id, int max_rules,
}
if (te != NULL) {
+ lpm = NULL;
rte_errno = EEXIST;
goto exit;
}
@@ -256,6 +257,7 @@ rte_lpm_create_v1604(const char *name, int socket_id,
}
if (te != NULL) {
+ lpm = NULL;
rte_errno = EEXIST;
goto exit;
}
--
2.16.0
next reply other threads:[~2018-01-30 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 18:51 Pavan Nikhilesh [this message]
2018-01-31 4:47 ` Phil Yang
2018-01-31 13:30 ` Burakov, Anatoly
2018-01-31 23:36 ` Thomas Monjalon
2018-02-01 1:52 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130185154.20095-1-pbhagavatula@caviumnetworks.com \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).