From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0087.outbound.protection.outlook.com [104.47.33.87]) by dpdk.org (Postfix) with ESMTP id 99A4D1B7A1 for ; Wed, 31 Jan 2018 13:41:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m7jyQlFxnHP9/5IO1Uo8QoWSoR66vxm3eD9ogqEDGdQ=; b=is42j1yM3V9IQDNf7SR7WazhAYwoJhOsx5NlbcVOey0dEPB0C5rsSvrB71COt/mSxKxqko24v3tZehgBMYKAo93hKPpyKGsxDYpgeo3xmHiorfzGTYoyT8cPZIB/zGWQcB00SWM2ZR487lk9ZJEiQXbV8ZY91vuEzejpZcznb7s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Wed, 31 Jan 2018 12:41:13 +0000 Date: Wed, 31 Jan 2018 18:10:44 +0530 From: Jerin Jacob To: Ophir Munk Cc: "dev@dpdk.org" , Thomas Monjalon , Pascal Mazon , Jan Viktorin , Jianbo Liu Message-ID: <20180131124042.GA5540@jerin> References: <20180131051408.3652-1-jerin.jacob@caviumnetworks.com> <20180131102352.GA24477@jerin> <20180131113049.GA30737@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR01CA0072.INDPRD01.PROD.OUTLOOK.COM (10.174.208.140) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79cbbafa-fbd5-4e9b-33d8-08d568a7eb68 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:yTFjqq6/JjHk6EIuEyHBB5yXy7H6itOYgAP5xIeP7kdXBMS2Pq51DSHtauo46vmZUvAdwNkBZy2qItW/quWJbC+Z+U4O0D/ah52AJcmKKGmIXX3ND2TK3nXD0ffaVdHLBY3R8iyvHY2jvZSce3wHnh9tpjXw4JLJ4fOTfboC0L58xZMkRG4WI8CmWEYoSpZV5AysifnOB/yGxhnQgRtdlbOQ/xw/c98Oi03wOeE1x+Vz31dx9kxeRSse0UKYEjWs; 25:8hhXrGf3+N66/XM/9vZlIdWA56T1d49O5t6uEDlKY3FVvhMqgyVAMA1agC1B3MEMiUPQl+FRID7rX9y6c7U74sdV+d5V3fUGra7dCsdw1fuobWO9uylyGNJO8GrnIlthdn5/MCWfHxBAMyMfvkFIoECZa7uxGN5qa6+dEFf8G3FPSxNVVGrwwaCpElV7JZ4xnf8mOtMa8GDb5GvhF8DSQO+ScRNCb3BVKw2IZil99otpqqU823XiBj41hEf2iy/Ofgg+bzlE0E88909gBk2neC6Kx86AagAN3GsNIqepbSMMLT3R23ofUTZCkVz5lDq3vqujexhWWwG/NlSJM9ju7g==; 31:a+as8VJDPuSb6dLMpoGltOqbga++fw9buqy4KFWd2Xz2HVJSM9WiBcDfJu3QO4pB2ZUkUD4iaS8cZvOKw8mgD+21+AxENVRN2xdRqLYLCc+3zw5b39Sl1RiDHJSF0XdVimnR2ncXQLSke0JdknX01whyuitq30GAHqxb3HUzFLyJyvrX8/O9ZeL7j3HvjW+6oacAnT+DxUeRwJvYjn8Fcyey8/VSzDB5i7h6jfVmI1w= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:3kO9Lhcb4fKwarIhM0YP1Pf9gADMB1LCB3nbsIA8vTGVEl6Y4Ef7wG7nAZHKbYYPT8SCJQvx4idAGQLv8snmo9RQZah01oxSIZ8iH+psjBIvZ+NN7BQSTTwNLGoh5PQHjIqHTfuStVG19/k+YBXh5uKh5aAmkTx4PcP8GEFQaViVVWiVNx2f8rUpGpT1bBEaYqDdjZ/fAYLsrU6a3DbCwmX+xPLfjO/HJ9H413igfWZ/5clCS4xAnTWnyLuIVouTQQS2kBW7hh77E5eqdOhYPI2PE7ml8Z3Cfsy4kcDmx4j7bYEK2osCO0zpn/DrrY7eg/AayhEH5I1goOJejO4L5alAQ2yA2/FwyKCjWtC/mwpR5mYnOkPASs+4e5uUqbIJe65AzSxIWxYGUDErFA0e/DnyjELIKVcZFdR00chtBH+2dNXMOrcrkEpwCov7gHB5sGOSm5xCqTJbOtPRe/WZfeWM3WFN5WXatlAkK/p2pYHhaD+oQQBm7w22M0kf1gnhdDp7NDYZc41rFHjY5rTMrzXX9EeekxMFbqURBOjRyswDVgFKzW8P/bbYgLcnVLfu6fMQFGghWqe84FuoSUcGX/HDA8Lgf2Y7pEBcrkV/640= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(166708455590820)(189930954265078)(58145275503218)(45079756050767); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(3002001)(93006095)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 4:wXRXYYiGY0KMm8G4dh15whdxhWk1lkSLLR8iV0hIABkqQHPD9iPYA6vYHWXhu1hcac8frYO+YikDAwTtjtDWEHjnJrRXDdq86eAVCFDYy0vV5oHnwOwugWQF0cotVcQtEaczdUy23BjIAhXYJWqiK8s2nlwoU9ytUnl1qKz8KkjRjDHCe9fw8DLTa1IfETrdQxnvlZNv4P38JmCikEqOF9TWiTQ+IzCMh1V34sIOCWiiSra47ndZSxXd6tYDMxCwUU/PdRotYOsm721BhePLj3YduXvOsYLWgJn4M7OhsYDkhRxgYOyA3pFOdn2tCH3AXit1fl8c6FD69kSC4gGzzKPc8DXgwrsFWcT2ybtdN+MkQQ8rEWz/V89TRdWAjxJ1DSQReoA3cQ736xRHY2qTqBOSB3YLp5GvS/vvejX+Wt4PcyVDKXHMQcFFJLVHPq5cyrtJCV1QDQ2zuawUpvpoOg== X-Forefront-PRVS: 056929CBB8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(396003)(366004)(376002)(189003)(199004)(13464003)(33896004)(386003)(76176011)(53546011)(6246003)(6116002)(33716001)(26005)(23726003)(1076002)(68736007)(106356001)(305945005)(8676002)(55236004)(7736002)(3846002)(81166006)(81156014)(6496006)(52116002)(105586002)(8936002)(33656002)(97736004)(25786009)(966005)(47776003)(66066001)(72206003)(9686003)(50466002)(6306002)(53936002)(42882006)(6916009)(6666003)(2950100002)(55016002)(54906003)(93886005)(58126008)(45080400002)(229853002)(5660300001)(83506002)(186003)(16526019)(2906002)(478600001)(16586007)(316002)(4326008)(575784001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:t/nklTw6KCRqcvnOrr10ZPyAjNdTiCSpDyeX85XA9?= =?us-ascii?Q?IK5erEs/8RNp2jaecyjnv2MrcSZYG2JMNU1wn4q7VCLFaBxnZsIXch8gtn/e?= =?us-ascii?Q?CISg25Lhqz8fbY0notaannbMMv2H1gnpGf/FtJ7s9ocNrh1c4NpkGiV0AaC4?= =?us-ascii?Q?dHfDefei4HGZyrBq/nKtxpH6r1cygo7Wd/SowFuuaf4WwEUcLltQLLk5Obzm?= =?us-ascii?Q?pRirninrexdSSkmyWUU9PenfPXDpcoqFebhJWwG4g/F5QqVPDCIZRsjVZBOm?= =?us-ascii?Q?uqOleq/JxIXxHm5ngx1i22Z8T/WSdHkRq3xO/CpABTQNvRooMFqPpjQDcP3b?= =?us-ascii?Q?KQHYljmh72dHKBrvotMxDEiZGcFuEhDKYDIVlIQFgisAcuP5nfBWsQxiwqbG?= =?us-ascii?Q?Z7VRsB2xXlR9obngTGGeqld7vQNqCYoqya3pUT1k+nxSs19kaXrx9L1qEO5d?= =?us-ascii?Q?Df8JVxIzxIq3nhth8dbkOsuPo+xfIHU1gipVCTcxvWbCqc3jOu8iLjlHyRXB?= =?us-ascii?Q?tkuKXk96sbauJPS1DEZUgSoFdMfHhcnV2h1bAyz9XgeLl2qRDSLN+cSkdYOH?= =?us-ascii?Q?OiN3cPvaRvoyi5RAGWpqpewoHofxr4S8iAGuYvw+gQGuQ/j7mjAwqE08H7QL?= =?us-ascii?Q?mFmslBm4snLKCE3vwFBAYQyQCsM2bjrmCUOBQmOpGRfHp1QN16vo9AQUTqg1?= =?us-ascii?Q?+NChBTH6u881VovU1FqU4wvsoo1HRGbakU3O9X7/QVMZLUpDIex/xuEfehCK?= =?us-ascii?Q?j+VDpBbPQVFMVTEIasiKpxBk+4KkBMuHIFXCYflJK95ZhjUi2v17tt5gsW3m?= =?us-ascii?Q?Gz94vduMBc1j55j1YapfGnVm1fbgmh8v2F3FxsucAWpXlRWFfvacZkyaflNh?= =?us-ascii?Q?6gz307/loj6NWVO8NxjZE0NNacEncZHVDmxfNq/EAHTl3hS2WIpkE82k0S2V?= =?us-ascii?Q?kuD8gMjA8N4I7C1dRqCeIsXHsJcSa+MXrjCrJ7uYNV5dhIJXbjOH/hpKKyOk?= =?us-ascii?Q?U17oW8KCpj32Ww8E0BlWJHLxzFIRnq7MJL/jPgTakVAuEAKd/M/itvS4zE7P?= =?us-ascii?Q?QZlkx/XP9Yuw4JP+Qr9zalSYXLGzY22CT6i7F1DIMFGW9hLvSnAp0Y5hSIDL?= =?us-ascii?Q?+h6Yn2P3GE++M6Jpf2H5mjmHSBJ+LSSjKJMYo1zYDjeQqyLW6U/IHOAX5oYh?= =?us-ascii?Q?P+rXke0dp3xcpymhgOTe7/gphEe9p0IMYBYfyWiqArLW3ZvlV6GmAlTe9vZ2?= =?us-ascii?Q?qwnG3xuxmymeZ/JW2GEvu+HI2jifSq7IdXz4WjyukcshCuC7KeX2i8Lpr1uv?= =?us-ascii?Q?8B1urSjtys2araKsjp0KRHSbNw9EljveGXOMDrGO4Le8T56mYg+9UL2C2RbG?= =?us-ascii?Q?5pl+LQpOLYjMcgUyDDLizbhFF8x4zIkqDR2owg6+H/u8JY5wsmjmcBWVQh5k?= =?us-ascii?Q?pPFOa8MBAJcvG2wZn9t53WWyroK+OU=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:lseyYJuSx6C1SICk6WFaE59FdLFtOuNKbmoY3FVii362iLBK7ED6aBZSwyHZXb0l/DXLoPE6XUQXEsqQVE6DXfLQiTKNRRmj2bTp7iLNdo2CDBc8gqUCxGIee4nipKUoq+z3jWVY1nd8l+dywc15p2Qz6cqd8AhJlxgMMCtkc5ose8D5svbeu1mFpmvhEJTVtdbq8QddlcxdUWjRXz+gIZS9CgkUDmJNKHRqMCxRVzxbah2KPJC+p9b+U64Y05kClAC2Ov1kw+JhIRsoO1eCvbgksmtrxQi0xfrhcEZA7qCNgeAIKkU9+SWQ502p1tg3vlmHSKUznimZImOBDPHFE2ZCG+yRLC0poXqv2biqmSg=; 5:S64wbyHNaa1/Vv6q6iIaOb4kwwELSn5/l+IeZLApQ3lUDR0Stk0Y0bfzvjwoJbg8ms9+WcZW8gWxte8o+0DflaV6jFdXHKfdUup/i4NuN9zv0ovU1riXdzeZ7eRz/YrRigKuZQtgTO9smENB/qN8UZmaOTEbJPWwVNX2ctkMyxA=; 24:D0q7G7dyva8TiazB4L6hSkCv74YqsK9uEfHGkdvI59oGEVRfchsVLRmIH75N3mVY1GOhNWo7mAvaU5ot/vQqJBnMlbkwN8EB+6LnPUElfTQ=; 7:TkD16hC5XC3R9qvpC5UzuBg8GYXk2vqrNJVNvKpzoIiQhPhhuUVdlGSMkw3Xpf5hBc5fsi18D0Hl2aqCyHcupn1JY0QM6EjsD8l5a0V7/51+I+wNtUMJ3WbiA92iRgRm3d7pYY9cjr7WRNUzRaKpUi1bQkWppDOGjidMR5kuINNWSBEzQnam44waiI0KRd2zNIApF9LJ0vHCetACiE6JAXVMk/TOPim5AfrCHIg/Z9HeE9dB7bHMCnWg5Yhd+D0L SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2018 12:41:13.6251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79cbbafa-fbd5-4e9b-33d8-08d568a7eb68 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 12:41:18 -0000 -----Original Message----- > Date: Wed, 31 Jan 2018 11:57:10 +0000 > From: Ophir Munk > To: Jerin Jacob > CC: "dev@dpdk.org" , Thomas Monjalon , > Pascal Mazon , Jan Viktorin > , Jianbo Liu > Subject: RE: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, January 31, 2018 1:31 PM > > To: Ophir Munk > > Cc: dev@dpdk.org; Thomas Monjalon ; Pascal > > Mazon ; Jan Viktorin > > ; Jianbo Liu > > Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > -----Original Message----- > > > Date: Wed, 31 Jan 2018 10:38:32 +0000 > > > From: Ophir Munk > > > To: Jerin Jacob > > > CC: "dev@dpdk.org" , Thomas Monjalon > > > , Pascal Mazon , > > Jan > > > Viktorin , Jianbo Liu > > > Subject: RE: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > > > Hi, > > > Please see inline > > > > > > > -----Original Message----- > > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > > Sent: Wednesday, January 31, 2018 12:24 PM > > > > To: Ophir Munk > > > > Cc: dev@dpdk.org; Thomas Monjalon ; Pascal > > > > Mazon ; Jan Viktorin > > > > ; Jianbo Liu > > > > Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > > > > > -----Original Message----- > > > > > Date: Wed, 31 Jan 2018 09:59:45 +0000 > > > > > From: Ophir Munk > > > > > To: Jerin Jacob , "dev@dpdk.org" > > > > > > > > > > CC: Thomas Monjalon , Pascal Mazon > > > > > , Jan Viktorin , > > > > > Jianbo Liu > > > > > Subject: RE: [dpdk-dev] [PATCH] net/tap: fix build issue with > > > > > ARM32 > > > > > > > > > > Hi, > > > > > Please see comments inline > > > > > > > > > > > -----Original Message----- > > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > > > > > Sent: Wednesday, January 31, 2018 7:14 AM > > > > > > To: dev@dpdk.org > > > > > > Cc: Thomas Monjalon ; Jerin Jacob > > > > > > ; Pascal Mazon > > > > > > ; Jan Viktorin > > > > > > ; Jianbo Liu > > > > > > Subject: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > > > > > > > > > arm32 Linux does not support eBPF interface. > > > > > > Since tap PMD driver has a dependency on eBPF(the symbol > > > > > > __NR_bpf), disabling it armv7 config. > > > > > > > > > > > > compilation error log: > > > > > > In file included from /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:15:0: > > > > > > /tmp/dpdk/drivers/net/tap/tap_bpf.h:103:4: error: #error > > > > > > __NR_bpf not defined # error __NR_bpf not defined > > > > > > ^ > > > > > > > > > > arm architecture is missing is file drivers/tap/tap_bpf.h I > > > > > suggest adding it, for example > > > > > > > > > > # elif defined(__arm__) > > > > > # define __NR_bpf 386 > > > > > > > > By looking at Linux source code > > > > > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fel > > > > ixi > > > > r.free- > > > > > > electrons.com%2Flinux%2Fv4.15%2Fsource%2Ftools%2Fbuild%2Ffeature%2 > > > > Ftest- > > > > > > bpf.c%23L6&data=02%7C01%7Cophirmu%40mellanox.com%7C19f50ad7f27 > > > > > > 34d00173808d56894c997%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0% > > > > > > 7C0%7C636529910613736017&sdata=ynsxHG9fvao4LyfWLo4GVJjlKNmcF0q > > > > 0BkFocJyarAE%3D&reserved=0 > > > > I am not sure, Is eBPF support available for arm32 support? > > > > > > TAP eBPF has a graceful approach: it must successfully compile on all > > > Linux distributions. If a specific kernel cannot support eBPF it will > > > gracefully refuse the eBPF netlink message sent to it. > > > Thus, there is no harm even if there is no eBPF support available for arm32. > > > > OK. But, To enable grace full refuse, we should not any random system call > > number like #define __NR_bpf 386. > > It should at least unused for arm32. > > > > For arm - system call 386 seems to be used only for eBPF > http://elixir.free-electrons.com/linux/v4.15/source/arch/arm64/include/asm/unistd32.h#L796 > > > > > > > > You should enable TAP compilation for cases where you only need TAP > > without eBPF. > > > > Yes. It would have been better if new eBPF depended features would have > > under conditional compilation flag so it it can be turned off selectively. > > > > I am in favor of keeping configuration as simple as possible if possible. > I will issue a PR which includes arm BPF definition OK. Looks like systemd is using the similar method. https://github.com/systemd/systemd/blob/master/src/basic/missing_syscall.h#L334