From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id CCFAA1B7D0 for ; Wed, 31 Jan 2018 16:33:19 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id v71so8826967wmv.2 for ; Wed, 31 Jan 2018 07:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GZHxjN1lIolb8IzFPVYf+JR+CmwHlUKGFIVB2NshpjY=; b=VTba/qV9eRylJ4CwWOdN38IhcS3be3cXtsu+t3FrYabV96cQ1/SIjnBFU0aQ+Wz1Yw Cqw8Q66XihyeXtNVmGnCiUa1cdYvTwn33f0nidRQje1HI6Xo5pHN+m4biaTDPlJA7bO5 MO/qPFYV75bNBq9tys7tCgmr8nsVdGXtRE4B29zVYiuFoSMueEs3Q6P+H7aFWqpfoPOS QmZCwX7LhfA0qWVtbLXXRTPX4aDydjrjqAxSyzmTSl6dVQB1qg2m630YA2deFSG+jT1i SLOuOESJm5eb7AlSPblLy4kJ1f6tjUc07wkRh30irYbkFiK8VjrjhCOTaYVY509ISh7Y ZTeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GZHxjN1lIolb8IzFPVYf+JR+CmwHlUKGFIVB2NshpjY=; b=sKbwi/sESG+YqNCzO/Y+Nv52sefJlNBsAMH94iCJH+wVQl1xCNHQ2Cw+OxNxw92b8r bzLyo1kzXTg/ZjcAyqNdNzfXZkfUjIrpF1JxXoJV8ihzRS7ENbb1dKHf7MAfGRPp7qGP r6+gEYtZ8iN4zRc4Eo9EsDmYokkf4pSCBT9loxUW2JkIqngpQJ/o/VrWyWzWmgDmvaQW NNxMKjs1dbPBEjIf8uPwKMLhUeoWdrZ6guYiops59S8zQ3uiWUpsGZszRt1zKPlkq8GG EStSJkuWjlsY/u1XgLXkUFSiA3qYavGulDYtQch1gi2GnsJqMCJGxTg8ahnpheeLFPdg 2Z5g== X-Gm-Message-State: AKwxytf7VV25ArTm9+09vhuQBxLBGbx9WAbDWPV/ue/o0XbLblx2iEjz 86cLmruWAQsVJzUY0DqXwkCn6Wmh X-Google-Smtp-Source: AH8x225Wa2XR3UJdASD3jwRWrETsRiup8/eiAC3hxhUmZA0n9Yre36wG8hNd2xU+xteSAvAEPfQD8Q== X-Received: by 10.28.29.81 with SMTP id d78mr25982366wmd.65.1517412799555; Wed, 31 Jan 2018 07:33:19 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k7sm17155752wrg.38.2018.01.31.07.33.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 07:33:18 -0800 (PST) Date: Wed, 31 Jan 2018 16:33:06 +0100 From: Adrien Mazarguil To: Shahaf Shuler Cc: Moti Haimovsky , dev@dpdk.org, stable@dpdk.org Message-ID: <20180131153141.1289-1-adrien.mazarguil@6wind.com> References: <1517327640-182072-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517327640-182072-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v2] net/mlx4: fix drop flow resources not freed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 15:33:19 -0000 Resources allocated for drop flow rules are not freed properly. This causes a memory leak and triggers an assertion failure on a reference counter when compiled in debug mode. This issue can be reproduced with testpmd by entering the following commands: flow create 0 ingress pattern eth / end actions drop / end port start all port stop all port start all port stop all quit The reason is additional references are taken when re-enabling existing flow rules, a common occurrence when rehashing configuration. Fixes: d3a7e09234e4 ("net/mlx4: allocate drop flow resources on demand") Cc: stable@dpdk.org Reported-by: Moti Haimovsky Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 8b6f8a01d..3a195b17a 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1058,6 +1058,8 @@ mlx4_flow_toggle(struct priv *priv, flow->drop = missing; } if (flow->drop) { + if (flow->ibv_flow) + return 0; mlx4_drop_get(priv); if (!priv->drop) { err = rte_errno; -- 2.11.0