From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 91A8A2D13 for ; Thu, 1 Feb 2018 11:18:27 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r71so4765335wmd.1 for ; Thu, 01 Feb 2018 02:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tnyJAZOdjjM1gCYBjzhMET5vaohmV3G/Prwt0lMHRqg=; b=fbWWsFCxVvQ/7XYr/z70t56RB1aGvPSbZdfTxi0An9EqbGQtR+0e1xNhFBAPaM8FCE ZLuvZ7oEX0OCCCUVCBfqddQHDhLDdUT3IvDeQx4RM69imYxsDQfi08X5d1GJImL767J+ a7QEYRwMkE/RCml2c/JYQlOMDbgvYU+gwwMGX+ObcK38wJZU3XlZgUWPpXbwWXeQOrAn 02e6qIoBzoe1uZLOUSVU1fC9AxFjeJTJ2vyG8o7nyBADrt65RuiE8PCHDKGTXt4qz99P DcJzIaoM+2/Ctx2gA16RJ0O9DPsYhP0KcPjFOgZwRmvwS9AKqSAlDSHBtcLV7dgeT2DZ RF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tnyJAZOdjjM1gCYBjzhMET5vaohmV3G/Prwt0lMHRqg=; b=VBuQjHL0rK6D6Wb4HeCyDuhS418/OeVwKUrSJ1MlED6ps7dLLS1f6o4BqIYyXJoNR8 FY9EAo0NkKLZE7zjIHAvaw2IdD3tU95QAC0s5smSO/vRN/34rcv9dGoyGPj216R2bDOu ojFXF4STpQB70bN91LbQc24ouJex48yZBsMU+5HUh03alVO0CQ1PS7r6wkaY3HB0mWVp bBmmSl/xrlRJ9YOn5asLXbRssFHhCZGkkuI+je/9iWqBaXQUwGOzqj4seyBCqM5iZoB4 j4A80Y6PbmzvZGP+6S3SllrMO+cT0Htz2Qr5FaKwVNijH4kTAf2OuFy0VLRZBF6i9mz9 d1Rw== X-Gm-Message-State: AKwxytdY19n0C+kLmO3elfywiOMSSUgbcBzVkGYe8mBA9QdXB9usTo7N XW7jb4WbDSpoq736f5WZgVrZPZ2n X-Google-Smtp-Source: AH8x226AC2kG9Av+5+HLaMD55wi4lqEWA5tjr8OX1IbwxygyIBHIl/e8k7wCoOXpZJyC15ZX5ASDhA== X-Received: by 10.28.166.20 with SMTP id p20mr25063701wme.85.1517480306747; Thu, 01 Feb 2018 02:18:26 -0800 (PST) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 137sm2093942wmm.46.2018.02.01.02.18.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2018 02:18:25 -0800 (PST) From: Gaetan Rivet To: dev@dpdk.org Cc: Matan Azrad , Gaetan Rivet Date: Thu, 1 Feb 2018 11:18:01 +0100 Message-Id: <20180201101801.10295-1-gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v1] net/failsafe: fix strerror call in sub-eal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 10:18:27 -0000 Ownership API returns a negative value, strerror expects a valid errno value, thus positive. CID 260401: Error handling issues (NEGATIVE_RETURNS) "ret" is passed to a parameter that cannot be negative. Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_eal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index 8946bf6fe..c3d673125 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -79,9 +79,9 @@ fs_bus_init(struct rte_eth_dev *dev) " %d named %s", i, da->name); } ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner); - if (ret) { + if (ret < 0) { INFO("sub_device %d owner set failed (%s)," - " will try again later", i, strerror(ret)); + " will try again later", i, strerror(-ret)); continue; } else if (strncmp(rte_eth_devices[pid].device->name, da->name, strlen(da->name)) != 0) { -- 2.11.0