From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BD8F3A49C for ; Thu, 1 Feb 2018 15:46:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3B56220C39; Thu, 1 Feb 2018 09:46:53 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 01 Feb 2018 09:46:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=6vYRqw1CM14TYPZKF/pzZA1G8JJ0G9pCp9khAH3Ao+o=; b=LRCtBG0E 4R3h5EfAA2gkdLxh8SMRP+61f1lahxISttwxdy8SCjKZPffLjPjb30BuiWHTBEdq Jz3hF6nSPbgXK4Pj4y2X7uV6QCYDknXZN+DvTvOXPblLxO+dM+wQhTVVSTDsAnjn E8EI1DHXTgykKoAJ2d3ID/X2KnnfG4ZZpYP86WrRaReRyMQzJ10wtATU4ISfp0y4 Cz/08neL6JuGYvgZE6qJwpxfmL03saf39L9D8K+nwHg7iVObMaKxf38wC/RdrMOX InzABJt5dTqhGpp+6rFgg7LG79ywY/0CbQUBdFoyLyIeSr9bGjA7rpSO+r/p3zrm OtwoPZqXjt4SVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=6vYRqw1CM14TYPZKF/pzZA1G8JJ0G 9pCp9khAH3Ao+o=; b=M3+CUUbyEiZyVQUw1U48T3pul4x7MovKmoGkq1AQhw2qx DJufx6hNQAgv1YLUV7QDXJ/nB6nVRc/wcmfD+GjPCWl/fDI+IikxDFqOhs+jjFvN JVTJ47hzawc9fYYb/G8VQ2UNPAP79FPILJSdv1ek+kAPA/HlIJ7rVnt6eW1YcTyx H5wm2SV0/k4W2jWYwBVvvgDOQB+PWgIB0owjbVBW+fonXZgIQdRr4ZXu7gJofmpI kvmj/7VfYsxTHoYGN1hIDPW8Rb05PWMkZ8/2jL9Ju8tVOW2Z465a4QfJaGteP9Ai 1GWMtcd7dWTsVCz3usMrXJewFrvDMleMfeMRbOpRg== X-ME-Sender: Received: from yliu-mob (unknown [115.150.27.200]) by mail.messagingengine.com (Postfix) with ESMTPA id 070C67E3D5; Thu, 1 Feb 2018 09:46:51 -0500 (EST) Date: Thu, 1 Feb 2018 22:46:48 +0800 From: Yuanhan Liu To: Stefan Hajnoczi Cc: dev@dpdk.org, Maxime Coquelin Message-ID: <20180201144648.GQ29540@yliu-mob> References: <20180131174651.6386-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180131174651.6386-1-stefanha@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 14:46:53 -0000 On Wed, Jan 31, 2018 at 05:46:49PM +0000, Stefan Hajnoczi wrote: > These patches fix a recent regression in librte_vhost that breaks the > vhost_scsi example application. vhost_user.c assumes all devices are vhost net > backends when handling the VIRTIO_NET_F_MQ feature bit. The code is triggered > by vhost scsi devices and causes virtqueues to be removed. See Patch 2 for > details. > > Patch 1 puts the infrastructure in place to distinguish between the built-in > virtio_net.c driver and generic vhost device backend usage. > > Patch 2 fixes the regression by handling VIRTIO_NET_F_MQ only when the built-in > virtio_net.c driver is in use. > > Stefan Hajnoczi (2): > vhost: add flag for built-in virtio_net.c driver > vhost: only drop vqs with built-in virtio_net.c driver Series Acked-by: Yuanhan Liu Thanks. --yliu > > lib/librte_vhost/vhost.h | 3 +++ > lib/librte_vhost/socket.c | 15 +++++++++++++++ > lib/librte_vhost/vhost.c | 17 ++++++++++++++++- > lib/librte_vhost/vhost_user.c | 3 ++- > lib/librte_vhost/virtio_net.c | 14 ++++++++++++++ > 5 files changed, 50 insertions(+), 2 deletions(-) > > -- > 2.14.3