From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0E640A488 for ; Thu, 1 Feb 2018 15:47:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9F53420C39; Thu, 1 Feb 2018 09:47:46 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 01 Feb 2018 09:47:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=Zo1t9Vhg7o9y1qjhrTVqOn7gn23kr5ZE+scqu0EGEkU=; b=t0sq34sg AxIanzmwaV/63fnTV6DTNHlPh1ohiaCRxhv3VuMxKOfghVI9K2panAK0M72g2n3/ N4R0p5MXmVbHTOF6qyrNYJx96IE4X01ryiPoJYfzNEzTc1yukSURmFWnpIDZB7/s kjaLh5kIM1ITJh4zwdiNyKNCuBeVcJuot8npmFjFb876cDhw1yE8eny7YNH0zIF4 TJaCccxbvpD7IxXbWgHsPjWk6oBLbRtxJ5JXJENLIdSNkx3Qs/3PriTZO1KZPFjK OcMngin+ucPhXhQuUSgYNYyIOMFIwG1a+8dibnblhQpr+enU0SgmKIIi2A8IR1T6 kmKWPnQSRx5J/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=Zo1t9Vhg7o9y1qjhrTVqOn7gn23kr 5ZE+scqu0EGEkU=; b=WrefRi81Y04vO0KWo1X0uAcQhlM7JkFjNNTRYFXOnHPC0 mUnBuYiQ+mVgdSFUpigAwoorpLJUlHQVvB4xT9v1dK+dHr7u34+JpPlYrjz9Y0Cm OHpC1tpHEOqtzLhwUBotflxvYprftMYpeeZpV8+yq2Zb7TS/1o0ySo6XXqfvA8tc UTFoqqfKeHhSYfLkdxKOaeliNmolQ0tiT3/QdmJf61oxC9IVLlUDIg7O3/YZxCOf zrT0+Z9DtEcdEvMSMeReBELuCOBr0TBkWZNvAjwl2gDHYMF9KX2v9rwTxHodzsYX y1uoZbbVo2yeL32sEXws0xoLItcOBVc3vwvQpHU1w== X-ME-Sender: Received: from yliu-mob (unknown [115.150.27.200]) by mail.messagingengine.com (Postfix) with ESMTPA id 898027E3D5; Thu, 1 Feb 2018 09:47:45 -0500 (EST) Date: Thu, 1 Feb 2018 22:47:42 +0800 From: Yuanhan Liu To: Stefan Hajnoczi , Thomas Monjalon Cc: dev@dpdk.org, Junjie Chen , Changpeng Liu , Maxime Coquelin Message-ID: <20180201144742.GR29540@yliu-mob> References: <20180131174828.6936-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180131174828.6936-1-stefanha@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 14:47:47 -0000 On Wed, Jan 31, 2018 at 05:48:28PM +0000, Stefan Hajnoczi wrote: > The vhost_scsi example application negotiates the > VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing > vrings. > > In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: > support virtqueue interrupt/notification suppression") broke vring call > because vq->last_used_idx is never updated by vhost_scsi. The > vq->last_used_idx field is not even available via the librte_vhost > public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the > built-in virtio_net.c driver in librte_vhost. > > This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring > call works again. > > Cc: Changpeng Liu > Cc: Junjie Chen > Signed-off-by: Stefan Hajnoczi Acked-by: Yuanhan Liu Thanks. --yliu > --- > examples/vhost_scsi/vhost_scsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c > index da01ad378..3cb4383e9 100644 > --- a/examples/vhost_scsi/vhost_scsi.c > +++ b/examples/vhost_scsi/vhost_scsi.c > @@ -21,7 +21,6 @@ > #include "scsi_spec.h" > > #define VIRTIO_SCSI_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |\ > - (1 << VIRTIO_RING_F_EVENT_IDX) |\ > (1 << VIRTIO_SCSI_F_INOUT) |\ > (1 << VIRTIO_SCSI_F_CHANGE)) > > -- > 2.14.3