From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 78AB22BE1 for ; Thu, 1 Feb 2018 16:04:56 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 07:04:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,444,1511856000"; d="scan'208";a="31208129" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga002.jf.intel.com with SMTP; 01 Feb 2018 07:04:52 -0800 Received: by (sSMTP sendmail emulation); Thu, 01 Feb 2018 15:04:51 +0000 Date: Thu, 1 Feb 2018 15:04:51 +0000 From: Bruce Richardson To: Marko Kovacevic Cc: dev@dpdk.org, john.mcnamara@intel.com, vipin.varghese@intel.com Message-ID: <20180201150451.GA15912@bricha3-MOBL3.ger.corp.intel.com> References: <20180131164646.16603-1-marko.kovacevic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180131164646.16603-1-marko.kovacevic@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v1] doc: update definition of lcore id and lcore index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 15:04:56 -0000 On Wed, Jan 31, 2018 at 04:46:46PM +0000, Marko Kovacevic wrote: > Added examples in lcore index for better > explanation on various examples, > Sited examples for lcore id. > > Signed-off-by: Marko Kovacevic > --- > lib/librte_eal/common/include/rte_lcore.h | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h > index d84bcff..349ac36 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -57,7 +57,9 @@ RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread "lcore id". */ > RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread "cpuset". */ > > /** > - * Return the ID of the execution unit we are running on. > + * Return the Application thread ID of the execution unit. > + * If option '-l' or '-c' is provided the lcore ID is the actual > + * CPU ID. Good idea to clarify this! I'd suggest the second sentence might do with being reworked a little though - the lcore ID will also be the processor id even if no args i.e. no -c or -l arguments are passed. How about: * Note: in most cases the lcore id returned here will also correspond * to the processor id of the CPU on which the thread is pinned, this * will not be the case if the user has explicitly changed the thread to * core affinities using --lcores EAL argument e.g. --lcores '(0-3)@10' * to run threads with lcore IDs 0, 1, 2 and 3 on physical core 10. It's longer, I know, but hopefully a bit clearer for the user. /Bruce