From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1AECB2B8B for ; Fri, 2 Feb 2018 06:12:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 21:12:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,445,1511856000"; d="scan'208";a="198072216" Received: from wuyanglong.sh.intel.com ([10.67.110.174]) by orsmga005.jf.intel.com with ESMTP; 01 Feb 2018 21:11:59 -0800 From: Yanglong Wu To: dev@dpdk.org Cc: shahafs@mellanox.com, wenzhuo.lu@intel.com, Yanglong Wu Date: Fri, 2 Feb 2018 13:09:50 +0800 Message-Id: <20180202050950.64400-1-yanglong.wu@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 05:12:03 -0000 Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and port_conf.rxmode.offloads is assigned as 0 again if hw_vlan_filter = 1. So it will always lead to fail for vlan filter setting Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..0751e573c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid, retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) return retval; - port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; + port_conf.rxmode.hw_vlan_filter = 1; /** * Write the configuration into the device. -- 2.11.0