From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C249C5593; Mon, 5 Feb 2018 11:00:45 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 02:00:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,464,1511856000"; d="scan'208";a="17102572" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by fmsmga002.fm.intel.com with SMTP; 05 Feb 2018 02:00:42 -0800 Received: by (sSMTP sendmail emulation); Mon, 05 Feb 2018 10:00:41 +0000 Date: Mon, 5 Feb 2018 10:00:41 +0000 From: Bruce Richardson To: Marko Kovacevic Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com, vipin.varghese@intel.com, stable@dpdk.org Message-ID: <20180205100041.GA19876@bricha3-MOBL3.ger.corp.intel.com> References: <20180122105905.6996-1-marko.kovacevic@intel.com> <20180205095353.16245-1-marko.kovacevic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180205095353.16245-1-marko.kovacevic@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v2] mk: support renamed Makefile in external project X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 10:00:46 -0000 On Mon, Feb 05, 2018 at 09:53:53AM +0000, Marko Kovacevic wrote: > The build system made a recursive call to "make" after > creating the build directory. This recursive call used > the hard-coded filename "Makefile", which prevented > builds from working if the file was renamed and make > called using "make -f". Taking the filename from > MAKEFILES_LIST make variable fixes this. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Marko Kovacevic > Acked-by: Vipin Varghese > > --- > V2 > - Changed the call of the make file a litte > due to an issue reported by Olivier. > --- > mk/internal/rte.extvars.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk > index 94f27e9..98c8606 100644 > --- a/mk/internal/rte.extvars.mk > +++ b/mk/internal/rte.extvars.mk > @@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line") > RTE_EXTMK := $(abspath $(M)) > endif > endif > -RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile > +RTE_EXTMK ?= $(RTE_SRCDIR)/$(notdir $(firstword $(MAKEFILE_LIST))) > export RTE_EXTMK > > # RTE_SDK_BIN must point to .config, include/ and lib/. > -- Since the V1 of the patch was already applied, I think this needs a new patch on top of (i.e. fixing) the V1, rather than a V2 version. /Bruce