From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9A6B51B2B8 for ; Mon, 5 Feb 2018 12:24:16 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b21so25153630wme.4 for ; Mon, 05 Feb 2018 03:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4vlz49HY8IXBdhPsuIJViQONiYSgKE/Xo7Io9M1VHPI=; b=kILiHZrixClFQzs3cTa78YEFLBrRR0TBXzzAebe3ptQ8kubhYrHcne446Y+Cvt2r4x L4iN/fi2qfohpmQmnMDOKTb6Fywb3J75/auVa1cZE6zfNW3zITUFPQ4MHFHZYhoXLEUs 8hLFlqBFL1s7vEGPkunYSHuvTr5/VZ/qjUQiQ0TX7EaSwKoPz4OaT9qK9kO2eHcpwHAu kH7R99esuPnmo4HV/iJZeiL84SZ0F90nW/cUR07335K2e/t1CbWuxgdFdsF0pRo1Uh++ tMJPDXIVP5yMN44D+gAFd9+1bHKbm2J+N8t4eViaRTqw/msG53iJ5uo4vtl0F2d6Mg3z cPXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4vlz49HY8IXBdhPsuIJViQONiYSgKE/Xo7Io9M1VHPI=; b=tHrBZffZ55ZKWkRkQzKoblnL9m2lmk1nqLAED0Hmfc6aqkaQ48rYlXFLx2EzM1nvhT +0REHehiryUnNvi12LhxjYtXHZzjjByvTFuJX8q4kpgmff6ZWqMdGWNzdvKJDM98RCu8 BYadvFhEqFhqgQtvfOKiact59Cqni1Ieb0KNgefHukaAKQjgqP+i0n5EalHSEgipWgj2 Bhn3mu+cUwH9GbCSlBta1mhi4ZmWrT0mq8BvpF8q8zfNyAbvQ5MNbuEz1lzcI3ysM/SS OU9EqWuzdoSjridBGlwusGlFhnQ8Yl2aLl7Zodwc2Nvfyp5AMxgcci/3oORo+DjtVmDp gQBg== X-Gm-Message-State: AKwxytd8jUOy2xu5fTh7TUG9Mu3gZ3SzPw8kjkdPmL18lgtufgaxi77P yeka78eHoJ067Yi7UrbPDIAPbQ== X-Google-Smtp-Source: AH8x227eFURQTVDniaAI1wUdk6V8R7gUaZFZNTeaFkQETaNhkjfGrqnfbcFDEnpqd+I6B3HlPBXRGA== X-Received: by 10.80.201.134 with SMTP id w6mr77182063edh.22.1517829856142; Mon, 05 Feb 2018 03:24:16 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o47sm7730314edc.10.2018.02.05.03.24.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 03:24:15 -0800 (PST) Date: Mon, 5 Feb 2018 12:24:02 +0100 From: Adrien Mazarguil To: Thomas Monjalon Cc: dev@dpdk.org, Shahaf Shuler , Nelio Laranjeiro , Marcelo Ricardo Leitner Message-ID: <20180205112402.GE4256@6wind.com> References: <20180202144736.8239-1-adrien.mazarguil@6wind.com> <20180202164050.13017-1-adrien.mazarguil@6wind.com> <20180202164050.13017-4-adrien.mazarguil@6wind.com> <6047554.pbob4v6vxF@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6047554.pbob4v6vxF@xps> Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 11:24:16 -0000 On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote: > 02/02/2018 17:46, Adrien Mazarguil: > > --- a/drivers/net/mlx4/Makefile > > +++ b/drivers/net/mlx4/Makefile > > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > > > > # Library name. > > LIB = librte_pmd_mlx4.a > > -LIB_GLUE = librte_pmd_mlx4_glue.so > > +LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) > > +LIB_GLUE_BASE = librte_pmd_mlx4_glue.so > > +LIB_GLUE_VERSION = 18.02.1 > > You should use the version number of the release, i.e. 18.02.0 > Ideally, you should retrieve it from rte_version.h. Keep in mind this only needs to be updated when the glue API gets modified, and this "18.02.1" string may remain unmodified for subsequent DPDK releases, probably as long as the PMD doesn't use any new rdma-core calls. We've already backported this patch to 17.02 and 17.11, both requiring different sets of Verbs calls and thus a different version, hence the added "18.02" as a starting point. The last digit may have to be modified possibly several times between official DPDK releases while work is being done on the PMD (i.e. per commit). In short it's not meant to follow DPDK's public versioning scheme. If you really think it should, doing so will make things more complex in the Makefile, which will have to parse rte_version.h. What's your opinion? -- Adrien Mazarguil 6WIND