From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 1BA3F1B344 for ; Mon, 5 Feb 2018 13:28:11 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id v31so29353225wrc.11 for ; Mon, 05 Feb 2018 04:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=X4NiKqRV2IEtBx0/grpNU6ElFbnFZamYB2gQVAeNCuo=; b=vk33rBUx7Uo70bvIQ2UV8DqxJXJtsqKnWnfxlQxNibRy7eXdbcfQEurVGfe0/UVmCu R/nBMTkTtl1Bj30zZzC/rfSuEbsmPPznQYigODHwPv4Oh03z4dgT/mGF/tZ+o1xx/frl 0RtnIFozIks7enwJLJ9z4pCFu5gfeKgxo2PcuF9cJ0djFJlZrOdAe/RJiIabIRlm6Oo4 nRVGTwy+UzXsefwvFLD8hP2hK1+OLkayWBHE79VoopHY08bqH+6OrlY4P7eTYdLywLiV LwyBw8KCf5KUlkrhXHBptH/h3wnBz3gqSFUrb0AAERLArLpdhJaDZJF2Yb3eZYUCN1ld DEmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=X4NiKqRV2IEtBx0/grpNU6ElFbnFZamYB2gQVAeNCuo=; b=qpry7L7XToFaK/fmHdo47r70PwP5T67SStl9ZRCpfTLG+gPbQJzdUrH9XkNpkA+e1E BIcv6DTpkVOfpezKbhgTbr+WqEMX2Qs3+o8MWdakfliKpu1PYX6MbVl1dnEdp63GIxrO fa4ZuQYOtRWyfxBCJgk/ghECEo4FcAPq8Bmo3B2IRBNrQ0ETGgJe2/fPINHj6gguP2sS R9wcrPqcnXWilFeg/nZdSwDkUYLpQd+5TVYhw1R5mSUXnrIOGsDLQErJEWVd6cvswM1E mXd1GA7rkrzkzflOuIkNw6BQn3DTBYCLTu+bEryJaiOkmignV8KSatk101mgAz3hKKNB heCQ== X-Gm-Message-State: AKwxytchQ4EbCSXJH4qqiJUdgEKMBJv4kVXQG3P63CSV4CfM0vBBH2YR Hsm5qgH4MKdT0JW62WMSPrlA X-Google-Smtp-Source: AH8x224GhzG/WzmsPQU89zibvOrHsjmbby69ddzIIxWlEqfSiKavfzdrgvfjle2fNzaIM4MHwCb37A== X-Received: by 10.223.169.110 with SMTP id u101mr33003606wrc.228.1517833690822; Mon, 05 Feb 2018 04:28:10 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q1sm4206713wrf.40.2018.02.05.04.28.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Feb 2018 04:28:10 -0800 (PST) Date: Mon, 5 Feb 2018 13:28:37 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yuanhan Liu Cc: dev@dpdk.org, Adrien Mazarguil , Yongseok Koh , Shahaf Shuler , stable@dpdk.org Message-ID: <20180205122837.g62yquxw6uzgh2mu@laranjeiro-vm.dev.6wind.com> References: <1517832104-2800-1-git-send-email-yliu@fridaylinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1517832104-2800-1-git-send-email-yliu@fridaylinux.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 12:28:11 -0000 On Mon, Feb 05, 2018 at 08:01:44PM +0800, Yuanhan Liu wrote: > When the link is down, mlx5 kernel driver reports the link speed as -1 > (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it > will be re-queried again due to the link_speed is not 0, due to following > code: > > 1201 if (((link->link_speed == 0) && link->link_status) || > 1202 ((link->link_speed != 0) && !link->link_status)) { > 1203 /* > 1204 * Inconsistent status. Event likely occurred before the > 1205 * kernel netdevice exposes the new status. > 1206 */ > > Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") > > Cc: stable@dpdk.org > Signed-off-by: Yuanhan Liu Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 6665076..492ca07 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -808,6 +808,10 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) > return -1; > } > dev_link.link_speed = ecmd->speed; > + if (link_speed == -1) > + dev_link.link_speed = 0; > + else > + dev_link.link_speed = link_speed; > sc = ecmd->link_mode_masks[0] | > ((uint64_t)ecmd->link_mode_masks[1] << 32); > priv->link_speed_capa = 0; > -- > 2.7.4 > Thanks, -- Nélio Laranjeiro 6WIND