From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id D0EFD1B628 for ; Mon, 5 Feb 2018 17:33:41 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id y3so20426990wrh.3 for ; Mon, 05 Feb 2018 08:33:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jhlO6U2WNzIKAvgBsEE82AMJJMO3B+7fUjkBcW6xTfc=; b=lhEGMHB6HhwcfRQhws6vF5FhjuuyKgkIguUZQ1reJhIMPA7e34gN/SHQcGECuQBEsm tJqT51+x8YPbMTNPF085G+9xBS+EC019lV6jJGPlAsCZw7XLIO/y7mYV1StEALRRl9NG BCkrY0Ll66tby+NXTghy9BKJlj3t2NhKD5TRZi/KTgK+csA0kgpeH1z/lkGsOC/N2rGW YsAVDwwlzKZkGPPa/o70eKthpKkaFXXS53rrLhrOJfCll8yXzMHi2cYVb6jj0gG11ZL4 3hMYRKdlhJvhV2708vtRRy5IVDFP2k83M4zUWf0jxekNYVoL09shjIyAXlWyvkhtrVjj RT6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jhlO6U2WNzIKAvgBsEE82AMJJMO3B+7fUjkBcW6xTfc=; b=pnjqlMkTMBo2tgPduLe9MCj7Fae/I7ztHj2Yh+w7tclxmDZsYR+5wHY9v8C4gpZwQB 92z2G89d1WdeRT7hNqnz3UPsJl8ZyFtJnFUWxzngwfFt9KSqUviOg50D5Y1g0pd/Vgws 3MD3sVNccqjxM+kijScs8MFt9BMGJWHTeB4Zmls5UmATfk1YSppBq6LGNdVDUTGJixkf NZnXSmQRy2tKAov4I+gWeqgXe9p1h9xmfw9mNPF7lyzZkLeUnqW7D2XC1CflHeh+X6Gd ybL+3Viox0OWRksQpYLxeB/xeEt6eI/nhE+odfO8woj9qHmw27up+VfNVdRY5ULwuNFF 91sA== X-Gm-Message-State: AKwxyte7u2ul7r+4yLRCLzJnPuM+QuHfm3gYDLuQ9xSd4Kxp2OBPyPfg tYCRCvmBVY6cjFRP5zGghzIyAQ== X-Google-Smtp-Source: AH8x226AYwwG6FNzH13EZmN/72tYx9cOsSC4CQcc3RnlsDgXu2TIJGFWad8xF4Qh+S9pphGDBZwubw== X-Received: by 10.223.144.198 with SMTP id i64mr28204021wri.6.1517848421295; Mon, 05 Feb 2018 08:33:41 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m11sm19742517wrf.75.2018.02.05.08.33.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Feb 2018 08:33:40 -0800 (PST) Date: Mon, 5 Feb 2018 17:33:20 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , stable@dpdk.org Message-ID: <20180205163320.kopsydr2a7ujbwcs@bidouze.vm.6wind.com> References: <1517846526-751-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1517846526-751-1-git-send-email-ophirmu@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: fix default Tx offloads capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 16:33:42 -0000 Hi Ophir, On Mon, Feb 05, 2018 at 04:02:06PM +0000, Ophir Munk wrote: > Failsafe reported Tx offloads capabilities are the AND result of its > default capabilities and those of its sub-devices. > In the corrupted code failsafe default Tx capabilities were set to 0. > As a result when running testpmd with "--tx-offloads=0x8000" parameter > (request for multi segments offload) - an error was returned: > > PMD: net_failsafe: > Some Tx offloads are not supported, requested 0x8000 supported 0x0 > > To fix this, failsafe default Tx offload capabilities are set to > DEV_TX_OFFLOAD_MULTI_SEGS | > DEV_TX_OFFLOAD_IPV4_CKSUM | > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM, > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk > --- > drivers/net/failsafe/failsafe_ops.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index e7bb801..7a67e16 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -77,7 +77,11 @@ static struct rte_eth_dev_info default_infos = { > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_TIMESTAMP | > DEV_RX_OFFLOAD_SECURITY, > - .tx_offload_capa = 0x0, > + .tx_offload_capa = > + DEV_TX_OFFLOAD_MULTI_SEGS | With the caveat that this offload above will not be backported to the stable branch this patch will fix, Acked-by: Gaetan Rivet Thanks, > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM, > .flow_type_rss_offloads = 0x0, > }; > > -- > 2.7.4 > -- Gaëtan Rivet 6WIND