* [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close
@ 2018-02-06 12:54 Xueming Li
2018-02-06 13:22 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Xueming Li @ 2018-02-06 12:54 UTC (permalink / raw)
To: Nelio Laranjeiro; +Cc: Xueming Li, dev, Shahaf Shuler
This patch fixed primary socket assertion error during close on a device
that failed to start.
Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index b66303d29..fb4463c2b 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -201,7 +201,8 @@ mlx5_dev_close(struct rte_eth_dev *dev)
rte_free(priv->rss_conf.rss_key);
if (priv->reta_idx != NULL)
rte_free(priv->reta_idx);
- priv_socket_uninit(priv);
+ if (priv->primary_socket)
+ priv_socket_uninit(priv);
ret = mlx5_priv_hrxq_ibv_verify(priv);
if (ret)
WARN("%p: some Hash Rx queue still remain", (void *)priv);
--
2.13.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close
2018-02-06 12:54 [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close Xueming Li
@ 2018-02-06 13:22 ` Nélio Laranjeiro
2018-02-13 15:56 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2018-02-06 13:22 UTC (permalink / raw)
To: Xueming Li; +Cc: Nelio Laranjeiro, dev, Shahaf Shuler
On Tue, Feb 06, 2018 at 08:54:22PM +0800, Xueming Li wrote:
> This patch fixed primary socket assertion error during close on a device
> that failed to start.
>
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index b66303d29..fb4463c2b 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -201,7 +201,8 @@ mlx5_dev_close(struct rte_eth_dev *dev)
> rte_free(priv->rss_conf.rss_key);
> if (priv->reta_idx != NULL)
> rte_free(priv->reta_idx);
> - priv_socket_uninit(priv);
> + if (priv->primary_socket)
> + priv_socket_uninit(priv);
> ret = mlx5_priv_hrxq_ibv_verify(priv);
> if (ret)
> WARN("%p: some Hash Rx queue still remain", (void *)priv);
> --
> 2.13.3
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close
2018-02-06 13:22 ` Nélio Laranjeiro
@ 2018-02-13 15:56 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-02-13 15:56 UTC (permalink / raw)
To: Xueming Li; +Cc: dev, Nélio Laranjeiro, Nelio Laranjeiro, Shahaf Shuler
06/02/2018 14:22, Nélio Laranjeiro:
> On Tue, Feb 06, 2018 at 08:54:22PM +0800, Xueming Li wrote:
> > This patch fixed primary socket assertion error during close on a device
> > that failed to start.
> >
> > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-13 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 12:54 [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close Xueming Li
2018-02-06 13:22 ` Nélio Laranjeiro
2018-02-13 15:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).