From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id D4CB11B425 for ; Tue, 6 Feb 2018 14:22:02 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id i56so1898732wra.7 for ; Tue, 06 Feb 2018 05:22:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=L2DTHM44f1wYnrJKNJRDsrI5gqpoQ2PCLu4QosTcsvw=; b=dl4CJbPzT9AKh5fVv7GTyOmPV+GSghBwEu2bkyJuVtuXwU2xxj14eO1y6aASJreakS jODuTrQhNfoq1lzXfshDJnr8IYnyMZfErFPNf/pY9ksw6J0muAWi2FeZPIqBV9yshOcU C79UG5ZQTuffRn+ru/8oN+NlbwAcq0kH/4xjrcNhIGVyja3SSdV+v/l2t0U7Bw4jtSr6 9NswEKML+FbBh5gjp67Zu0tZvDqBG5nVntrT7yaPNgWiX09VVnf5qdkCFPUQIaWJ6y7e 5VLZKzjeb89wMblpmMtodRMR6aH0Th6Q2mL84hBI+NWkHo1y2ZnjB3nlbxduCSzogTh0 Ivpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=L2DTHM44f1wYnrJKNJRDsrI5gqpoQ2PCLu4QosTcsvw=; b=ERbhPgDFCdXEm3aXi5nfC6j8XzXdnK31REv6bZSGTC3D4kl01kN+xkB6XLvDHN3UbZ kZXLEkfPA5PP+sBTwZFkDpdvpT25CGF4/JvCJoa83uERWC8PJXZiRT4+7guDpjax21zs a8GZxkaFRB1D3zYKjCYvba/mk+ttEXmzR3+CiqxxS3gwK1VqqV3yd6iwhjJU/zRIjdmR VycxJt0NyPwnoysUhvpRw09b1IYjBvgtF+P9Vrq3Kum6EFkbas50mfjq6lQ213c5R26U hOHlYiYhvtlWb71B7P0D5CB4S1fibUpCv/qytHMl2madYPFk12uTfQnPiQPhs71clZQ4 E9Rw== X-Gm-Message-State: APf1xPCY/in46p8Y/qJsD2qYknmsiK2oqAnHKysYpx6wdLpMzp7jD1xX DuegYFc+HXoVTFCPpLxOW14aAzrdWA== X-Google-Smtp-Source: AH8x225tHUp6Ic3IOSd153QIAtRQloapJVAieh8PloqZFEc9dlrcZiiiQT3xskY+rJVEs1NxohTo/w== X-Received: by 10.223.161.72 with SMTP id r8mr2095039wrr.55.1517923322631; Tue, 06 Feb 2018 05:22:02 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e67sm22435050wmf.7.2018.02.06.05.22.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2018 05:22:02 -0800 (PST) Date: Tue, 6 Feb 2018 14:22:31 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Nelio Laranjeiro , dev@dpdk.org, Shahaf Shuler Message-ID: <20180206132231.gbiqs226tzpqlrme@laranjeiro-vm.dev.6wind.com> References: <20180206125422.91117-1-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180206125422.91117-1-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix socket assertion error during dev close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 13:22:03 -0000 On Tue, Feb 06, 2018 at 08:54:22PM +0800, Xueming Li wrote: > This patch fixed primary socket assertion error during close on a device > that failed to start. > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index b66303d29..fb4463c2b 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -201,7 +201,8 @@ mlx5_dev_close(struct rte_eth_dev *dev) > rte_free(priv->rss_conf.rss_key); > if (priv->reta_idx != NULL) > rte_free(priv->reta_idx); > - priv_socket_uninit(priv); > + if (priv->primary_socket) > + priv_socket_uninit(priv); > ret = mlx5_priv_hrxq_ibv_verify(priv); > if (ret) > WARN("%p: some Hash Rx queue still remain", (void *)priv); > -- > 2.13.3 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND