From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 7BD541B7BE for ; Wed, 7 Feb 2018 07:49:31 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id r71so1029405wmd.1 for ; Tue, 06 Feb 2018 22:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VgBNmqiUgrsJ14ytgkL8C7o4OYKq80aTkG8YneI3kZU=; b=N5ozP8pp/0lDGCtDTF3V70Uht6suoEV9RcQ2IBbD0AFVitpAD59YH3vz/2gITA0t5Q +HEATd0ENTeZ14GWtJYZfMiZ9SwFpxChNpVKeumQUDTmPK+fg9EPrWbiCgqmFpJMhg47 WYMcqOGLw82hTRYPTQ9vYUjvImfuc4yLYDq+LW3/hNsaodDMyMPbF2taXf7Vgfwyi/Za W7m+pgq4x0OA13o3zDR1NwD6AE64OdQd326SYPpszAFiR68hHzcsQ5g+S/PtxDxX44DC LX3z1OAliBZKTlLLp8JWGK36avsCckBNzujlCwkw8x1DOATk45HFYlo38AxU/GuhzNru d62Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VgBNmqiUgrsJ14ytgkL8C7o4OYKq80aTkG8YneI3kZU=; b=irsx1x/yN7b+ulsRz9raBB6MhH4ZKVU/U8UDran5Aw4xsS0Y6BVsmqGr+/Q971SPcj v1ScenW5zNEGOuomtjj/bJw6RyiJHtAfFxqUdOGMN78kH87hJKBfOH6wo5OiIDXtZRN2 MAFGon2EB9mGATiA0WZiz9T6viOdHFDLnAsa70a/nfyEvvHjZD5Lr/GCznboURh5LcFO lYDwchdTvTIyXNeeVsB1MqmoeKyZmqp1l+/4y2nZ9k4GbUSmUEjn7NtBq/UrBGB31PEZ 9BvkAEyJx6vHaeW8f2hTKDcE2VoWtzmaY2jOkKA+hU79ZxZhATY5q1YvxtBj0A3Vnr59 QuUw== X-Gm-Message-State: APf1xPCEeA1rVbtahwXNAPXsEyoBBdZExiDVmkvB9N3AJROF3JRt5e36 b37FtnZzIQxANZE/M4VlEl/u X-Google-Smtp-Source: AH8x224D3fIXMwrNg14QGQxBoAL3gHTyvQqtA8/u8fs6Y2L+8tEiHAyQxFwJ1zpbrJPwqby5qmNFyA== X-Received: by 10.28.224.137 with SMTP id x131mr4020633wmg.60.1517986171191; Tue, 06 Feb 2018 22:49:31 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 63sm1929518wms.46.2018.02.06.22.49.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2018 22:49:30 -0800 (PST) Date: Wed, 7 Feb 2018 07:50:00 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Xueming(Steven) Li" Cc: Nelio Laranjeiro , "dev@dpdk.org" , Shahaf Shuler Message-ID: <20180207065000.ll4s4sw2rxcf23tg@laranjeiro-vm.dev.6wind.com> References: <20180206125253.91036-1-xuemingl@mellanox.com> <20180206132209.efxis4nxd2z2hg7o@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 06:49:31 -0000 On Tue, Feb 06, 2018 at 02:20:28PM +0000, Xueming(Steven) Li wrote: > Hi Nelio, > > > -----Original Message----- > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Tuesday, February 6, 2018 9:22 PM > > To: Xueming(Steven) Li > > Cc: Nelio Laranjeiro ; dev@dpdk.org; Shahaf > > Shuler > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message > > > > On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote: > > > Add error message dump when flow create error happened. > > > > > > Signed-off-by: Xueming Li > > > --- > > > drivers/net/mlx5/mlx5_flow.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > b/drivers/net/mlx5/mlx5_flow.c index e38452ef3..ea90556d0 100644 > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv, > > > DEBUG("Flow created %p", (void *)flow); > > > return flow; > > > exit: > > > + ERROR("Flow create error: %s", error->message); > > > for (i = 0; i != hash_rxq_init_n; ++i) { > > > if (parser.queue[i].ibv_attr) > > > rte_free(parser.queue[i].ibv_attr); > > > -- > > > 2.13.3 > > > > Hi Xueming, > > > > Can you move this debug message to mlx5_flow_create(). > > This function also called by control flow and fdir functions, > here should be the best place. Make sense, Acked-by: Nelio Laranjeiro Thanks, -- Nélio Laranjeiro 6WIND