* [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
@ 2018-02-07 14:23 Shahaf Shuler
2018-02-07 14:34 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-02-08 12:26 ` [dpdk-dev] [PATCH] " Nélio Laranjeiro
0 siblings, 2 replies; 6+ messages in thread
From: Shahaf Shuler @ 2018-02-07 14:23 UTC (permalink / raw)
To: thomas, nelio.laranjeiro, adrien.mazarguil, yskoh; +Cc: dev
Nor upstream kernel nor MLNX_OFED support such filter.
Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
doc/guides/rel_notes/release_18_02.rst | 1 -
drivers/net/mlx5/mlx5_flow.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 32067969f..0d4630335 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -94,7 +94,6 @@ New Features
* Improved multi-segment packet performance.
* Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs.
* Extended statistics for physical port packet/byte counters.
- * Supported IPv4 time-to-live filter.
* Converted to the new offloads API.
* Supported device removal check operation.
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 822705060..f88ece123 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
.dst_addr = -1,
.type_of_service = -1,
.next_proto_id = -1,
- .time_to_live = -1,
},
},
.default_mask = &rte_flow_item_ipv4_mask,
--
2.12.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] net/mlx5: revert support in IPv4 time-to-live filter
2018-02-07 14:23 [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter Shahaf Shuler
@ 2018-02-07 14:34 ` Shahaf Shuler
2018-02-08 12:26 ` [dpdk-dev] [PATCH] " Nélio Laranjeiro
1 sibling, 0 replies; 6+ messages in thread
From: Shahaf Shuler @ 2018-02-07 14:34 UTC (permalink / raw)
To: thomas, nelio.laranjeiro, adrien.mazarguil, yskoh; +Cc: dev
Neither upstream kernel nor MLNX_OFED support such filter.
There is no point announcing this feature.
Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
On v2:
- Changed commit log.
---
doc/guides/rel_notes/release_18_02.rst | 1 -
drivers/net/mlx5/mlx5_flow.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 32067969f..0d4630335 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -94,7 +94,6 @@ New Features
* Improved multi-segment packet performance.
* Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs.
* Extended statistics for physical port packet/byte counters.
- * Supported IPv4 time-to-live filter.
* Converted to the new offloads API.
* Supported device removal check operation.
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 822705060..f88ece123 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
.dst_addr = -1,
.type_of_service = -1,
.next_proto_id = -1,
- .time_to_live = -1,
},
},
.default_mask = &rte_flow_item_ipv4_mask,
--
2.12.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
2018-02-07 14:23 [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter Shahaf Shuler
2018-02-07 14:34 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
@ 2018-02-08 12:26 ` Nélio Laranjeiro
2018-02-08 14:35 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Nélio Laranjeiro @ 2018-02-08 12:26 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: thomas, adrien.mazarguil, yskoh, dev
On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> Nor upstream kernel nor MLNX_OFED support such filter.
>
> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> doc/guides/rel_notes/release_18_02.rst | 1 -
> drivers/net/mlx5/mlx5_flow.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
> index 32067969f..0d4630335 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -94,7 +94,6 @@ New Features
> * Improved multi-segment packet performance.
> * Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs.
> * Extended statistics for physical port packet/byte counters.
> - * Supported IPv4 time-to-live filter.
> * Converted to the new offloads API.
> * Supported device removal check operation.
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 822705060..f88ece123 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
> .dst_addr = -1,
> .type_of_service = -1,
> .next_proto_id = -1,
> - .time_to_live = -1,
> },
> },
> .default_mask = &rte_flow_item_ipv4_mask,
> --
> 2.12.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
2018-02-08 12:26 ` [dpdk-dev] [PATCH] " Nélio Laranjeiro
@ 2018-02-08 14:35 ` Ferruh Yigit
2018-02-08 14:38 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-02-08 14:35 UTC (permalink / raw)
To: Nélio Laranjeiro, Shahaf Shuler; +Cc: thomas, adrien.mazarguil, yskoh, dev
On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
>> Nor upstream kernel nor MLNX_OFED support such filter.
>>
>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
>> Cc: nelio.laranjeiro@6wind.com
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
2018-02-08 14:35 ` Ferruh Yigit
@ 2018-02-08 14:38 ` Thomas Monjalon
2018-02-08 14:47 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-02-08 14:38 UTC (permalink / raw)
To: Ferruh Yigit
Cc: dev, Nélio Laranjeiro, Shahaf Shuler, adrien.mazarguil, yskoh
08/02/2018 15:35, Ferruh Yigit:
> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
> > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
> >> Nor upstream kernel nor MLNX_OFED support such filter.
> >>
> >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
> >> Cc: nelio.laranjeiro@6wind.com
> >>
> >> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> >
> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> Applied to dpdk-next-net/master, thanks.
Have you applied the v1 or v2?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter
2018-02-08 14:38 ` Thomas Monjalon
@ 2018-02-08 14:47 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-02-08 14:47 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Nélio Laranjeiro, Shahaf Shuler, adrien.mazarguil, yskoh
On 2/8/2018 2:38 PM, Thomas Monjalon wrote:
> 08/02/2018 15:35, Ferruh Yigit:
>> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote:
>>> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote:
>>>> Nor upstream kernel nor MLNX_OFED support such filter.
>>>>
>>>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
>>>> Cc: nelio.laranjeiro@6wind.com
>>>>
>>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>>
>>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>
> Have you applied the v1 or v2?
v2 applied, but I reply to v1 by mistake.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-08 14:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 14:23 [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter Shahaf Shuler
2018-02-07 14:34 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-02-08 12:26 ` [dpdk-dev] [PATCH] " Nélio Laranjeiro
2018-02-08 14:35 ` Ferruh Yigit
2018-02-08 14:38 ` Thomas Monjalon
2018-02-08 14:47 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).