DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Matan Azrad <matan@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-dev]  [PATCH v2] ethdev: make ethdev data cache aligned
Date: Mon, 12 Feb 2018 11:24:39 +0530	[thread overview]
Message-ID: <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> (raw)
In-Reply-To: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com>

Since struct rte_eth_dev_data used in the fast path,
making it as cache aligned.

Fixes: af75078fece3 ("first public release")
Fixes: 5b7ba31148a8 ("ethdev: add port ownership")

Cc: Matan Azrad <matan@mellanox.com>
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
v2:
- Change the git comments based on Matan's feedback
https://dpdk.org/dev/patchwork/patch/35104/

- Some platform like thunderx + l3fwd showed 1% regression in
the performance with 5b7ba31148a8 ("ethdev: add port ownership")
in one port setup.

- If there are no objection for this change then request to
take it for v18.02 release.
---
 lib/librte_ether/rte_ethdev_core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h
index 315b31723..e5681e466 100644
--- a/lib/librte_ether/rte_ethdev_core.h
+++ b/lib/librte_ether/rte_ethdev_core.h
@@ -601,7 +601,7 @@ struct rte_eth_dev_data {
 	struct rte_vlan_filter_conf vlan_filter_conf;
 	/**< VLAN filter configuration. */
 	struct rte_eth_dev_owner owner; /**< The port owner. */
-};
+} __rte_cache_aligned;
 
 /**
  * @internal
-- 
2.16.1

  parent reply	other threads:[~2018-02-12  5:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10  9:42 [dpdk-dev] [PATCH] ethdev: fix a regression due to cache alignment issue Jerin Jacob
2018-02-10 18:23 ` Matan Azrad
2018-02-12  5:33   ` Jerin Jacob
2018-02-12  5:54 ` Jerin Jacob [this message]
2018-02-12  9:04   ` [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned Matan Azrad
2018-02-12  9:25     ` Jerin Jacob
2018-02-12  9:49       ` Matan Azrad
2018-02-12 10:20         ` Jerin Jacob
2018-02-12 12:10           ` Matan Azrad
2018-02-12 13:13   ` [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment Jerin Jacob
2018-02-12 13:44     ` Matan Azrad
2018-02-12 13:50       ` Jerin Jacob
2018-02-12 14:02         ` Matan Azrad
2018-02-12 14:11           ` Jerin Jacob
2018-02-13  9:42             ` Ferruh Yigit
2018-02-13 15:16     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212055439.6462-1-jerin.jacob@caviumnetworks.com \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=matan@mellanox.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).